Should the theme not adjust to the image size or adjust imagesize to theme??
My point is it seems that the wind theme also has a problem with image size after upgrade to latest git. This was not the case before.
all the best
HB
Okat
Joined: 2009-04-05
Posts: 77
Posted: Tue, 2009-11-10 22:04
Quote:
In advanced settings I changed from 200px to 150px. Did not change anything. Refreshed the browser as well...
Change the setting in admin/settings/advanced back to your previous setting and change the thumbnail size in appearance/theme options to the required size. You should get a message that you have to rebuild the thumbnails. It's a bug.
Okat
Joined: 2009-04-05
Posts: 77
Posted: Tue, 2009-11-10 22:12
@joemonster, did you include the "theme_3nids" module this time? Missed it in last git.
hebhansen
Joined: 2009-02-10
Posts: 573
Posted: Tue, 2009-11-10 22:23
Thanks Okat - Resizing right now :-/
Tagcloud active now - it shows 3 times ??? and not as flash but equal to popular tags???
all the best
HB
Okat
Joined: 2009-04-05
Posts: 77
Posted: Tue, 2009-11-10 22:54
Three times? Seems a bit overkill. Try admin/themes/magange sidebar and drag the modulue back. See if they're all gone. If so, drag it back and see if you only get one this time.. Had something like this as well at one time I think.
Can't find the module anymore. Forgot it's name. What's it called?
Thanks will move the block around tomorrow - late here.
The name of the module is Tag Cloud as I remember it...
The resizing worked out. Somehow it only mange to run half of the photos each time. 600 to 300, 300 to 150 etc etc down to 1.... This is not theme but relevant if others end in the same mess
all the best
HB
hebhansen
Joined: 2009-02-10
Posts: 573
Posted: Wed, 2009-11-11 01:45
Got it done and it solved multiple instance of blocks.
Joe: When going through the TagMap - Pop up - and click a thumb, you enter the pic view (no Lightbox). Could this be an option for the theme? and if going to pic view and clicking the resize. Could large size viewing be lightbox as opposed to an empty browser and a huge pic???
In general for lightbox. If set to resize-view globally in admin. Could it be possible to click in the box and increase to full size, still within lightbox and back again. I'm thinking of something like the cooliris slideshow in the bottom of frame.
@hebhansen: as said for tagsmap, it was intented to use with albums, not pictures, it's in TODO list (first message in topic)...so the behavior you describe was not intended!
About switching fullsize / resize, as I constructed the lightbox it is not possible right now.
joemonster
Joined: 2006-04-12
Posts: 236
Posted: Wed, 2009-11-11 08:50
@sddrog: Hi, I removed the menu if user is not admin, this is surely what's wrong here.
Go at 3nids/views/page.htmp.php at line 93 and remove bold lines:
these pages are never reached using Lightbox... Could the tag info be imported to the lightbox frame. I thought of a link next to EXIF and Comments saying Tags. This would then open a pop-up similiar to the other two links including the tags for the image...
all the best
HB
sky_surfer_fra
Joined: 2007-12-23
Posts: 23
Posted: Thu, 2009-11-12 18:53
Hi,
get the following error when trying to activate ndis3 theme:
Passed variable is not an array or object, using empty array instead
Hi joemonster,
I have downloaded it from http://github.com/3nids/gallery3-contrib/archives/master yesterday morning around 10:00am UTC. So I guess it is the current version.
If it would helpful for you I can provide url and admin password for gallery3 installation offline to you.
Try to support the gallery3 project as best as possible as I am a gallery2 fan since years and like the lean approach of gallery3 very much ;-)!
Regards, Tom
hebhansen
Joined: 2009-02-10
Posts: 573
Posted: Fri, 2009-11-13 11:34
Sky surfer
Your issue is not related to the 3nids theme. My guess is you have other 3'rd party themes installed, that are not fully updated for latest git. They cause the error!
Remove all themes from the theme folder exept: Wind,Wind_Night and Wind_admin
Check if you can acces the Themes from Gallery Admin. You should...
After that drop the 3nids theme-folder into your themes and remember the modules folder as well...; NOTE - FOR WHATEVER REASON THERE IS ANOTHER MODULES FOLDER IN THIS DOWNLOAD THAT HAS NO RELEVANCE TO THE THEME. MAKE SURE YOU GET THE RIGHT MODULE FOLDER!!
I HAVE MENTIONED THIS TO JOE AND I STILL DON'T GET WHAT THE EXTRA 7MB OF MODULES ARE DOING WITHIN A THEME DOWNLOAD???
Yes I did drop the extra modules into my site. I was looking for modules and I found it x 2??? Lucky for me they did not mess things up this time.
No disrespect at all. Very pleased with the theme and support. But the above approach is dangerous and IMO not the concept and intent of G3.
Again my suggestion is that any theme/module is folder structured as is the case for Gallery installations. That way adding whatever is only one dump and not 2, 4 or 10 dumps...
@hebhansen: the theme is within the gallery3-contrib folder...everything is regrouped, so it's easier for people to find everything and to keep up to date with git.
sky_surfer_fra
Joined: 2007-12-23
Posts: 23
Posted: Fri, 2009-11-13 15:38
Thanks guys!
Solved.
I had installed beta 3.
Now I understood to install latest git version (whatever git is ;-)).
Removed everything and did a complete new install.
After a first quick test everything runs perfectly!.
Great job you are doing with development and support!!!
It's the software we use to manage the source code for G3.
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here
Quick question, can anybody spot whats up with my slideshow button. The link does not work at all for me. I suspect this is completely NOT releated to this theme btw, as it happens on all, and seemed to appear this way after my G2 Import.
Good work on the theme, will report back regularly for any updates.
Noob86
Joined: 2006-12-31
Posts: 32
Posted: Sat, 2009-11-14 08:31
Heres what I thought "may" be a cool idea, if its doable that is. A link under the thumbs, to the "normal" picture page would be excellent. EG
@joemonster: it'd be nice if we could get the 3nids theme to conform to our module/theme separation in the gallery3-contrib repo. It's a little messy in there right now. What I'd like to see is:
Themes are just like modules, so you don't need the theme_3nids module, you can move the helpers, controllers and views directories from those into themes/3nids and they should just work. If they don't let me know.
I'll be happy to restructure it for you and bring it up to snuff if you'd like, just let me know. I'll wait a few days before restructuring it to give you a chance to think about that and respond.
---
Problems? Check gallery3/var/logs bugs/feature req's | upgrade to the latest code | use git
hebhansen
Joined: 2009-02-10
Posts: 573
Posted: Tue, 2009-11-17 09:00
Major issues for me right now are:
1) Latest Updates Module is not loading within this theme. Anyone have the same?
2) Comments are not working. Anyone have the same?
Joe - what's the timeframe for update. Are you waiting for RC?
@floridave: thnaks a lot, I'll have a look. Well seen!
@bharat: hi, thanks a lot for the tip. I'll fix it on my own ASAP. My mother in law died this week end, so I'm not really into gallery theses days. I'll do this next week probably.
bharat
Joined: 2002-05-21
Posts: 7985
Posted: Tue, 2009-11-17 18:10
@joemonster: I'm sorry to hear about your mother-in-law. I hope that your family is holding up ok. Let me know if you want me to help out with the restructuring.
@hebhansen: I just committed a fix for the latest updates module in git on github, you might want to try that again.
---
Problems? Check gallery3/var/logs bugs/feature req's | upgrade to the latest code | use git
hebhansen
Joined: 2009-02-10
Posts: 573
Posted: Tue, 2009-11-17 19:44
Joe - I am sorry too. Don't let the theme issues influence you at this time. Condolences to your family as well.
bharat: I am still not sure where to find latest updates unless directly linked within threads. Du you have a link for your additions?
Tagsmap Module:
A new version is out. The module adds a globe icon together with other icons as opposed to a header icon in the 3nids theme. Icons kept together looks better in my book. However, the new tagsmap module does not work with 3nids, showing tag'ed images/albums in the map. I have down graded to the 3nids compatible for now.
Calenderview:
Image pages do not load. Neither for photo days nor for photo months. It loads fine in other themes.
Latest Updates:
Images do not load. Works in other themes.
Some modules require the Lightbox not to trigger. It's it possible to add a activate/deactivate button for test purposes. Not yet sure how they work, but examples are Tag Faces and some more.
Joemonster, I hope you and your family are doing well following the passing of your mother-in-law. I tried to use your theme using the latest update from git as of about a hour ago. When I install your tagsmap module, I receive an error on the modules page. In troubleshoot, I found that the error was due to missing '"' in the module.info file. My edited file is:
Quote:
name = "TagsMap"
description = "Assign GPS coordinates to existing tags and display them on a map."
version = 1
I am having other problems with getting your theme to work but it appears to be a general problem with any them but the default right now. I'll submit a different note on that.
g
joemonster
Joined: 2006-04-12
Posts: 236
Posted: Wed, 2009-11-25 09:24
Hi all,
Thank you very much for your messages...Even if I have no face to put on these messages, they are very welcome.
So back to the theme...I'll try to bring a new update for tomorrow.
@bharat: I tried your suggestion about removing the module and bringing everything within the theme, and I have some issues. The admin menu (in content) is not shown anymore, and I have problems with comments (though I do not know if this comes from the structure).
Do you have an idea for the admin menu?
Thanks a lot
Denis
bharat
Joined: 2002-05-21
Posts: 7985
Posted: Thu, 2009-11-26 19:23
@joemonster: I'm in the middle of some other stuff now, but if you'd like I can take a shot at rearranging the version of 3nids in the gallery3-contrib repo to conform to our basic approach, and then check it in there. If I do that, then you'll need to pull my changes back into your fork. Give me the ok and I'll make that happen (and figure out what's wrong and fix it along the way).
---
Problems? Check gallery3/var/logs bugs/feature req's | upgrade to the latest code | use git
hebhansen
Joined: 2009-02-10
Posts: 573
Posted: Thu, 2009-11-26 20:39
Support from here - non compliance to the main path will eventually bring down the theme. And it's too good for that...
@joemonster: Great.. I'm working on this now. One question-- why is there a separate version of the tagsmap module in the 3nids theme? I'm going to get rid of that for now-- it'd be nice if you could roll your tagsmap related changes into the existing tagsmap module instead of forking it. Or if that's not possible, create a 3nids_tagsmap module in the modules directory for your own version. But it'd be nice if we didn't have to have a forked version...
---
Problems? Check gallery3/var/logs bugs/feature req's | upgrade to the latest code | use git
hebhansen
Joined: 2009-02-10
Posts: 573
Posted: Fri, 2009-11-27 23:28
Stay on main path for sure - Personnally I prefer the yellow pins and not the red with black dot. This is a detail though
Bharat: does this mean that images at icon will no longer work??? I really like that feature. Maybe add that to the main-module...
@bharat: hi, I modified the tagsmap module to use a different layout. I'll rename it on monday (I have ni access to it right now), otherwise you can rename it if you want to.
Thanks a lot
bharat
Joined: 2002-05-21
Posts: 7985
Posted: Sun, 2009-11-29 07:54
Ok, I spent a bunch of time on this and I think the end result is
pretty good. I've pushed all my changes to gallery3-contrib-- take
a look and tell me what you think. Everything I've done is open for
discussion!
I've cleaned up the theme in the contrib directory and made it work.
The only thing that *doesn't* work right now is that the Ajax
comment-add code doesn't function properly. You can add a comment,
but it doesn't render the result properly until you refresh the
comment view. We can fix this!
However, in the process I had to make some major changes that I hope
you're ok with. It's important to me that you still feel a sense of
ownership of the code and I tried to preserve your intent in all cases
while making the code conform to Gallery 3 conventions.
First of all, I had to rename it from 3nids to three_nids. This is
unfortunate, but necessary because PHP won't accept a digit as the
first letter of a token (so you can't have "$3nids" as a variable or
"class 3nids_controller"). I could not find a way around this, and
hope that "three_nids" is an acceptable compromise. I left it as
"3nids" in the visible text to preserve your brand.
The goal is to make the code in this theme appear as similar as
possible to the rest of the code base to make it easier for others to
read. Again, I hope that's ok.
On to the changes!
1) I axed the tagsmap module. We should merge any changes you had
into the existing tagsmap module so that this theme can stand on its
own.
2) I moved all the controllers and helpers from the theme_3nids module
into the three_nids theme. I made some core code changes to get
Gallery 3 to respect these new controllers (which is why it wasn't
working for you before)
3) I got rid of the photos_3nids and movies_3nids controllers. They
were designed to allow you to access your own views, but you don't
need to do that. Instead what I did is that I put your custom views
into views/photo.html.php and views/movie.html.php -- the regular
controllers will use those views directly. But since you want those
to appear in an ajax context, I added a little extra code to the top
of your page.html.php to just dump out the body of those pages if
you're viewing a photo or a movie. This gets rid of a lot of
duplicated code.
4) I got rid of the comments_3nids controller. It had a lot of
duplicated code. Instead, I created controllers/three_nids.php which
just has a show_comments function that uses your comments.html.php
view to print out comments in an Ajax-ready form. Again, this is all
your code, I just refocused it and got rid of the duplication.
Duplicating that code is bad because when we make changes to the
underlying comments code it would break you. Now it's much less
likely to cause breakages.
5) I got rid of your overridden helper/comments.php and moved the
comment counting functionality into the three_nids helper.
6) I did some very minor touch-up work in three_nids::fancylinks().
There's one bug I found in there that was causing the lightbox popups
to fail. I didn't fully fix it -- look for the @todo I left in there
for you.
7) Here's a bigger one. We have the problem that your three_nids
theme is not active when we're in admin mode. So we needed some way
to let your theme interact and have its own settings but not have it
clash with the admin theme. I created a way to do this in Gallery 3.
You create a separate "admin" subdirectory which is treated like its
own mini-module. Inside, you can have a second set of controllers,
helpers, views, whatever you need. That mini-module is available
during site admin. I pushed your settings controller and view in
there. The one catch is that we have to replicate the
three_nids_event helper in there as well because it needs to be able
to add itself to the menu in admin mode also.
Great work Bharat. Looking forward to try this out. At latest git you added changes. But that download does not include the three_nids theme. So where can I find the upgraded theme?
Is the Screen.css identical? I did a lot of changes to that file, and thought of dumping mine on top after upgrading?
Joe, I updated my gallery core and contribs from git and set 3nids to be my theme and voila, things are working much better!! I only have one issue. The graphics are larger than the boxes in which they show. This happens in the albums and in the enlarged ajax view. I have sent you a PM with the URL.
Posts: 573
Should the theme not adjust to the image size or adjust imagesize to theme??
My point is it seems that the wind theme also has a problem with image size after upgrade to latest git. This was not the case before.
all the best
HB
Posts: 77
Change the setting in admin/settings/advanced back to your previous setting and change the thumbnail size in appearance/theme options to the required size. You should get a message that you have to rebuild the thumbnails. It's a bug.
Posts: 77
@joemonster, did you include the "theme_3nids" module this time? Missed it in last git.
Posts: 573
Thanks Okat - Resizing right now :-/
Tagcloud active now - it shows 3 times ??? and not as flash but equal to popular tags???
all the best
HB
Posts: 77
Three times? Seems a bit overkill. Try admin/themes/magange sidebar and drag the modulue back. See if they're all gone. If so, drag it back and see if you only get one this time.. Had something like this as well at one time I think.
Can't find the module anymore. Forgot it's name. What's it called?
Posts: 16503
About the duplicate sidebar blocks:
http://sourceforge.net/apps/trac/gallery/ticket/876
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here
Posts: 573
Thanks will move the block around tomorrow - late here.
The name of the module is Tag Cloud as I remember it...
The resizing worked out. Somehow it only mange to run half of the photos each time. 600 to 300, 300 to 150 etc etc down to 1.... This is not theme but relevant if others end in the same mess
all the best
HB
Posts: 573
Got it done and it solved multiple instance of blocks.
Starting to look good. Played with your colors Joe: http://www.image.agentura.dk/index.php/
Joe: When going through the TagMap - Pop up - and click a thumb, you enter the pic view (no Lightbox). Could this be an option for the theme? and if going to pic view and clicking the resize. Could large size viewing be lightbox as opposed to an empty browser and a huge pic???
In general for lightbox. If set to resize-view globally in admin. Could it be possible to click in the box and increase to full size, still within lightbox and back again. I'm thinking of something like the cooliris slideshow in the bottom of frame.
Lightbox2 from Drupal has this if familiar.
all the best
HB
Posts: 236
@okat: well, for the scroll bar, I have no idea what it comes from...do you?
about the module theme_3nids, it placed here: http://github.com/3nids/gallery3-contrib/tree/master/themes/3nids_theme/modules/
@hebhansen: as said for tagsmap, it was intented to use with albums, not pictures, it's in TODO list (first message in topic)...so the behavior you describe was not intended!
About switching fullsize / resize, as I constructed the lightbox it is not possible right now.
Posts: 236
@sddrog: Hi, I removed the menu if user is not admin, this is surely what's wrong here.
Go at 3nids/views/page.htmp.php at line 93 and remove bold lines:
Posts: 573
Comments are not working for me... Any ideas?
Not when logged in and not as guest either
all the best
HB
Posts: 132
That fixed it, thanks!
Posts: 573
The displaytag - module only shows in resize image pages...
http://gallery.menalto.com/node/89093
these pages are never reached using Lightbox... Could the tag info be imported to the lightbox frame. I thought of a link next to EXIF and Comments saying Tags. This would then open a pop-up similiar to the other two links including the tags for the image...
all the best
HB
Posts: 23
Hi,
get the following error when trying to activate ndis3 theme:
Passed variable is not an array or object, using empty array instead
File: modules/gallery/controllers/admin_themes.php, line: 38
Required Bootstrap.php is present at /gallery/system/core after a clean install and copying 3ndis over installation
Steps I do:
* Starting from Gallery3 index
* Admin --> Appereance --> Team Choice
==> ERROR
Before installing 3ndis, this worked fine.
Regards, Tom
-------------------------------------------------------
Here is the detailed error message:
So here's the error:
Passed variable is not an array or object, using empty array instead
File: modules/gallery/controllers/admin_themes.php, line: 38
And here's how we got there:
* modules/gallery/controllers/admin_themes.php [38]:
ArrayObject->__construct( )
* modules/gallery/controllers/admin_themes.php [26]:
Admin_Themes_Controller->_get_themes( )
* modules/gallery/controllers/admin.php [50]:
Admin_Themes_Controller->index( )
*
Admin_Controller->__call( Array
(
[0] => Admin_Themes_Controller Object
(
[theme:private] =>
[uri] => URI Object
(
)
[input] => Input Object
(
[use_xss_clean:protected] => 1
[magic_quotes_gpc:protected] => 1
[ip_address] =>
)
)
[1] => index
)
)
* system/core/Kohana.php [291]:
ReflectionMethod->invokeArgs( themes )
* system/core/Event.php [209]:
Kohana::instance( Admin_Controller Object
(
[theme:private] =>
[uri] => URI Object
(
)
[input] => Input Object
(
[use_xss_clean:protected] => 1
[magic_quotes_gpc:protected] => 1
[ip_address] =>
)
)
, Array
(
[0] => themes
[1] => Array
(
)
)
)
* system/core/Bootstrap.php [55]:
Event::run( )
* index.php [86]:
require( system/core/Bootstrap.php )
Posts: 236
@sky_surfer_fra: do you use last git version ?
Posts: 23
Hi joemonster,
I have downloaded it from http://github.com/3nids/gallery3-contrib/archives/master yesterday morning around 10:00am UTC. So I guess it is the current version.
If it would helpful for you I can provide url and admin password for gallery3 installation offline to you.
Try to support the gallery3 project as best as possible as I am a gallery2 fan since years and like the lean approach of gallery3 very much ;-)!
Regards, Tom
Posts: 573
Sky surfer
Your issue is not related to the 3nids theme. My guess is you have other 3'rd party themes installed, that are not fully updated for latest git. They cause the error!
Remove all themes from the theme folder exept: Wind,Wind_Night and Wind_admin
Check if you can acces the Themes from Gallery Admin. You should...
After that drop the 3nids theme-folder into your themes and remember the modules folder as well...; NOTE - FOR WHATEVER REASON THERE IS ANOTHER MODULES FOLDER IN THIS DOWNLOAD THAT HAS NO RELEVANCE TO THE THEME. MAKE SURE YOU GET THE RIGHT MODULE FOLDER!!
I HAVE MENTIONED THIS TO JOE AND I STILL DON'T GET WHAT THE EXTRA 7MB OF MODULES ARE DOING WITHIN A THEME DOWNLOAD???
Yes I did drop the extra modules into my site. I was looking for modules and I found it x 2??? Lucky for me they did not mess things up this time.
No disrespect at all. Very pleased with the theme and support. But the above approach is dangerous and IMO not the concept and intent of G3.
Again my suggestion is that any theme/module is folder structured as is the case for Gallery installations. That way adding whatever is only one dump and not 2, 4 or 10 dumps...
all the best
HB
Posts: 236
@sky_surfer_fra: I'm talking about gallery last git version, not the theme's. Go to: http://codex.gallery2.org/Gallery:Using_Git
@hebhansen: the theme is within the gallery3-contrib folder...everything is regrouped, so it's easier for people to find everything and to keep up to date with git.
Posts: 23
Thanks guys!
Solved.
I had installed beta 3.
Now I understood to install latest git version (whatever git is ;-)).
Removed everything and did a complete new install.
After a first quick test everything runs perfectly!.
Great job you are doing with development and support!!!
Cheers,
Tom
Posts: 16503
Info on git:
http://git-scm.com/
http://en.wikipedia.org/wiki/Git_%28software%29
It's the software we use to manage the source code for G3.
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here
Posts: 573
New issue - I installed the latest updates module by rWatcher:
http://gallery.menalto.com/node/88936#comment-327000
The update page loads the header and Heading and stops. No images loaded.
Latest updates work for the Wind Theme, but not for 3nids.... Any ideas? Check it on my site below
When
all the best
HB - http://www.image.agentura.dk
Posts: 32
Thanks for the awesome theme, looks fantastic!
http://www.bikesnstuff.net/gallery3/
Quick question, can anybody spot whats up with my slideshow button. The link does not work at all for me. I suspect this is completely NOT releated to this theme btw, as it happens on all, and seemed to appear this way after my G2 Import.
Good work on the theme, will report back regularly for any updates.
Posts: 32
Heres what I thought "may" be a cool idea, if its doable that is. A link under the thumbs, to the "normal" picture page would be excellent. EG
http://www.bikesnstuff.net/gallery3/index.php/bikes/red94
A link under the thumbs, so you can still get here, unless I'm missing something that is.
http://www.bikesnstuff.net/gallery3/index.php/photos/172
hope that makes sense.
Posts: 25961
joemonster or any other theme devs that are assisting joemonster,
Please look at recent changes to pagination:
http://github.com/gallery/gallery3/commit/081ce9f6ca07b834fd31d3d340990504dd68f821
&
http://github.com/gallery/gallery3/commit/29efb6ba9f3e2cf15f29b509f985890c33bc08fa
New ways of pagination,documented in the files for theme developers.
Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team
Posts: 7985
@joemonster: it'd be nice if we could get the 3nids theme to conform to our module/theme separation in the gallery3-contrib repo. It's a little messy in there right now. What I'd like to see is:
gallery3-contrib \-- modules | \-- tagsmap_3nids \-- themes \-- 3nidsThemes are just like modules, so you don't need the theme_3nids module, you can move the helpers, controllers and views directories from those into themes/3nids and they should just work. If they don't let me know.
I'll be happy to restructure it for you and bring it up to snuff if you'd like, just let me know. I'll wait a few days before restructuring it to give you a chance to think about that and respond.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git
Posts: 573
Major issues for me right now are:
1) Latest Updates Module is not loading within this theme. Anyone have the same?
2) Comments are not working. Anyone have the same?
Joe - what's the timeframe for update. Are you waiting for RC?
all the best
HB - http://www.image.agentura.dk
Posts: 573
I added the calender Module. Images do not load. It works in the wind theme. Same as Latest Updates.
Anyone knows why?
all the best
HB - http://www.image.agentura.dk
Posts: 573
Calender module
http://gallery.menalto.com/node/92405#comment-327310
all the best
HB - http://www.image.agentura.dk
Posts: 236
@floridave: thnaks a lot, I'll have a look. Well seen!
@bharat: hi, thanks a lot for the tip. I'll fix it on my own ASAP. My mother in law died this week end, so I'm not really into gallery theses days. I'll do this next week probably.
Posts: 7985
@joemonster: I'm sorry to hear about your mother-in-law. I hope that your family is holding up ok. Let me know if you want me to help out with the restructuring.
@hebhansen: I just committed a fix for the latest updates module in git on github, you might want to try that again.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git
Posts: 573
Joe - I am sorry too. Don't let the theme issues influence you at this time. Condolences to your family as well.
bharat: I am still not sure where to find latest updates unless directly linked within threads. Du you have a link for your additions?
all the best
HB - http://www.image.agentura.dk
Posts: 16503
hebhansen, latest updates can be found here:
Gallery 3: http://github.com/gallery/gallery3
Gallery3-Contrib: http://github.com/gallery/gallery3-contrib
http://codex.gallery2.org/Gallery3:Upgrading
Some more helpful docs if you want to use the command line to update and stay current:
http://codex.gallery2.org/Gallery:Using_Git
http://codex.gallery2.org/Gallery:Git_FAQ
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here
Posts: 573
Latest updates from the link above still does not work within the 3nids theme
all the best
HB - http://www.image.agentura.dk
Posts: 77
I'm sorry for your loss, Joe.
Posts: 573
Small sum-up, probably for my own convenience:
Tagsmap Module:
A new version is out. The module adds a globe icon together with other icons as opposed to a header icon in the 3nids theme. Icons kept together looks better in my book. However, the new tagsmap module does not work with 3nids, showing tag'ed images/albums in the map. I have down graded to the 3nids compatible for now.
Calenderview:
Image pages do not load. Neither for photo days nor for photo months. It loads fine in other themes.
Latest Updates:
Images do not load. Works in other themes.
Some modules require the Lightbox not to trigger. It's it possible to add a activate/deactivate button for test purposes. Not yet sure how they work, but examples are Tag Faces and some more.
all the best
HB - http://www.image.agentura.dk
Posts: 573
Ongoing discussion concerning Comments import from Facebook. Will this comply to 3nids theme?
http://gallery.menalto.com/node/92448#comment-327654
all the best
HB - http://www.image.agentura.dk
Posts: 3
Joemonster, I hope you and your family are doing well following the passing of your mother-in-law. I tried to use your theme using the latest update from git as of about a hour ago. When I install your tagsmap module, I receive an error on the modules page. In troubleshoot, I found that the error was due to missing '"' in the module.info file. My edited file is:
I am having other problems with getting your theme to work but it appears to be a general problem with any them but the default right now. I'll submit a different note on that.
g
Posts: 236
Hi all,
Thank you very much for your messages...Even if I have no face to put on these messages, they are very welcome.
So back to the theme...I'll try to bring a new update for tomorrow.
@bharat: I tried your suggestion about removing the module and bringing everything within the theme, and I have some issues. The admin menu (in content) is not shown anymore, and I have problems with comments (though I do not know if this comes from the structure).
Do you have an idea for the admin menu?
Thanks a lot
Denis
Posts: 7985
@joemonster: I'm in the middle of some other stuff now, but if you'd like I can take a shot at rearranging the version of 3nids in the gallery3-contrib repo to conform to our basic approach, and then check it in there. If I do that, then you'll need to pull my changes back into your fork. Give me the ok and I'll make that happen (and figure out what's wrong and fix it along the way).
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git
Posts: 573
Support from here - non compliance to the main path will eventually bring down the theme. And it's too good for that...
all the best
HB - http://www.image.agentura.dk
Posts: 236
@bharat: ok. Thnaks a lot, go ahead!
Posts: 7985
@joemonster: Great.. I'm working on this now. One question-- why is there a separate version of the tagsmap module in the 3nids theme? I'm going to get rid of that for now-- it'd be nice if you could roll your tagsmap related changes into the existing tagsmap module instead of forking it. Or if that's not possible, create a 3nids_tagsmap module in the modules directory for your own version. But it'd be nice if we didn't have to have a forked version...
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git
Posts: 573
Stay on main path for sure - Personnally I prefer the yellow pins and not the red with black dot. This is a detail though
Bharat: does this mean that images at icon will no longer work??? I really like that feature. Maybe add that to the main-module...
all the best
HB - http://www.image.agentura.dk
Posts: 236
@bharat: hi, I modified the tagsmap module to use a different layout. I'll rename it on monday (I have ni access to it right now), otherwise you can rename it if you want to.
Thanks a lot
Posts: 7985
Ok, I spent a bunch of time on this and I think the end result is
pretty good. I've pushed all my changes to gallery3-contrib-- take
a look and tell me what you think. Everything I've done is open for
discussion!
I've cleaned up the theme in the contrib directory and made it work.
The only thing that *doesn't* work right now is that the Ajax
comment-add code doesn't function properly. You can add a comment,
but it doesn't render the result properly until you refresh the
comment view. We can fix this!
However, in the process I had to make some major changes that I hope
you're ok with. It's important to me that you still feel a sense of
ownership of the code and I tried to preserve your intent in all cases
while making the code conform to Gallery 3 conventions.
First of all, I had to rename it from 3nids to three_nids. This is
unfortunate, but necessary because PHP won't accept a digit as the
first letter of a token (so you can't have "$3nids" as a variable or
"class 3nids_controller"). I could not find a way around this, and
hope that "three_nids" is an acceptable compromise. I left it as
"3nids" in the visible text to preserve your brand.
Second, I reformatted much of the indentation, whitespace and naming
to match the Gallery 3 coding style:
http://codex.gallery2.org/Gallery3:Coding_Standards
The goal is to make the code in this theme appear as similar as
possible to the rest of the code base to make it easier for others to
read. Again, I hope that's ok.
On to the changes!
1) I axed the tagsmap module. We should merge any changes you had
into the existing tagsmap module so that this theme can stand on its
own.
2) I moved all the controllers and helpers from the theme_3nids module
into the three_nids theme. I made some core code changes to get
Gallery 3 to respect these new controllers (which is why it wasn't
working for you before)
3) I got rid of the photos_3nids and movies_3nids controllers. They
were designed to allow you to access your own views, but you don't
need to do that. Instead what I did is that I put your custom views
into views/photo.html.php and views/movie.html.php -- the regular
controllers will use those views directly. But since you want those
to appear in an ajax context, I added a little extra code to the top
of your page.html.php to just dump out the body of those pages if
you're viewing a photo or a movie. This gets rid of a lot of
duplicated code.
4) I got rid of the comments_3nids controller. It had a lot of
duplicated code. Instead, I created controllers/three_nids.php which
just has a show_comments function that uses your comments.html.php
view to print out comments in an Ajax-ready form. Again, this is all
your code, I just refocused it and got rid of the duplication.
Duplicating that code is bad because when we make changes to the
underlying comments code it would break you. Now it's much less
likely to cause breakages.
5) I got rid of your overridden helper/comments.php and moved the
comment counting functionality into the three_nids helper.
6) I did some very minor touch-up work in three_nids::fancylinks().
There's one bug I found in there that was causing the lightbox popups
to fail. I didn't fully fix it -- look for the @todo I left in there
for you.
7) Here's a bigger one. We have the problem that your three_nids
theme is not active when we're in admin mode. So we needed some way
to let your theme interact and have its own settings but not have it
clash with the admin theme. I created a way to do this in Gallery 3.
You create a separate "admin" subdirectory which is treated like its
own mini-module. Inside, you can have a second set of controllers,
helpers, views, whatever you need. That mini-module is available
during site admin. I pushed your settings controller and view in
there. The one catch is that we have to replicate the
three_nids_event helper in there as well because it needs to be able
to add itself to the menu in admin mode also.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git
Posts: 573
Great work Bharat. Looking forward to try this out. At latest git you added changes. But that download does not include the three_nids theme. So where can I find the upgraded theme?
Is the Screen.css identical? I did a lot of changes to that file, and thought of dumping mine on top after upgrading?
all the best
HB - http://www.image.agentura.dk
Posts: 25961
Gallery3-Contrib: http://github.com/gallery/gallery3-contrib click the download button.
Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team
Posts: 573
I fetched the zip as well as the tar. No theme in there. Only modules.
Are we supposed to upgrade core for this to work?
all the best
HB - http://www.image.agentura.dk
Posts: 25961
It worked for me on 2009-11-29 08:33
but now it does not.
Could be related to this bug in the git hub: http://support.github.com/discussions/repos/1973-source-files-missing-from-download
But it is closed, Perhaps it needs to be reopend.
Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team
Posts: 3
bharat - Thanks for your efforts!!
Joe, I updated my gallery core and contribs from git and set 3nids to be my theme and voila, things are working much better!! I only have one issue. The graphics are larger than the boxes in which they show. This happens in the albums and in the enlarged ajax view. I have sent you a PM with the URL.
Thanks,
g