Todo List
GalleryCore
- Convert this to use UnitTestStorage
- When we get rid of double read locks, we can delete this.
- will be removed in the next API branch
- Verify that both arguments are arrays.
- Ensure that the active user ($gallery->getActiveUser) is changed as well
- Delete on the next major API bump as it is not referenced.
- This needs to be refactored.
- Split this into two separate functions, one that downloads the file, the other that returns the descriptor. The function that downloads the file should take the descriptor so that it can verify that the file that got downloaded is the right length.
- This method knows too much about a small set of operations. We should move it into the toolkits themselves.
- When the progress bar handling is standardized for both upgrades and maintenance screens, then replace the call back function with a StatusMonitor object.
- On next major api bump make private or inline in getFileRevision()
- We should probably be checking the data we get back against the HTTP Content-Length header to verify that we got all the data we expected.
- Remove this class on next major bump of core/embed api.
- Remove this class on next major bump of core/embed api.
- go through and standardize the usage or remove the langCode usage and just use locale
- go through and standardize the usage or remove the langCode usage and just use locale
- (bharat): Get rid of this; it's no longer necessary
- for next major version bump:
- remove GallerySession::getSessionId
- remove GalleryPlatform::recursiveFixDirPermissions
- remove GalleryUtilities::htmlEntityDecode
- remove GalleryUrlGenerator::getGalleryId
- remove GalleryStatus::wrap
- change GalleryCoreApi::error to only take error code and error message
- remove GalleryCapabilities (major bump of embed api too?)
- remove 'link' entry in Gallery.class constructor
- remove GalleryCoreApi::getPluginBaseDirs();
- remove GalleryCoreApi::getPluginBaseDir();
- remove GalleryCoreApi::isPluginInDefaultLocation();
- remove $skipBaseDirectoryDetection from GalleryCoreApi::requireOnce();
- remove support for check[Sidebar|Album|Photo]Blocks deprecated params
for ShouldShowEmergencyEditItemLink in Callbacks.inc
and comment in blocks/EmergencyEditItemLink.tpl
- remove GalleryView::_getItem() (the private version of getItem());
- remove support for : separator in GalleryView::loadView
- delete GallerySqlFragment.class
- remove studyPermissions, fetchPermissionsForItems does the same and more.
- remove GalleryUtilities::utf8Substring (moved to GalleryCoreApi)
- remove lib/wz_dragdrop/ (currently used by G2.1's watermark module)
- refactor renderer code (methods: getRenderer and render, GalleryEntity vs GalleryItem)
- remove support for {modules,themes}/.../locale dirs from lib/tools/po scripts
from GalleryTranslatorHelper_medium::installTranslationsForPlugin,
and from getPackageNames() in lib/tools/repository/classes/RepositoryDescriptor.class
- remove resourceGetTemplateBaseDir from GalleryTemplate class
- delete GalleryTestCase::failWithStatus
- loadEntitiesById and deleteEntityById: make optional $requiredEntityType mandatory
- remove GalleryCoreApi::registerEventListener, GalleryModule::registerEventListeners
and other code marked for removal in helpers/GalleryEventHelper_simple.class
- consider renaming everything using "languageCode" to "locale" for correct terminology
(GalleryTranslator.class and Gallery.class)
- delete modules/core/templates/blocks/NavigationLinks.tpl
- remove GalleryRepository::getLanguageDescription
- convert the contents of GALLERY_PERMISSION_SESSION_KEY to array indices instead of array
of values.
- On the next major API bump:
- Remove backwards compatible CSS from lib/javascript/AutoComplete.js
- for next major version bump:
- Change GalleryDataItem::render to match GalleryRenderer::render and
consider dropping the format, since it's always HTML.
- Drop the redirect url from GalleryPlugin::deactivate() (also requires a
major bump in GalleryTheme)
- Remove TYPE=DB_TABLE_TYPE replacement in MySqlStorage::_getSqlReplacements
- change signature of getItemlinks() in all modules (add new parameter)
- Remove rewrite v1.1.8 version checks in webdav, watermark, httpauth, ... (look for todo)
- Change ->_templateVersion = x to ->setTemplateVersion(x) in module constructors
- Remove navId and statusId related functions in GalleryUrlGenerator and GallerySession
- Remove webdav related backwards-compatibility code in ItemAddController.
- On next major api bump make private or inline in getFileRevision()
- Remove on next major bump of core api
- Move this information into a configuration file
- will be removed in the next API branch
- will be removed in the next API branch
- will be removed in the next API branch
- use priorities for choosing the correct toolkit
- use priorities for choosing the correct toolkit
- Consider removing this method when refactoring the renderer code.
- will be removed in the next API branch
- Scalability - Don't load all album-items into memory. Need a way to load the items incrementally, e.g. with an AJAX-powered tree widget.
- Remove at the next major version bump of core API
- Figure out a more graceful way to deal with errors here.
- will be removed in the next API branch
- will be removed in the next API branch
- Scalability - Don't load all album-items into memory. Need a way to load the items incrementally, e.g. with an AJAX-powered tree widget.
- use the real progress bar when we unify the two implementations.
- Make sure that 'order' stuff is maintained, so that the moved items become the last in order in the new album if that album is marked as unordered
- Remove on next major API bump
- After PHP 4.x.x then change to a __destruct and change the call to an unset()
- Scalability - Lock and load the items in batches (open files limit).
- Change this API to match that of GalleryRenderer::render() on the next major GalleryModule API bump.
- Convert this to using UnitTestStorage
- Convert this to using UnitTestStorage
- Remove this test on next core API bump
- Show a summary page (or at least a link to it) which contains details about the exact tasks that were performed and any errors that were encountered.
- When the various progress bar methods are standardized, change this call to call the update progress bar of a common status notifier.
- Move this routine to GalleryUtilities as a common function.
- Remove on next major API bump
- The extra key for exif module is a quick fix, not a permanent fix; it should be cached on the block level not on page level.
- This function is duplicated in ItemEditCaptions.inc, so it needs to be consolidated somehow.
- CAST empty to NULL ? values from DB too?
Comment
- This should get refactored up into UnitTestPlatform so that other tests can use it.
Watermark
- Testability: Change the class name such that it doesn't collide with core.DownloadItem
- Testability: Change the class name such that it doesn't collide with core.DownloadItem
- The explicit rewrite module version check can be removed on the next major Module API version.
- Broaden this interface to allow a GalleryStatus return code
Slideshow
- make this test run faster by overriding SLIDESHOW_MEDIARSS_ITEMS_PER_PAGE
- refactor all the various _sendFile() implementations into an API call
- refactor this method out into GalleryTestCase, and add support for optional headers.
Exif
- (xlerb) more tests, to be really sure, that our new underlying lib/JPEG does it's job well. This will ensure a working G2 even in case, lib/JPEG changes (especially because the lib/JPEG author has delegated some work on the lib to me). Also, there are plans to reduce include penalties for lib/JPEG. Let us protect against failures before actually changing the lib. And, by definition/specs, IPTC data may be spread throughout JPEG files, responsible to follow specs is the application writing IPTC data. Theoretically one could create mock files to test all variants of allowed (per spec) meta data distribution ... when I someday will be able to do that, I'll do for G2 (then as the author of the "final" EXIF/IPTC/XMP application and surely senior developer at Adobe Inc. :). Until then I'm happy to "keep G2 running" and fall back to just test common IPTC apps around and the correctness of lib/exifer and lib/JPEG to handle the resulting binaries. Tests to add are especially JPEG files manipulated by more than one IPTC capable application in turn, e.g. PS->Exifer->IrfanView. Also the current jpeg files are all produced on little endian machines. Small jpeg files produced on big endian machines and stored as big endian would provide for another neccessary test.
- (xlerb) more tests, to be really sure, that our new underlying lib/JPEG does it's job well. This will ensure a working G2 even in case, lib/JPEG changes (especially because the lib/JPEG author has delegated some work on the lib to me). Also, there are plans to reduce include penalties for lib/JPEG. Let us protect against failures before actually changing the lib. And, by definition/specs, IPTC data may be spread throughout JPEG files, responsible to follow specs is the application writing IPTC data. Theoretically one could create mock files to test all variants of allowed (per spec) meta data distribution ... when I someday will be able to do that, I'll do for G2 (then as the author of the "final" EXIF/IPTC/XMP application and surely senior developer at Adobe Inc. :). Until then I'm happy to "keep G2 running" and fall back to just test common IPTC apps around and the correctness of lib/exifer and lib/JPEG to handle the resulting binaries. Tests to add are especially JPEG files manipulated by more than one IPTC capable application in turn, e.g. PS->Exifer->IrfanView. Also the current jpeg files are all produced on little endian machines. Small jpeg files produced on big endian machines and stored as big endian would provide for another neccessary test.
- (xlerb) reduce size of lib/JPEG: 1. remove whitespace/comments; 2. refactor according to lazy reading. Before refactoring, add timing tests.
- (xlerb) have IPTC input charset default in EXIF/IPTC admin interface.
- (xlerb) have IPTC input charset overrides for albums (maybe images too?) for cases, where users from different countries can upload images with IPTC data. It is such a pain, that the charset used isn't recorded in IPTC headers.
- (xlerb) check for IPTC.DateCreated and IPTC.TimeCreated additionally? Problem: only date set by Adobe in IPTC, set time to 0 = midnight or 12 = noon? Also, which priority has it: it was explicitely set by the editor, thus first priority? Or to be considered just before IFD0.DateTime == last modification time?
Gallery
- Move this routine to GalleryUtilities as a common function.
- At some future date, decode the data from base64 encoded. Only if a similiar change is done to GalleryDatabaseExport.
Getid3
- (donw) Implement postProcessValue
ImageBlock
- Respect DisabledMap on INSERT such that we don't have to join the DisabledMap on SELECT
- figure out a way to only do this if we're going to run a test that wants to exercise _GalleryMain
ItemAdd
- Don't let the user select folders if the user is missing the core.addAlbum permission.
HttpAuth
- Explicit rewrite module version check can be removed on next major module API version.
WebDav
- The explicit rewrite module version check can be removed on the next major Module API version.
- Make corresponding Gallery locks persist between requests
- Simplify function signature
- Simplify function signature
- What does a query-string based WebDAV client send in HTTP_DESTINATION?
Jpegtran
- Add getMinimumManagedToolkitPriority() method to core API and use it here.
|
|
