How to use rules

As it was mentioned

graphics::add_rule("gallery", "thumb", "resize", array("width" => 200, "height" => 200, "master" => Image::AUTO), 100);

defines the rule for the thumb
I read it as following: "when creating a thumb use "resize" operation with the params specified"

Could rules be combined? If I define rules as following

graphics::add_rule("gallery", "thumb", "resize", array("width" => 300, "height" => 300, "master" => Image::AUTO), 99);
graphics::add_rule("gallery", "thumb", "crop", array("width" => 200, "height" => 200, "top" => 0, "left" => 0), 100);

Would it work?

But anyway, from poking around, it seems that what you're proposing could work. Worth a shot anyway. admin_theme_options.php is where the rule is added whenever you change the size of the thumbs....

edit: ignore everything else I've said, it doesn't work. Still poking around...

well the original stuff I was talking about in this thread won't work. The cmdline command I posted is only for the latest IM, which I don't have available (C'mon 1&1, get with the times).

I've been poking around in ImageMagick.php trying to make the cmd's work the way I want, but I keep getting full size images instead of thumbnails. I tried adding an Image::SQUARE property to the "master" argument, but that just gave me a Forbidden error upon saving the theme options. Now I'm trying to put things back to original and start from scratch again, but I still have the issue of getting full size "thumbs."

modules\gallery\controllers\admin_theme_options.php sets the rule when you change the thumb size.
system\libraries\drivers\Image\ImageMagick.php contains the actual call to the IM binary.

http://www.imagemagick.org/Usage/resize/#space_fill is how you can accomplish what we want in one command with IM that isn't the latest. The latest version is easier and less complicated ( http://www.imagemagick.org/Usage/resize/#fill )

Cool, I am looking forward to see final result Please keep us posted

this is why I was looking to use thumb command only and keep resize params as is

I hear you there. In my haste to "make it work" this is what happened. I do think though that additional available "master" parameters should clear this up and make things tidy.

So here's what I've come up with so far. Basically I've added an Image::SQUARE constant and made it a valid property.

in gallery3/system/libraries/Image.php find:

	// Master Dimension
	const NONE = 1;
	const AUTO = 2;
	const HEIGHT = 3;
	const WIDTH = 4;

Change to:

	// Master Dimension
	const NONE = 1;
	const AUTO = 2;
	const HEIGHT = 3;
	const WIDTH = 4;
	const SQUARE = 7;

Find:

			case 'master':
				if ($value !== Image::NONE AND
				    $value !== Image::AUTO AND
				    $value !== Image::WIDTH AND
				    $value !== Image::HEIGHT)
					return FALSE;

Change to:

			case 'master':
				if ($value !== Image::NONE AND
				    $value !== Image::SQUARE AND
				    $value !== Image::AUTO AND
				    $value !== Image::WIDTH AND
				    $value !== Image::HEIGHT)
					return FALSE;

In gallery3/system/libraries/drivers/Image/ImageMagick.php, find:

		switch ($prop['master'])
		{
			case Image::WIDTH:  // Wx
				$dim = escapeshellarg($prop['width'].'x');
			break;
			case Image::HEIGHT: // xH
				$dim = escapeshellarg('x'.$prop['height']);
			break;
			case Image::AUTO:   // WxH
				$dim = escapeshellarg($prop['width'].'x'.$prop['height']);
			break;
			case Image::NONE:   // WxH!
				$dim = escapeshellarg($prop['width'].'x'.$prop['height'].'!');
			break;
		}

Change to:

		switch ($prop['master'])
		{
			case Image::WIDTH:  // Wx
				$dim = escapeshellarg($prop['width'].'x');
			break;
			case Image::HEIGHT: // xH
				$dim = escapeshellarg('x'.$prop['height']);
			break;
			case Image::AUTO:   // WxH
				$dim = escapeshellarg($prop['width'].'x'.$prop['height']);
			break;
			case Image::NONE:   // WxH!
				$dim = escapeshellarg($prop['width'].'x'.$prop['height'].'!');
			break;
			case Image::SQUARE: // funky IM syntax for creation of square thumbs
				// Can't use escapeshellarg() here because it's not just a single argument this time.
				// Would be easier if everybody had the latest IM, but this way is more compatible.
				$dim = 'x'.(2 * $prop['height']).' -resize \''.(2 * $prop['width']).'x<\' -resize 50\% -gravity center -crop '.$prop['width'].'x'.$prop['height'].'+0+0 +repage';
			break;
		}

in gallery3/modules/gallery/controllers/admin_theme_options.php find:

        graphics::add_rule(
          "gallery", "thumb", "resize",
          array("width" => $thumb_size, "height" => $thumb_size, "master" => Image::AUTO),
          100);

change to:

        graphics::add_rule(
          "gallery", "thumb", "resize",
          array("width" => $thumb_size, "height" => $thumb_size, "master" => Image::SQUARE),
          100);

I haven't yet figured out how to add an option to the theme options form to choose from square or normal (can't even find the form yet) but I will be working on it. So far this works when you change the thumb size in the theme options and rebuild. I haven't yet tried adding new images or anything. *edit: yes, it works when adding new images*

Sorry Serge, I didn't mean to hijack your thread. One thing I did notice about the way you've proposed the rules is that if you have anything with funky dimensions like panoramas, you probably won't get the desired result still, as the first resize should be big enough to keep the short side at 200px. For most 3x4 or 4x6 images this is fine though.

So, ignore my previous edit for admin_theme_options. I have something better.

In /gallery3/modules/gallery/helpers/theme.php, find:

  static function get_edit_form_admin() {
    $form = new Forge("admin/theme_options/save/", "", null, array("id" =>"gThemeOptionsForm"));
    $group = $form->group("edit_theme");
    $group->input("page_size")->label(t("Items per page"))->id("gPageSize")
      ->rules("required|valid_digit")
      ->value(module::get_var("gallery", "page_size"));
    $group->input("thumb_size")->label(t("Thumbnail size (in pixels)"))->id("gThumbSize")
      ->rules("required|valid_digit")
      ->value(module::get_var("gallery", "thumb_size"));
    $group->input("resize_size")->label(t("Resized image size (in pixels)"))->id("gResizeSize")
      ->rules("required|valid_digit")
      ->value(module::get_var("gallery", "resize_size"));
    $group->textarea("header_text")->label(t("Header text"))->id("gHeaderText")
      ->value(module::get_var("gallery", "header_text"));
    $group->textarea("footer_text")->label(t("Footer text"))->id("gFooterText")
      ->value(module::get_var("gallery", "footer_text"));
    $group->checkbox("show_credits")->label(t("Show site credits"))->id("gFooterText")
      ->checked(module::get_var("gallery", "show_credits"));
    $group->submit("")->value(t("Save"));
    return $form;
  }

Change to:

  static function get_edit_form_admin() {
    $form = new Forge("admin/theme_options/save/", "", null, array("id" =>"gThemeOptionsForm"));
    $group = $form->group("edit_theme");
    $group->input("page_size")->label(t("Items per page"))->id("gPageSize")
      ->rules("required|valid_digit")
      ->value(module::get_var("gallery", "page_size"));
    $group->input("thumb_size")->label(t("Thumbnail size (in pixels)"))->id("gThumbSize")
      ->rules("required|valid_digit")
      ->value(module::get_var("gallery", "thumb_size"));
    $group->checkbox("thumb_squares")->label(t("Generate square thumbnails (only works with ImageMagick)"))->id("gThumbSquares")
      ->checked(module::get_var("gallery", "thumb_squares"));
    $group->input("resize_size")->label(t("Resized image size (in pixels)"))->id("gResizeSize")
      ->rules("required|valid_digit")
      ->value(module::get_var("gallery", "resize_size"));
    $group->textarea("header_text")->label(t("Header text"))->id("gHeaderText")
      ->value(module::get_var("gallery", "header_text"));
    $group->textarea("footer_text")->label(t("Footer text"))->id("gFooterText")
      ->value(module::get_var("gallery", "footer_text"));
    $group->checkbox("show_credits")->label(t("Show site credits"))->id("gFooterText")
      ->checked(module::get_var("gallery", "show_credits"));
    $group->submit("")->value(t("Save"));
    return $form;
  }

in gallery3/modules/gallery/controllers/admin_theme_options.php find:

      $thumb_size = $form->edit_theme->thumb_size->value;
      $thumb_dirty = false;
      if (module::get_var("gallery", "thumb_size") != $thumb_size) {
        graphics::remove_rule("gallery", "thumb", "resize");
        graphics::add_rule(
          "gallery", "thumb", "resize",
          array("width" => $thumb_size, "height" => $thumb_size, "master" => Image::AUTO),
          100);
        module::set_var("gallery", "thumb_size", $thumb_size);
      }

Change to:

      $thumb_size = $form->edit_theme->thumb_size->value;
      $thumb_dirty = false;
      $thumb_squares = $form->edit_theme->thumb_squares->value;
      $toolkit = module::get_var("gallery", "graphics_toolkit");
      if (module::get_var("gallery", "thumb_size") != $thumb_size OR
          module::get_var("gallery", "thumb_squares") != $thumb_squares) {
        graphics::remove_rule("gallery", "thumb", "resize");
	if($thumb_squares AND $toolkit == "imagemagick" ){
		graphics::add_rule(
        	  "gallery", "thumb", "resize",
      		  array("width" => $thumb_size, "height" => $thumb_size, "master" => Image::SQUARE),
		  100);
	}else{
		graphics::add_rule(
        	  "gallery", "thumb", "resize",
      		  array("width" => $thumb_size, "height" => $thumb_size, "master" => Image::AUTO),
		  100);
	}
	module::set_var("gallery", "thumb_squares", $thumb_squares);
        module::set_var("gallery", "thumb_size", $thumb_size);
      }

You'll then need to go into your DB admin (phpmyadmin or whatever) since I don't know how to do this in code yet. In g3_vars, insert a new row. Id=64, module_name=gallery, name=thumb_squares, value=0.

I really hope id 64 isn't used by something else somewhere....

This will add a checkbox to the theme options page for creating square thumbnails, and will only make square ones for ImageMagick (until the other toolkits are sorted anyway)

I guess I should look into using git and getting this in there. But, I have no idea how to integrate this only into a module right now so yeah.

jasonh,
I think it would be beneficial to all if you create a fork of G3 and then people can merge your changes without having to manually edit files.
Thanks for your contribution.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

Dave,

Yeah I've been meaning to get a fork on there, I just haven't gotten to it yet.

Serge,

That's interesting that it's not working for you. Did you manually create the variable in the DB?

I'll zip the files up and attach them soon.

Ok I've created a fork of g3 and have my changes integrated.

git://github.com/jasonhight/gallery3.git

Anything in the logs?

I'll update to the latest code and see if something got broken.

edit - grabbed the latest git today, unzipped the square thumbs package I made, rebuilt the thumbs, no issues. The default theme is all wonky, but that's not my doing Did you create the variable in the db? Not sure why it's not working for you...

You back yet?
I am really interested in this module. I am not someone that can really provide any assistance but find the module very useful for design purposes.

Keep up the great work!

@jasonh, are we current on the attached code?
is it working with current git?

Was this ever added to G3? I'm looking at using squared cropped thumbs on an install at the moment?

Benjamin Albert Smith - Photography
Pikitia - New Zealand Photography