quick.css and quick.js

Glooper

Joined: 2005-09-21
Posts: 225

Posted: Sun, 2009-07-12 22:04

Hi,

I'm currently developing a theme for gallery3 and was looking at changing some of the look when hovering over an album... including changing how the buttons appear. I noticed however that the css and js links are injected into the page for this functionality even though this is part of the standard theme (I assume the Gallery core module is injecting it). I can of course change the class on the gallery item itself.. but I won't be able to stop the quick.css or quick.js from being injected. Would it be possible to have these two files as part of the default theme rather that from a required module that way theme developers can override this functionality and potentially remove the unnecessary css and js references?

Cheers
Ben

http://www.gloopics.com Benjamin Albert Smith - Photography

bharat

Joined: 2002-05-21
Posts: 7994

Posted: Mon, 2009-07-13 02:15

Would you please file a feature request for this? It's a tough tradeoff between how much burden we place on the theme to show core features (moving, resizing, deleting, etc) vs. what we do in the modules. If we do it in the theme, then *all* themes need to do it. If we do it in the modules, then all themes have it forced upon them. :-/ This is something we need to sort out.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git | help! vote!

Glooper

Joined: 2005-09-21
Posts: 225

Posted: Mon, 2009-07-13 09:33

Cheers,

Created Ticket #539. I can see it's hard to determine what a theme developer can change or not. Though, I think all other things in the main two required modules (users and gallery core) are all editable in the theme. Though I've not finished developing my theme yet so I could be wrong! .

Ben

http://www.gloopics.com Benjamin Albert Smith - Photography

nivekiam

Joined: 2002-12-10
Posts: 16504

Posted: Mon, 2009-07-13 19:31

Could it be setup so if a theme has a "quick.css" or a "quick.js" file that those override the main ones or does that add a lot of complexity?
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

bharat

Joined: 2002-05-21
Posts: 7994

Posted: Mon, 2009-07-13 19:48

Yes, I think we can do that.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git | help! vote!

Glooper Joined: 2005-09-21 Posts: 225	Posted: Sun, 2009-07-12 22:04
	Hi, I'm currently developing a theme for gallery3 and was looking at changing some of the look when hovering over an album... including changing how the buttons appear. I noticed however that the css and js links are injected into the page for this functionality even though this is part of the standard theme (I assume the Gallery core module is injecting it). I can of course change the class on the gallery item itself.. but I won't be able to stop the quick.css or quick.js from being injected. Would it be possible to have these two files as part of the default theme rather that from a required module that way theme developers can override this functionality and potentially remove the unnecessary css and js references? Cheers Ben http://www.gloopics.com Benjamin Albert Smith - Photography
	XUser login Username: * Password: * Create new account Request new password
bharat Joined: 2002-05-21 Posts: 7994	Posted: Mon, 2009-07-13 02:15
	Would you please file a feature request for this? It's a tough tradeoff between how much burden we place on the theme to show core features (moving, resizing, deleting, etc) vs. what we do in the modules. If we do it in the theme, then all themes need to do it. If we do it in the modules, then all themes have it forced upon them. :-/ This is something we need to sort out. --- Problems? Check gallery3/var/logs bugs/feature req's \| upgrade to the latest code \| use git \| help! vote!

Glooper Joined: 2005-09-21 Posts: 225	Posted: Mon, 2009-07-13 09:33
	Cheers, Created Ticket #539. I can see it's hard to determine what a theme developer can change or not. Though, I think all other things in the main two required modules (users and gallery core) are all editable in the theme. Though I've not finished developing my theme yet so I could be wrong! . Ben http://www.gloopics.com Benjamin Albert Smith - Photography

nivekiam Joined: 2002-12-10 Posts: 16504	Posted: Mon, 2009-07-13 19:31
	Could it be setup so if a theme has a "quick.css" or a "quick.js" file that those override the main ones or does that add a lot of complexity? ____________________________________________ Like Gallery? Like the support? Donate now!!! See G2 live here

bharat Joined: 2002-05-21 Posts: 7994	Posted: Mon, 2009-07-13 19:48
	Yes, I think we can do that. --- Problems? Check gallery3/var/logs bugs/feature req's \| upgrade to the latest code \| use git \| help! vote!

quick.css and quick.js

XUser login