strftime() problem in edit_caption.php

Drrrl

Joined: 2003-02-02
Posts: 23
Posted: Sat, 2008-09-13 17:51

The following information is required to get an answer:
Get this information from the PHP diagnostic (in the configuration wizard).
Gallery version: 1.5.8 and 1.5.9-svn-b24
Apache version: 2.2.9-r1
PHP version (don't just say PHP 4, please): 5.2.6-pl6
Graphics Toolkit: imagemagick-6.4.0.6, jhead-2.82-r1
Operating system: Linux (Gentoo)
Web browser/version (if applicable): Firefox 3

After I upgraded 1.5.7 to 1.5.8, I noticed the problem of strange strftime() errors. Since I read that 1.5.8 is buggy, I decided to upgrade to 1.5.9-svn-b24, but this did not help.

Problem description: when I try to edit photo caption ("Edit Text" from album view), pop-up windows opens, Caption and Keywords forms are OK, but beneath there were several errors (these messages are generated by 1.5.9-svn-b24 version).

Warning: strftime() expects parameter 2 to be long, array given in /home/vhosts/galeriakrolika/htdocs/gallery-legacy/edit_caption.php on line 147

Warning: strftime() expects parameter 2 to be long, array given in /home/vhosts/galeriakrolika/htdocs/gallery-legacy/edit_caption.php on line 148

Warning: strftime() expects parameter 2 to be long, array given in /home/vhosts/galeriakrolika/htdocs/gallery-legacy/edit_caption.php on line 149

Warning: strftime() expects parameter 2 to be long, array given in /home/vhosts/galeriakrolika/htdocs/gallery-legacy/edit_caption.php on line 150

Warning: strftime() expects parameter 2 to be long, array given in /home/vhosts/galeriakrolika/htdocs/gallery-legacy/edit_caption.php on line 151

Warning: strftime() expects parameter 2 to be long, array given in /home/vhosts/galeriakrolika/htdocs/gallery-legacy/edit_caption.php on line 152

Below is "Photo Capture Date" form and it contains following data:
Month: 1
Day: 1
Year: <empty>
Hours: 0
Minutes: 0
Seconds: 0

I got similar issue, when I try to edit all captions together, using "Edit captions" option in album's menu:

Warning: strftime() expects parameter 2 to be long, array given in /home/vhosts/galeriakrolika/htdocs/gallery-legacy/captionator.php on line 317

Interesting thing is that such problem appears only for recently added (after upgrading 1.5.7 to 1.5.8) photos, and not for all of them. All photos we exported from Lightroom with full metadata, and they have (or at least I believe they have) correct EXIF data - "Date/Time" field in "Photo properties" windows shows correct value.

Any idea? Thanks in advance,

Grzegorz

 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Sat, 2008-09-13 18:03

Hello,

i have a couple reports of this issue, but so far i have problems to reproduce it and then fix it.
But we will release 1.5.9 next week and till then i will fix it ;-)

In the meanwhile i suggest not to upload new pictures.
To fix the actually problem, just press save in that dialog and the capture date is written again in the correct format.

Thanks for reminding me,

Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6

 
Drrrl

Joined: 2003-02-02
Posts: 23
Posted: Sat, 2008-09-13 19:30

Saving again has helped. Thanks!

And thanks for maintaining v1 :)

 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Sun, 2008-09-14 18:12

I am not able to reproduce it :-(

Are you able in your installation?

Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6

 
Drrrl

Joined: 2003-02-02
Posts: 23
Posted: Sun, 2008-09-14 21:24

Nope.

I just added two different photos into two different albums. Photos came from two different cameras, but were exported in the same way as previous ones, and when I edit captions, date shows correctly, and no error messages appear. The only difference is, that previously I added photos in 1.5.8 Gallery version, and now it's 1.5.9-svn-b24. Is it possible that this behaviour has been corrected meanwhile?

In my initial post I wrote that error appear both in 1.5.8 and in 1.5.9-svn-b24, and it was true - but I just realized that despite of Gallery version I used to edit caption, in both cases problem was related to a photo added in 1.5.8. So maybe 1.5.9 is free of this problem? If yes, apologies for wrong diagnosis.

Grzegorz

 
Drrrl

Joined: 2003-02-02
Posts: 23
Posted: Sun, 2008-09-14 21:42

Ooops...

I was two fast. As I wrote previously, I've added two photos (let's call them A and B, both .jpg files). One of them (A) was added to a newly created album, and the second one (B), to the album, where I previously (in 1.5.8) added other photos (let's call them C, D and E), but which I did not correct by chosing "Edit caption -> Save".

As soon as I added both photos, I entered full view for each one, and checked what is shown in "Edit caption" window. In both cases the result was good, So I wrote the post above.

Then I noticed, that there are still photos C, D and E, for which "Edit captions" shows error messaged. So, as you wrote, I repeated the procedure "Edit caption -> Save -> Edit caption -> Cancel" again to correct data and check if error messaged disappear. Everything worked as expected - no more error messages. But then I went to photo B -> Edit caption, just to be absolutely sure everything's fine. And what? Error messages! Sounds crazy, isn't it? I've choosed "Save" again for photo B and error messages are gone, as well as for photos C, D and E. I checked also photo A, in different album - no errors.

I cannot replicate a problem now, as I have no other album with photos showing errors. I added yet another photo (F) to the album containing photos B, C, D and E, but no errors appeared, neither for photo F nor any other.

Grzegorz

 
Drrrl

Joined: 2003-02-02
Posts: 23
Posted: Sun, 2008-09-14 21:52

Yet another interesting test :)

I checked photo A once again. It shows no erros, neither with "Edit caption" at photo level (edit_caption.php), nor with "Edit captions" at album level (captionator.php).

Then I moved this photo from it's original album to album containing photos B, C, D and E. And you know what? Errors appear for both .php scripts, and only for photo A. Amazing, isn't it?

I stop doing anything with this album and the photos now.

Grzegorz

 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Mon, 2008-09-15 23:20

I am still not able to reproduce :-(

We will release 1.5.9 tomorrow. :-|

Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6

 
Drrrl

Joined: 2003-02-02
Posts: 23
Posted: Tue, 2008-09-16 07:09

Did you try to add photos to existing album in 1.5.8?

My experiments show that something is wrong with the album, where photos were added while Gallery was 1.5.8. For a new album, created in pre-1.5.9, everything's fine. Maybe something wrong has happened with photos.dat file?

Grzegorz

 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Tue, 2008-09-16 09:41

No, i have not. Why should i?

Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6

 
Drrrl

Joined: 2003-02-02
Posts: 23
Posted: Tue, 2008-09-16 09:50

Because maybe althought the problem i.e. strftime() error messages appear in 1.5.8 and 1.5.9, but the reason is some album/photo data corruption that happened only when photos were added in 1.5.8 and that's why you cannot replicate a problem? It's just a theory...

G.

 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Tue, 2008-09-16 10:21

But the problem seems to be fixed in 1.5.9 .. ;-)

Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6

 
Drrrl

Joined: 2003-02-02
Posts: 23
Posted: Tue, 2008-09-16 11:04

I hope so ;-)

But I have just downloaded and installed 1.5.9-svn-b30 and the problem still exist... :(

Grzegorz

 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Tue, 2008-09-16 12:05

The version will not fix existing broken caption dates.
It will just not create new.

Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6

 
Drrrl

Joined: 2003-02-02
Posts: 23
Posted: Wed, 2008-09-17 18:59

Understood :)

OK, I'll wait for final 1.5.9 and will try to reproduce the situation.

*Update* -> I have installed 1.5.9, corrected photos with corrupted capture date, and after several operation like moving photos between albums I am not able to reproduce the problem. So it seems, that a problem has gone :)

Thanks for help!

Grzegorz

 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Wed, 2008-09-17 21:38

Thanks for the feedback and your help!

Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6