Problem with frame sizes and Main Highlight Image
zman
Joined: 2003-07-24
Posts: 196 |
Posted: Mon, 2008-04-21 00:45 |
Hello! I just now upgraded a version 1.3.4 Gallery to version 1.5. I only went to version 1.5 because I think 1.5.7 may not work well with my custom header/footer wrapper but could be wrong on that... will look into that later I have things fairly well setup except for two things so far that I'm aware of... 1) Highlight images don't work for the main page but work for everything else. 2) I couldn't seem to get frames to work correctly. No matter what I selected in the configuration wizard or in the "properties" for each album, the frames stayed the same. I want "shadows" for this so kind of did a work around and just copied the _BB _BL _BR etc files for the shadows over the images in the images folder. That gave me my shadows (but still don't know why I can't select them using the options?) but now my main problem is that in the individual picture view the frame (shadow) is not complete. I've tried rebuilding the thumbs and that doesn't work. I've even tried uploading a new image to see if it might have just been something to do with the upgrade process but that doesn't work either. I setup a temporary "test" album that is the older version so I could see where it might be getting broken. The main difference I notice is that in the older version that works, in the <!-- image grid table --> section I have the following when I do a view source of both pages after they are rendered: <!-- image grid table --> <br> <table width=100% border=0 cellspacing=0 cellpadding=7> <tr><td></td><td></td></tr><tr><td width=50% align=center valign=middle><table width="1" height="1" border="0" cellspacing="0" cellpadding="0"> <tr> <td bgcolor="black" rowspan="2" colspan="2" width="1" height="1"><table cellspacing="0" cellpadding="1"> <tr> <td width="250" height="167"><a href="http://www.brentfranker.com/www/1terry/gallery/view_photo.php?set_albumName=album85&id=106_0407"> Here is what it looks like in version 1.5 that doesn't work: <!-- image grid table --> <table border="0" cellspacing="5" cellpadding="0" width="100%" class="vatable" align="center"> <tr><td align="center" valign="top" class="vathumbs"> <div style="padding-top: 42px; padding-bottom:42px; width: 254px; height: 170px;" align="center" class="vafloat2"> <table width="1" height="1" border="0" cellspacing="0" cellpadding="0"> <tr> <td bgcolor="black" rowspan="2" colspan="2" width="1" height="1"><table cellspacing="0" cellpadding="1"> <tr> <td width="" height=""><a href="http://www.frankerenterprises.com/gallery/album85/106_0407"> Main difference being that in the 1.5 version that doesn't work, the td width and height are showing as "" I did some looking but can't quite figure it out. Here is an example of the one that works... and here is the one that doesn't... For the other issue with the highlight you can see here that it isn't working. I have verified that one is selected and even tried changing the hightlight but that didn't work either. Here is how the above should look... It seems the main issue is that Gallery is not getting the size of the thumbs. That would explain both problems. If upgrading to version 1.5.7 will fix the problem, I'm not opposed to doing that so long as I don't "break" the custom wrapper stuff I have designed. Thanks much! And also thanks much for still keeping up with version 1. Version 1 Gallery to me seems much easier to work with and customize to my needs and since I already have it and it works well, I'm not in a rush to move up to Gallery 2 and try to make it look like what I have now so I thank you, Jens, for keeping up with Gallery 1! |
|
Posts: 6818
Hello Zman,
i am not very eager to support Gallery 1.5
If you did a brief comparison between 1.5 and 1.5.7 that shows that 1.5.7 really breaks things, i will fix them in 1.5.8
I just did a quick glance at your 1.5 installs. And what i first saw is bad HTML.
You use <html> and <body> twice and mixing HTML with XHTML syntax.
Beside using 1.5.7 to get (my) full support, i suggest fixing those things before is a must.
Greeting and thanks for the warm words,
Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6
Posts: 196
Thanks for the reply, Jens!
Yeah, I know about my HTML. Been like that for YEARS. LOL! I threw something together a while back realizing it wasn't exactly correct but it worked so I didn't mess with it. I know that's not the ideal thing to do and will try to fix it but I don't think that is what was causing the problems.
I'll try to fix that and upgrade one of my other unmodified Gallery installations to 1.5.7 to see what happens. It was a while ago that I was looking at the code and thinking it would require major modifications to keep the site looking the same but I think I might have been looking at version 1.6? Either way, I'll give 1.5.7 a try. Thanks!!!
Posts: 6818
Well, the HTML in 1.3.4 is valid ...
Yes, 1.6 Layout and Skinning is 100% incompatible to any 1.x before.
I guess you saw that.
That why there is/well be a 1.5.x line and the 1.6+
Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6
Posts: 196
Excellent, Jens!
And, I didn't mean to imply that 1.3.4 wasn't HTML valid if that is what you thought. *I* screwed up the HTML with the wrapper that I added so the HTML not being good was my own doing
You are right that I got the 1.5.7 and 1.6 versions crossed in my head. I will definitely give 1.5.7 a shot. Thanks again for the great product!
Posts: 6818
You're welcome.
Don't hesitate to ask again when you have 1.5.7 (or 1.5.8-svn) running.
Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6
Posts: 196
Hey Jens!
Ok... finally got around to installing 1.5.7 and I have the same problems plus a couple more now
Main page highlight images are not showing...
http://www.frankerenterprises.com/gallery/albums.php
Album frames work correctly...
http://www.frankerenterprises.com/gallery/entertainment
However, frames around pictures are still only 1/2 height and the bottom doesn't "fill"...
http://www.frankerenterprises.com/gallery/album76
And in this example the page has a combination of albums and pictures... album frames are still OK but picture frames are not...
http://www.frankerenterprises.com/gallery/mantels
And then the other issue that I see now with 1.5.7 that I didn't see with previous versions is when a picture is rotated the text under it goes up into the image. Example here where the two pictures on the right that are rotated have the text in the frame area...
http://www.frankerenterprises.com/gallery/other
Any ideas there, Jens??? I did nothing else except just copy over 1.5.7 over the old version. No core files have been modified. I know my HTML coding in the wrapper files is junk but that had never been an issue before. Do you think that could all of a sudden be causing the problems with the frames and text running up into the frames?
Thanks much!!!
Posts: 6818
Hello,
first thing i noticed, is that you use bad HTML in your Gallery.
Means you have double <html> and double <body> thats not good. Thats can confuse browsers.
The text under the pictures does not really go up. Technically spoken its exactly at the same position.
The space between the frame and the text below is to small. You can add a margin to fix this.
Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6
Posts: 196
Hey Jens!
Ok... as a test I have removed all the custom HTML wrap that had the bad code yet the same problem still exists?
http://www.frankerenterprises.com/gallery/album85?page=1
To my knowledge, the gallery is now completely "stock" with no mods with the exception of what I have done to the css.
Do you happen to see anything else that might be causing the problem with the frames? Thanks!
Posts: 196
Ok... since I realized above I said I still had some modified css in there, I decide to take that out too. Same problem with the frames...
http://www.frankerenterprises.com/gallery/album85?page=1
Since I just installed Gallery 1.5.7 and have modified ZERO files and have removed all HTML wrap and CSS that I have done, the gallery should be like a base gallery. I just updated another gallery I have to 1.5.7 and this problem does NOT exist on that gallery so not sure what the problem could be.
Thanks!
Posts: 196
Hey Jens, something else that is a bit odd... I changed all the frames to "polaroid" for everything in an album (and applied to all albums) but the only one that shows the correct frame is when viewing the picture itself. When I go back into the "properties" it does show "polaroid" for all three frames (album frame, thumb frame, item frame) but the album and thumb frames still appear to be the "original" style frame.
Album frame is set to Polaroid here...
http://www.frankerenterprises.com/gallery/entertainment
Thumb frame is set to Polaroid here...
http://www.frankerenterprises.com/gallery/album85
Item fram is set to Polaroid here (and works)...
http://www.frankerenterprises.com/gallery/album85/106_0407
Weird. LOL
Posts: 196
(Ugh. I have no idea why the below isn't wrapping. Sorry, don't know how to "fix" it)
And one more little bit of troubleshooting that I don't fully understand but I'm sure you do
I have the one gallery 1.5.7 installation that works just fine and then the one that I'm having problems with with the frames and initial highlight images on the main page. So... I find it helpful to compare the HTML "view source" code.
The album that works looks like this for the "image grid table" section...
And here is the same section of code for the gallery install that I can't get working. It is missing most all the code???!!!
I set both pages to use the "polaroid" frames. Weird again!
Sorry for being a pain with all the posts. Just trying to provide as much info as I can
Posts: 196
Ok... making progress
Somehow (maybe I did it... likely ) I had removed the ".default" extension from several of the files in the html_wrap folder. I believe I remember doing this in order to add a custom shadow that I was using BEFORE shadows became an option in Gallery a very long time ago. Evidently, when I upgraded to the new version, something changed slightly in the code that made the these old wrapper files not compatible with the new version wrapper files. Still need to figure a couple things out (shadows still not working but most other frames are???) but got most of this figured out now
Hopefully all my rambling here might help somebody else. LOL
Posts: 196
All worked out, even the shadows
I'm not exactly sure why but the png shadow files don't show. I took a frames folder that I had in another gallery and copied it to this gallery I've been having trouble with and now the shadows work (gif shadows as opposed to png shadows).
In my searching of trying to figure out what was wrong all along I found where some were having the same problem but I never found a solution. If anybody is having problems with frames or the highlights displaying on the main page, check to see if you are using any custom frame wrapper files from a previous version. If you are, first try putting a different extension on your modified files (like .old) which will force Gallery to use the .default file that came with the new version. If that fixes your problem then just put your mods in the new version file. Not exactly sure what changed (didn't look into it) but the problem seemed to be with the new version not liking something that did work in an older version.
Thanks much again for the great program and keeping Gallery 1 around!
FYI, here is info on the gif style shadows...
http://gallery.menalto.com/node/22136
Posts: 12
I appreciate zman's persistence. I upgraded one of my Gallery 1 sites this morning and there's a problem with album and thumb frames. I upgraded from version 1.5.3 to 1.5.7 using the documented shell access method, as I've done many times. Now Thumb Frames do not display shadows, as previously set in Album Properties. Other thumb frame styles seem to work, however.
Album Frames also do not display shadows. And in Safari on Mac and PC for album frames there are tiny white outlined boxes at three outside corners of the thumbs.
Only default files in the html_wrap folder. So, I am puzzled what changed.
(By the way, my Gallery 2.2.4 site is okay with shadow thumb frames.)
Posts: 196
I found the problem to be completely related to the older files. Are you sure you didn't change anything in the older wrapper files and left the default extension? I know I have done that before... whoops
EDIT: I suppose if you left the .default extension then the older files would have been overwritten. DOH! LOL
Did you try the .gif shadows I mentioned in the above link? I couldn't get the other shadows to work so just used the .gif shadows and it worked fine after that.
Posts: 12
On reading closely the ChangeLog for version 1.5.7:
2006-09-04 Jens Tkotz <jens@peino.de> 1.5.5-svn-b4
* Fix: Shadow frame files were corrupted ?!?
(and noting zman's comments also), I renamed the /html_wrap/frames/shadows folder in place after the 1.5.7 upgrade, and then copied over the same folder from another gallery 1.5.3 site. The date on that other shadows folder was April 9, 2006 7:15 PM and all 7 files in it were dated November 22, 2003 11:33 AM.
And indeed, shadows are once again working in my upgraded Gallery 1.5.7 site - without any artifacts around the thumbnail images.
Posts: 12
The shadows folder (frame files) still appear to be corrupt in Gallery 1.5.10, in the latest gallery-1.5.10.tar.gz release. I upgraded one of my Gallery 1.5.7 sites this morning to version 1.5.10 and frame shadows disappeared, as noted in my July 2008 post. I replaced the folder with a backup, and things were okay again.
I confirmed that all the png files -- except for the pixel_trans.png -- in the shadows folder with the gallery-1.5.10.tar.gz release could not be opened.
Posts: 6818
Hi,
thanks for the info, i will correct that soon.
Jens
--
Gallery Developer