Checkout 0.3.3 now in repository

Alec,
This still appears to be a problem in 0.3.2. I have a 20% discount for 4 or more items. After adding 5 items, then setting the item number to 0 for all but one of them, the final remaining item still has a 20 % discount.

Maybe modify the code to always include a "1" when the item is added. Then if a 0 is added, call the "remove" function automatically?

Just got a question regarding the checkoutpdfinvoice module. It displays the quotations used for the 6" x 8" as 6" x 8"... Please see the file attached, I would like it to display it as the actual quotation instead of its code version of that symbol.

Hi Pigwet,

I don't recognise any of those commands ... pngtopnm etc ... not anything to do with Checkout, as far as I can tell. Just to be 100% sure - when you say you uploaded the CheckoutDownloadStatusPlugin.zip please confirm for me that what you *actually* did was download it to your desktop, unzip it locally, and ftp-upload the single contained file (checkoutDownloadStatusPlugin.inc) into the modules/checkoutdownload/classes directory to overwrite the existing file there?

Did you actually get as far as trying to download any files then? it sounds like not, in which case that file that you uploaded would not have been executed and the problem must lie elsewhere.

(By the way, a quick google for pngtopnm reveals it as part of netPBM - are you using PNG format files on your site? you might want to have a look at your image library settings and perhaps use ImageMagick if NetPBM is causing grief.)

I'll have another look at the discount/removed item thing later today.

Luke: I'll look at the pdf thing today too.

Hi Pigwet,

I'm sorry I still can't reproduce this behaviour. Can you post a screenshot of your discount table (in the Admin page) please. Also confirm that you're entering the digit zero in the quantity box for the first 4 items then going straight to the checkout page. Not that it should make any difference, but the first stage is for me to reproduce what you're seeing happen.

Thanks
______________

The Gallery Forum helps those who help themselves.

0.3.2 - 0.3.3 I haven't uploaded yet.

Do you create thumbnails at upload time? Adding a photo to your cart does indeed load a thumbnail, but it does it through the regular Gallery API which will create it at that time if it's not cached.

I'm also concerned to track down your problem with the discounts, but will wait to have a look at your discount table ...

______________

The Gallery Forum helps those who help themselves.

No, indeed, it all looks healthy. Products with zero quantity are deliberately left in the cart (with a blank quantity box) so they're easy to put back, as discussed previously in this thread - note that it's only an issue one way or the other with items set as dropdowns though) I realise that that isn't to *everyone's* taste, but it's the way I want it, so... Nevertheless, they're still not counted for discount purposes - only items with quantities postively greater than zero count towards that. I don't suppose you can arrange admin access to your install for me, so I can try to figure out what's going on, can you?

______________

The Gallery Forum helps those who help themselves.

Sure - but - aside from what you do when you have 1000's of photos, what did you do when you uploaded the 20 in the test installation? if you made the thumbnails at upload time then it's less likely that creating a thumbnail when you added the photo to the cart pulled the server over. If you didn't, then it's possible that a glitch (or maybe a faulty image - I don't know much about netPBM) was the problem, and the timing was coincidental in as much as it was adding it to the cart that required the thumbnail to be built for the first time.

This is the same error I was getting earlier - and I never did get it to work.

Upgraded to 0.3.3. beta version

When in:

Site Admin
Checkout Orders
Select an order by 'ID'
'Download PDF format invoice' option button

the following:

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /var/www/html/gallery2/modules/checkoutpdfinvoice/PDFOut.inc on line 126

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /var/www/html/gallery2/modules/checkoutpdfinvoice/PDFOut.inc on line 178

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/gallery2/modules/checkoutpdfinvoice/PDFOut.inc:126) in /var/www/html/gallery2/modules/checkoutpdfinvoice/lib/fpdf/fpdf.php on line 1022
FPDF error: Some data has already been output to browser, can't send PDF file

Paul

Ok alecmyer, now download problem seems ok in versione 0.3.3 beta.
I've tested the download function from ADMIN into order detail.

But into the email (in status CONFIRMED) that customer receive, there isnt' the button
DOWNLOAD AS ZIP ....

In version 0.3.2 beta2 the button exit into the mail.

Another question. Why order number seems to be random?????

Thanks
Wiz

Yep that's sorted it

Paul

which problem resolve the attachment?

In this update there are two problem:

1) Now the DONWNLOAD AD ZIP button in mail show ... but, clicked, return the error page:
Security Violation
The action you attempted is not permitted.
Using ORDER STATUS, and then the button DOWNLOAD AS ZIP on the web page ... all is ok.

2) Price are rounded to the minor value integer (es. photo price 1,50 x qta 1 = 1,00)

Wiz

Here the error page

Security Violation
The action you attempted is not permitted.

Back to the Gallery

Error Detail -
Error (ERROR_BAD_PARAMETER) : /web/htdocs/.../home/foto/modules/checkoutDownload/module.inc
in modules/core/classes/helpers/GalleryPluginHelper_simple.class at line 94 (gallerycoreapi::error)
in modules/core/classes/helpers/GalleryPluginHelper_simple.class at line 88 (gallerypluginhelper_simple::loadplugin)
in modules/core/classes/GalleryCoreApi.class at line 209 (gallerypluginhelper_simple::loadplugin)
in modules/core/classes/GalleryView.class at line 153 (gallerycoreapi::loadplugin)
in main.php at line 318 (galleryview::loadview)
in main.php at line 94
in main.php at line 83
System Information
Gallery version 2.2.2
PHP version 4.4.7 cgi
Webserver Apache/2.0
Database mysqlt 5.0.54-log
Toolkits ImageMagick, NetPBM
Operating system Linux webx29.ad.aruba.it 2.6.18-53.1.4.el5PAE #1 SMP Wed Feb 13 15:24:10 CET 2008 i686
Browser Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1) ; .NET CLR 1.1.4322; InfoPath.1; .NET CLR 2.0.50727)

You have two choices:

1) Add an extra field to the checkout/templates/SelectPhotos.tpl (copy the discount-code idea) and parse it in confirm.inc - throw an error (similar to the one if the postage is required and not set) which is displayed in SelectPhotos.tpl. That means the pin has to be entered before the final page checkout.

2) If the pin-code *has* to be entered on the final checkout page, you will have to do the work within each payment plugin: so, for instance, add an extra field to checkoutemail/templates/Details.tpl and parse the contents in Email.inc. To get checkoutpaypal to do the same thing, you will need to add a new field to checkoutpaypal/templates/PaymentButton.tpl to input the code, change the "action" for that form to a new (Gallery) Controller that will test the PIN then redirect to the original form's destination (i.e. Paypal) - although I'm not sure what will happen to the form contents (the order contents) in that case - you might need to insert a new Gallery View that repeats the form contents with a button/message that says something like "Your PIN is accepted - click here to complete your payment at Paypal".

Good luck!

I will loook into this for 0.3.3/4, but I can't guarantee anything. When you say it redirects to the root album, it should, I think, redirect to /main.php - I guess you could use .htaccess to rewrite this to your album of choice.

I think the return url disappears because it's not explicitly carried through every single link and form - will investigate.

Breadcrumbs: not supplied by Checkout at all, they're under the control of the theme, I think, so there's not much I can do about them.

[EDIT] I've made a couple of quick mods which means that the continue shopping from stage 2 (confirm) now returns you to the same item page, rather than the root album. Once you've gone to a payment plugin, that information is no longer available, though. The returnURL is carried around in the status variable, which is fragile (for instance if you refresh the page with f5 it gets wiped, which is not ideal). Better might be to put in the session data, but I'll have to think through the consequences of that.

Alec,

OK for "." over "," ....
but DOWNLOAD AS ZIP from email doesn't work.
I'll make a new test and update this post.

Yes ..... occurs a strange thing ... the button open WINZIP blank!!!
with the name of photo file + [1] ... but empty, without starting download.

And, in the confirmation mail, also creating folder local and CustomerDetails.tpl
file in my language, the label customer detail continue to show in english.
It's pherhaps linked to the CONFIRM.TPL that contain
these phisical path of the other template file?

{if $showCustomer}
{include file='modules/checkout/templates/email/CustomerDetails.tpl'}
{/if}
{if $showContents}
{include file='modules/checkout/templates/email/TransactionContents.tpl'}
{/if}

Wiz

I worked on the breadcrumb issue and came up with the following:

The breadcrumb links are handled by modules/core/templates/blocks/BreadCrumb.tpl and not by the theme directly. By modifying this file I was able to remove the breadcrumb altogether from any 'module' type page that does not have any parents. While this isn't ideal, it does remove the confusion for the user and allows me to have a setup where the root album can remain hidden. In case anyone is interested, here is what I changed:

BEFORE

  
{if ($theme.pageType == 'admin' || $theme.pageType == 'module')}
  <a href="{g->url arg1="view=core.ShowItem"
		   arg2="itemId=`$theme.item.id`"}" class="BreadCrumb-{counter name="BreadCrumb"}">
     {$theme.item.title|markup:strip|default:$theme.item.pathComponent}</a>
  {else}

AFTER

  {if ($theme.pageType == 'admin')} 
    <a href="{g->url arg1="view=core.ShowItem"
		 arg2="itemId=`$theme.item.id`"}" class="BreadCrumb-{counter name="BreadCrumb"}">
    {$theme.item.title|markup:strip|default:$theme.item.pathComponent}</a>
  {elseif ($theme.pageType == 'module')}
    {if $theme.item.parentId > 0}
      <a href="{g->url arg1="view=core.ShowItem"
		   arg2="itemId=`$theme.item.id`"}" class="BreadCrumb-{counter name="BreadCrumb"}">
      {$theme.item.title|markup:strip|default:$theme.item.pathComponent}</a>
    {else}
      {* don't display a link to the root album *}
      &nbsp;
    {/if}
  {else}

What might be more ideal is if there is a way to know that the module type is "checkout" and only hide the breadcrumb then. Do you know if there is a way to do that?

This exercise got me thinking about the returnURL issue too. Maybe I am thinking way too far outside the box here, but I am wondering if it is possible to assign a "parent" to the checkout view. If this is possible, it might be able to be used to solve both the breadcrumb problem and the returnUrl problem. I just don't have enough of an understanding of the G2 structure to know how or where to look for this.

Download BUTTON on email.

Confirmed: clicking the DWONLOAD button, don't start any DOWNLOAD bu open directly WINZIP.

Here the HTML code present in email:

Download autorizzato. Ora puoi prelevare il file da qui:
<br/>
<form action="http://www..../foto/main.php?g2_view=checkoutdownload.Download&amp;g2_transactionId=530&amp;g2_verify1=1209455387&amp;g2_verify2=3004854854816d31bd85cc1%2C77718480&amp;g2_navId=xd9d31a5a" method="post">
<button type="submit">Download file Zip</button>
</form>
<br/>
<br/>

Yes works perfectly from web page, also opened form STATUS ORDER
BUTTON, by a registered user.

Also in EMAIL doesn't work the button.

Wiz

Ok it's clear. I send you the complete web and email html of a new order.

For UTF-8 can make an example?

If in TPL there is someting like ...="Quantità" ... how can I encode
the "à" in UTF-8???

thanks and excuse me for this question ... but I want resolve tihis character
problem.

Just installed your betaa couple days ago, so far no unknown breaks.
One question though: The German translation does not work. Any way to fix this (seems a known issue, but that does not really help).
I would be happy to help with translations into German if required.

Alec,
Just installed 0.3.3_beta from the front page (watermarked images were downloaded instead of full resolution) and then the checkoutdownload_updated.zip from above and everything appears to work great.

All shopping cart discount errors are fixed! Excellent.

Daniel

I've just uploaded (am uplaoding) the latest modifications to the top of the thread - 0.3.3_beta2.

It has Italian translations (thanks to wiz69) and German, but for checkoutdownload only - if someone would like to step in with the other four modules in German that would be dandy. Also Spanish, French, Dutch, anyone? Japanese? Arabic? Hebrew? If you do translate please make sure to save in UTF-8 format and *fill in all the header fields*. If anyone has willing but wants help with the practicalities, pm me.

Unfortunately I don't have time to verify that all strings are correctly translated - if someone sends me a translation... that's what goes in the module. If anyone spots any errors or missing strings then don't tell me - just correct the PO file and pm it to me with your corrections.

There are significant difference in the way checkout handles the "continue shopping" destination - this should now return you to the image/page you were viewing when you entered checkout. (Please test and report.)

Also new is numeric format field for currency strings: yes, now you can bill people in scientific notation, or in hexadecimal. W00t.

(I forgot to add - I read that there are caching issues with the server and translations - such that adding new language files can take some hours to take effect. If you don't see the Italian appear straight away, that might be why. One workaround is to stop/start apache, if you are in a position to do so on your server.)