suggestions for 1.1

joel558
joel558's picture

Joined: 2003-04-10
Posts: 93
Posted: Mon, 2003-06-02 07:55

great job on 1.1 so far , I especially like the save/load thing :D .

one thing I've noticed, after opening a GalleryRemote gallery file, it would be nice if the thumbnails for the saved pictures were loaded, and I also noticed that it has the filesize as 0 for the pictures that were loaded.

not really important things that need immediate attention, but something for you to do when you get bored.
 
paour
paour's picture

Joined: 2002-08-14
Posts: 1479
Posted: Mon, 2003-06-02 08:03

Hehe, I noticed that last night... I added these features in a hurry because I was bitten by the problem myself.

One cause of instability is memory management: I tried to work with a 300-file upload, and had to save and quit several times because Java didn't properly free up memory after displaying previews. I have to try to fix that too.

Thanks for the encouragement!
 
joel558
joel558's picture

Joined: 2003-04-10
Posts: 93
Posted: Mon, 2003-06-16 01:05

hi,
I just downloaded the most recent version of gr from cvs, I like the updated look without the password box.

but... I think somewhere you have mentioned that you have the preferences dialog working, but when I try to access it, I get a nullpointer exception.

running using 'ant run', and when I click options/preferences or 'add gallery url' nothing happens, and looking in the command prompt window, I see this(swing parts removed):

Quote:
[java] java.lang.NullPointerException
[java] at java.io.Reader.<init>(Reader.java:61)
[java] at java.io.InputStreamReader.<init>(InputStreamReader.java:80)
[java] at java.util.Properties.load(Properties.java:189)
[java] at com.gallery.GalleryRemote.prefs.PreferencesDialog.loadPanes(PreferencesDialog.java:64)
[java] at com.gallery.GalleryRemote.prefs.PreferencesDialog.<init>(PreferencesDialog.java:54)
[java] at com.gallery.GalleryRemote.MainFrame.showPreferencesDialog(MainFrame.java:944)
[java] at com.gallery.GalleryRemote.MainFrame.showPreferencesDialog(MainFrame.java:939)
[java] at com.gallery.GalleryRemote.MainFrame.actionPerformed(MainFrame.java:885)
[java] at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1764)

joel
 
paour
paour's picture

Joined: 2002-08-14
Posts: 1479
Posted: Mon, 2003-06-16 01:27

Joel, I just made a couple changes, hoping to resolve the exception; can you try again? Funny that I can't reproduce this...
 
joel558
joel558's picture

Joined: 2003-04-10
Posts: 93
Posted: Mon, 2003-06-16 06:44

doesn't seem to have done it, still getting exact same error.

I'll see if I can do some debugging and see if I can spot something
 
joel558
joel558's picture

Joined: 2003-04-10
Posts: 93
Posted: Mon, 2003-06-16 08:32

update:
attempting to run with 'ant run' still gets the error, however, after adding the jsx file to the classpath in the run.bat file, and running with the run.bat file, the preferences dialog works fine.

any ideas?
 
paour
paour's picture

Joined: 2002-08-14
Posts: 1479
Posted: Mon, 2003-06-16 11:14

OK, I fixed it. You need to update build.xml and PreferencesDialog.java.

This is what comes from building with IntelliJ most of the time...

Btw, do you get all the icons, and does rotating thumbnails work? I now need to rotate the actual image before upload...
 
joel558
joel558's picture

Joined: 2003-04-10
Posts: 93
Posted: Mon, 2003-06-16 20:21

did you update these in cvs or ?

it doesn't appear those files have been changed yet. build.xml is 12 days old