[Tags] New Module for Gallery 2.2
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Tue, 2007-03-20 20:12
|
|||
|
Hello All Fellow gallery users !! I have been working for some time on a good Tags module responding to a need of improving the current keywords management that was not as scalable and so here it is finally for you all to test out !! Please keep in mind these few things: - I made it for Gallery 2.2 *may work in 2.1 but I have not tested it at all* If you want to see what it looks like before installing: Screenshots on my site. Current features: What DOES NOT work yet Feel free to comment or let me know if you have any questions/requests See you all !
|
||||
|
floridave
Joined: 2003-12-22
Posts: 27300 |
Posted: Wed, 2007-03-21 03:39
|
|||
|
Looks great. Quote:
error: [1111: Invalid use of group function] in EXECUTE(" SELECT g2_Tags.g_TagValue, count(g2_TagsMap.g_itemId) FROM g2_Tags LEFT OUTER JOIN g2_TagsMap ON g2_Tags.g_TagId = g2_TagsMap.g_TagId GROUP BY g2_Tags.g_TagValue ORDER BY count(g2_TagsMap.g_itemId) DESC, g2_Tags.g_TagValue ASC ") (mysqlt): SELECT g2_Tags.g_TagValue, count(g2_TagsMap.g_itemId) FROM g2_Tags LEFT OUTER JOIN g2_TagsMap ON g2_Tags.g_TagId = g2_TagsMap.g_TagId GROUP BY g2_Tags.g_TagValue ORDER BY count(g2_TagsMap.g_itemId) DESC, g2_Tags.g_TagValue ASC 1111: Invalid use of group function Perhaps a mysql version issue? Dave _____________________________________________ |
||||
|
floridave
Joined: 2003-12-22
Posts: 27300 |
Posted: Wed, 2007-03-21 03:46
|
|||
|
I am able to go to the tag settings admin page and save results. |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Wed, 2007-03-21 05:17
|
|||
|
Hello Dave, After a little searching on the web it seems that you are right. this I found a bug report for the same issue and implemented this as a fix in there, please try the enclosed file and let me know so I can simply release a new version For the curious, the bug report Thanks ! |
||||
|
h0bbel
Joined: 2002-07-28
Posts: 13451 |
Posted: Wed, 2007-03-21 09:53
|
|||
|
Get this into DP now!! Also, integration with the keywords module would be useful. I have a lot of images "tagged" with Keywords, and if I add your tags to the images it shows up double ( http://h0bbel.p0ggel.org/gallery2/main.php?g2_view=tags.VirtualAlbum&g2_TagName=Fredrik ). I would love to be able to import the keywords as tags to be able to unify this. h0bbel - Gallery Team If you found my help useful, please consider donating to Gallery http://h0bbel.p0ggel.org |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Wed, 2007-03-21 13:12
|
|||
|
h0bbel wrote:
Get this into DP now!! Lol ! and how ? Quote:
Also, integration with the keywords module would be useful. I have a lot of images "tagged" with Keywords, and if I add your tags to the images it shows up double ( http://h0bbel.p0ggel.org/gallery2/main.php?g2_view=tags.VirtualAlbum&g2_TagName=Fredrik ). I would love to be able to import the keywords as tags to be able to unify this. I thought the keywords module was not meant to scale up and that's why there was a request to make it so. This is the original reason I started this PS: which version of mysql are you using ? did you try the new TagsHelper.class ? See you ! |
||||
|
h0bbel
Joined: 2002-07-28
Posts: 13451 |
Posted: Wed, 2007-03-21 19:06
|
|||
|
Termite: Talk to mindless. I'm on MySQL 5.0.32, and I didn't test the new class. h0bbel - Gallery Team If you found my help useful, please consider donating to Gallery http://h0bbel. |
||||
|
floridave
Joined: 2003-12-22
Posts: 27300 |
Posted: Wed, 2007-03-21 21:45
|
|||
|
Termite: Much better with the new class. I was able to get both admin sections and I was able to add a few tags. Quote:
SummaryShow for tags plugin mysqlt error: [1064: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'SELECT g2_TagsMap.g_itemId FROM g2_T] in EXECUTE(" SELECT g2_Tags.g_TagValue, (SELECT g2_TagsMap.g_itemId FROM g2_TagsMap WHERE g2_TagsMap.g_TagId = g2_Tags.g_TagId AND g2_TagsMap.g_itemId = 768 ) FROM g2_Tags ORDER BY g2_Tags.g_TagValue ASC ") (mysqlt): SELECT g2_Tags.g_TagValue, (SELECT g2_TagsMap.g_itemId FROM g2_TagsMap WHERE g2_TagsMap.g_TagId = g2_Tags.g_TagId AND g2_TagsMap.g_itemId = 768 ) FROM g2_Tags ORDER BY g2_Tags.g_TagValue ASC 1064: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'SELECT g2_TagsMap.g_itemId FROM g2_T I am able to navigate back the the site admin page (not able to browse any items) and deactivated the module. I was then able to browse the albums again. This looks promising. Sorry for the old SQL version. Dave _____________________________________________ |
||||
|
mindless
Joined: 2004-01-04
Posts: 8601 |
Posted: Thu, 2007-03-22 22:35
|
|||
|
Termite.. I fully agree with h0bbel. Looks like you're already setup to use gallery-contrib. Just commit your module into gallery2/modules/tags then cd ../.. and do perl $pathToRealG2/lib/tools/bin/makeManifest.pl -p modules/tags |
||||
|
valiant
Joined: 2003-01-04
Posts: 32509 |
Posted: Thu, 2007-03-22 22:43
|
|||
|
some suggestions: - i'd add a tag.add permission such that you can give visitors / users the ability to add tags without giving them the permission to mess with the item itself. - it looks like this kind of UI doesn't work if there are 100, 1000 or 10000 tags. maybe there should be a list of the 20 most popular tags + an auto-completion box (use YUI! use auto-complete) - @tag-cloud: are you using the same HTML / approach as we do for the keyword cloud of g2.2's keyalbum module? i spent some time improving it for g2.2. looking forward to seeing this in DP. -------------- |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-03-23 02:38
|
|||
|
mindless wrote:
Termite.. I fully agree with h0bbel. Looks like you're already setup to use gallery-contrib. Just commit your module into gallery2/modules/tags then cd ../.. and do perl $pathToRealG2/lib/tools/bin/makeManifest.pl -p modules/tags Oki I'll work on this in the week-end (I need to set it up on my linux box) |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-03-23 02:47
|
|||
|
Hello Valiant, valiant wrote:
some suggestions: I was thinking about that, but if you don't have edit rights, would you still be able to get to that page at all (since it's an edit plugin) ? valiant wrote:
- a "add tag" item action link or even a AJAX based add-tag UI below thumbnails would be cool. I'll think about this ... it could be indeed very nice valiant wrote:
- it looks like this kind of UI doesn't work if there are 100, 1000 or 10000 tags. This UI is gone (old screenshot), the new UI is like you said 1 part wher you add/remove tags to this item, 1 part where you see the most popular tags (all or limited - to be chosen in the admin panel), see this and this valiant wrote:
- @tag-cloud: are you using the same HTML / approach as we do for the keyword cloud of g2.2's keyalbum module? i spent some time improving it for g2.2. Yes, I did not want to reinvent the wheel and it sure looked nice as it was so I used it valiant wrote:
looking forward to seeing this in DP. I'll write it to SVN now, but I'll have to create the manifest Saturday. See you ! |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-03-23 02:50
|
|||
|
floridave wrote:
Termite: Much better with the new class. I was able to get both admin sections and I was able to add a few tags. I didn't forget about you, I'm thinking of a simple way to solve this and I think I have an idea ------------------------- |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-03-23 02:58
|
|||
|
btw Dave, Did you try to de-activate the summaries in the tags module to see if you were able to navigate to the albums/items ? Let me know |
||||
|
floridave
Joined: 2003-12-22
Posts: 27300 |
Posted: Fri, 2007-03-23 04:48
|
|||
|
Now that you mention it. Yes. Sending you URL and login info for my test site. Dave |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-03-23 05:29
|
|||
|
So I think I got it. Can you try this new revision of TagHelper.class ? Thanks!! |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-03-23 05:48
|
|||
|
Valiant, Mindless, I tried creating the MANIFEST with windows and I got this: C:\Website\www\Gallery22>C:\Website\perl\bin\perl.exe c:\Website\www\Gallery22\l ib\tools\bin\makeManifest.pl -p modules/tags Can't locate String/CRC32.pm in @INC (@INC contains: C:/Website/perl/lib C:/Webs ite/perl/site/lib .) at c:\Website\www\Gallery22\lib\tools\bin\makeManifest.pl l ine 10. BEGIN failed--compilation aborted at c:\Website\www\Gallery22\lib\tools\bin\make Manifest.pl line 10. Am I doing something wrong ? I'll try again with linux Tomorrow or Saturday (like I originally planned |
||||
|
mindless
Joined: 2004-01-04
Posts: 8601 |
Posted: Fri, 2007-03-23 06:44
|
|||
|
nice, got it into gallery-contrib very quickly see http://codex.gallery2.org/Gallery:Using_Subversion for some info on svn settings to get the right svn properties on the files (in future, I fixed all the files you added). your command above is correct, but String::CRC32 perl module is required. I added an initial MANIFEST for you, but you'll want to get that working so you can push DP releases yourself... thanks Termite!! |
||||
|
floridave
Joined: 2003-12-22
Posts: 27300 |
Posted: Fri, 2007-03-23 13:36
|
|||
|
Termite, That works! This is going to be cool! Dave _____________________________________________ |
||||
|
valiant
Joined: 2003-01-04
Posts: 32509 |
Posted: Fri, 2007-03-23 15:31
|
|||
|
Termite, @perl String::CRC32 Termitenshort wrote:
Hello Valiant, nope, you can't access the item admin pages without edit rights. Quote:
cool. that should indeed work pretty nicely! does the keyalbum module offer anything this module doesn't offer? -------------- |
||||
|
xJediXx
Joined: 2007-02-01
Posts: 53 |
Posted: Fri, 2007-03-23 16:16
|
|||
|
As a new user it's great to see continuous development. Thanks to all. Keep up the good work! |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-03-23 17:58
|
|||
|
mindless wrote:
nice, got it into gallery-contrib very quickly Thanks mindless Thanks ! |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-03-23 19:22
|
|||
|
floridave wrote:
Termite, That works! Sweet !! I also think the new queries are even faster than before floridave wrote:
One small issue (only in debug mode) view my test site and you will see a 2 notices: Alright I saw these, I'll check why this is happening. Thanks again ! |
||||
|
valiant
Joined: 2003-01-04
Posts: 32509 |
Posted: Fri, 2007-03-23 18:42
|
|||
|
Termite, > I guess using windows for my dev work isn't the best I'm using Windows for development as well. -------------- |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-03-23 23:25
|
|||
|
valiant wrote:
Termite, Thanks for that, i should be able to get CRC32 thing and create MANIFESTs valiant wrote:
nope, you can't access the item admin pages without edit rights. Ok I'm sure I can get that done, I have done the same for the ajax cart I made (btw it works great now valiant wrote:
does the keyalbum module offer anything this module doesn't offer? - I did see the cloud being a block so it could be put everywhere I'll check the keywordalbum module for the rest ------------------------- |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Tue, 2007-03-27 20:08
|
|||
|
UPDATE: - I have setup my linux box to create the MANIFEST Changes - next release: Few more tests and I'll upload v 1.1.0 with these new features See you all ! |
||||
|
floridave
Joined: 2003-12-22
Posts: 27300 |
Posted: Tue, 2007-03-27 20:20
|
|||
|
Thanks for the great work, Dave |
||||
|
floridave
Joined: 2003-12-22
Posts: 27300 |
Posted: Wed, 2007-03-28 02:31
|
|||
|
I have created a skeleton codex page: Dave |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Wed, 2007-03-28 04:03
|
|||
|
floridave wrote:
I have created a skeleton codex page: Thanks a million ------------------------- |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Wed, 2007-03-28 05:37
|
|||
|
1.0.2 should be in SVN, Can you guys verify: 1. That it works Hopefully I'm now all set and I should be putting 1.1.0 before sunday ends See you ! |
||||
|
bgraabek
Joined: 2003-11-20
Posts: 19 |
Posted: Wed, 2007-03-28 19:52
|
|||
|
I have installed the Tags Module v1.01 in my installation and it works! One issue though: The module doesn't take permissions into account? I have 1 public album, the rest can only be viewed when logged in. Clicking on the "tag cloud" icon underneath the public album when NOT logged in I get the tag cloud. Clicking on any of the tags I get a virtual album with pictures that should only be viewable when logged in. |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Wed, 2007-03-28 21:22
|
|||
|
bgraabek wrote:
One issue though: The module doesn't take permissions into account? I have 1 public album, the rest can only be viewed when logged in. Clicking on the "tag cloud" icon underneath the public album when NOT logged in I get the tag cloud. Clicking on any of the tags I get a virtual album with pictures that should only be viewable when logged in. Interesting, I;'ll take a look at that ------------------------- |
||||
|
floridave
Joined: 2003-12-22
Posts: 27300 |
Posted: Thu, 2007-03-29 04:37
|
|||
|
Quote:
1.0.2 should be in SVN, Yes it works so the rest must be right upgraded via DP: I think the cron job to update the DP list is only once a day. Some UI suggestions to follow in a day or two. Dave |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Thu, 2007-03-29 14:24
|
|||
|
bgraabek wrote:
One issue though: The module doesn't take permissions into account? Yes the module does not take rights into account, fishy .... I fixed it and will be releasing the new version tomorrow or today time permitting See you ! |
||||
|
bgraabek
Joined: 2003-11-20
Posts: 19 |
Posted: Sat, 2007-03-31 17:22
|
|||
|
I tried upgrading the Tags module today. I clicked on "get more plugins" which showed that there was a newer module (1.1.1 vs the 1.0.2 I already had installed). When upgrading the module, the orange bar went from left to right, but nothing happened after that. I was however able to go to other parts of Gallery that all work fine. If I now go to the "plugins" module with the list of installed plugins, the tag module is listed with the "upgrade required" icon. I click on the "upgrade" action, the line goes green and seemingly nothing happens. If I tail the error log at the same time, the following line shows up every time I click upgrade. PHP Fatal error: Undefined class name 'tagshelper' in /path/to/gallery2/modules/tags/module.inc on line 182, referer: http://photo.graabek.com/admin/?g2_subView=core.AdminPlugins It should be noted that I'm running in multisite mode, so TagsHelper.class which I'm guessing is needed is located at a different URL |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Sat, 2007-03-31 17:37
|
|||
|
Hello, There is an error in the module.inc file that I just corrected, if you are using SVN, you can download it immediately, if not you'll have to wait for the cron job to run and 1.1.2 to show up Thanks! |
||||
|
baseball2487
Joined: 2007-02-08
Posts: 13 |
Posted: Mon, 2007-04-02 01:26
|
|||
|
One thing that I noticed with the module is that the search block doesn't seem to search through the tags - it does find keywords though. Is there a how to somewhere that I missed that possibly discusses how to do this? If not please consider this for a potential improvement. Thanks |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Mon, 2007-04-02 04:07
|
|||
|
baseball2487 wrote:
One thing that I noticed with the module is that the search block doesn't seem to search through the tags - it does find keywords though. Is there a how to somewhere that I missed that possibly discusses how to do this? If not please consider this for a potential improvement. I will make it happen also in the next version. Sorry about that ------------------------- |
||||
|
baseball2487
Joined: 2007-02-08
Posts: 13 |
Posted: Mon, 2007-04-02 06:18
|
|||
|
No worries, I appreciate all of the work you're doing on this! |
||||
|
h0bbel
Joined: 2002-07-28
Posts: 13451 |
Posted: Wed, 2007-04-04 21:54
|
|||
|
BUG REPORT!!! ;-) Quote:
"Fatal error: Call to undefined method TagsHelper::removealltags() in /path/gallery2/modules/tags/classes/TagsHelper.class on line 306" Seems that deleting comments on items with tags isn't such a good idea? ;-) Edit: Ok, so Valiant was to blame. Fixed. h0bbel - Gallery Team If you found my help useful, please consider donating to Gallery http://h0bbel.p0ggel.org |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Wed, 2007-04-04 22:03
|
|||
|
Hello What does this mean ? You deleted comments on a item with Tags and this error showed up ? Let me know ! |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Wed, 2007-04-04 22:05
|
|||
|
h0bbel wrote:
Ok, so Valiant was to blame. Fixed. I was too slow |
||||
|
h0bbel
Joined: 2002-07-28
Posts: 13451 |
Posted: Wed, 2007-04-04 22:12
|
|||
|
Yep, and Valiant too quick. What a coincidence h0bbel - Gallery Team If you found my help useful, please consider donating to Gallery http://h0bbel.p0ggel.org |
||||
|
nzwhost
Joined: 2005-10-29
Posts: 61 |
Posted: Thu, 2007-04-05 09:39
|
|||
|
Termitenshort wrote:
UPDATE: I have also been struggling with updating MANIFEST files over the past few days. I have a windows development environment. I managed to get it sorted out tonight using cygwin. If anyone is interested this is what I did to get the String::CRC32 perl module installed. 1. From the cygwin command prompt type in "cpan" - this should bring you to a "cpan>" command prompt. If this is the first time to run cpan you will need to configure your cpan environment. 2. Type "install String::CRC32" - this should install the module. This appeared to be sucessful for me but I still could not update MANIFEST files. On further investigation I found that the module had not actually been installed. So to find out why I went through the module installation manually. I unpacked the archive into my tmp directory and went through the installation manually: At the make stage I discovered that I didn't have gcc installed in cygwin. After installing gcc through the cygwin setup I was able to complete the install. I can now update MANIFEST files using cygwin. ------------------ |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Thu, 2007-04-05 16:03
|
|||
|
Thx for the tips. It still doesn't work for me under windows in fact I had String:CRC32 fully installed but it's relying on a DLL MSVRT80.DLL (Something like that) and each tim I try to create a manifest it generates an error of a missing pointer in that DLL ... I haven't tried cygwin coz I never got it installed and I could just ssh into my linux box. I'll take a look at cygwin this week-end |
||||
|
ASNet0007
Joined: 2006-10-17
Posts: 177 |
Posted: Fri, 2007-04-06 09:11
|
|||
|
I seem to be having a problem with the import from keywords, The process runs fine with out any errors, but no tags are shown under Tags management. I am using a windows 2003 build on an internal only system, so cant give you a link. I have found the following error in my php logs Quote:
C:\wamp\www\asimages\modules\tags\classes\KeywordsToTags.class on line 96 This repeats itself over and over in the logs. Would you like any other info? Tags - 1.2.0 Gallery version = 2.2.1 core 1.2.0.1 |
||||
|
baseball2487
Joined: 2007-02-08
Posts: 13 |
Posted: Fri, 2007-04-06 14:09
|
|||
|
I noticed a few bugs or other oddities that you might want to consider fixing in your next release. I'm using version 1.2.1 of the tags module. 1. The images for the tags module (especially in the edit screen) are relative to the current position \modules\tags\images\. - however if you use a multi-site install the tags\images folder can (usually is) in a different folder on the site and thus the images should be relative to the gallery source root A few things you might want to change if you get a chance Thanks for all your work on this, and I hope my observations and comments help. |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Fri, 2007-04-06 22:13
|
|||
|
ASNet0007 wrote:
I seem to be having a problem with the import from keywords, The process runs fine with out any errors, but no tags are shown under Tags management. I am using a windows 2003 build on an internal only system, so cant give you a link. I have found the following error in my php logs This is due to the fact that you never had the keyword album module installed or it's currently uninstalled, please upgrade to the newest version in SVN (1.2.1) and this problem should go away Thanks ! |
||||
|
Termitenshort
Joined: 2005-10-09
Posts: 1894 |
Posted: Sat, 2007-04-07 00:49
|
|||
|
baseball2487 wrote:
I noticed a few bugs or other oddities that you might want to consider fixing in your next release. I'm using version 1.2.1 of the tags module. Thanks for all you comments I'll process them on Sunday and try to fix as much as I can See you soon ! |
||||
|
ASNet0007
Joined: 2006-10-17
Posts: 177 |
Posted: Sun, 2007-04-08 11:21
|
|||
|
Thanks, that worked. One thing that would make this module really handy would be to add the tag entry into the edit captions page. So Were you have Title Summary Keywords Description and then tags. This would make editing multiple images easy, and I can add my keywords at the same time. Cheers |
||||
|
h0bbel
Joined: 2002-07-28
Posts: 13451 |
Posted: Sun, 2007-04-08 12:16
|
|||
|
An interface to mass edit/apply tags would be great, as well as a method of applying tags on all images in an album. I want to tag all my photos with the year they were taken, and if I could add '2005' as a tag to all images in an album that would be great. Then I could go back in and mass edit to add other specific tags for each photo. h0bbel - Gallery Team If you found my help useful, please consider donating to Gallery http://h0bbel.p0ggel.org |
||||
