[Email notification] multi page thread

floridave
floridave's picture

Joined: 2003-12-22
Posts: 27300
Posted: Thu, 2007-03-08 22:25

When one receives an email notification of a update to a thread they are in this form:

Quote:
New comment from: mindless
URL: http://gallery.menalto.com/node/54063#comment-224728
..........

Clicking the link takes you to the first page of a multi page thread. On single page threads it works fine. The behavior a week or 2 ago was, on multi page threads the link would go to the post regardless of the thread being multi page or not.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Fri, 2007-03-09 21:24

hm. the latest version of subscriptions.module has some long complicated code for figuring out the page number, so I figured it worked and removed my custom code. i'll take a look.

 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Fri, 2007-03-09 21:40

oof, the module doesn't even pass the right parameters to its own function.. fixing, thanks for the report!

 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Fri, 2007-03-09 22:21

Ok, should be fixed.. let me know if it doesn't work.

 
floridave
floridave's picture

Joined: 2003-12-22
Posts: 27300
Posted: Sat, 2007-03-10 17:50

Thanks for that mindless, just letting you know that it does not work still:

Quote:
Greetings, floridave. This is an automatic mail from Gallery.
** You are receiving this email because you signed up for it! **
TO UNSUBSCRIBE: browse to http://gallery.menalto.com/subscriptions

New comment from: gaynormcc
URL: http://gallery.menalto.com/node/33603#comment-225045

--

Glad you are keeping the Drupal guys on their toes. :-)

Dave

_____________________________________________
Blog & G2 || floridave - Gallery Team

 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Sat, 2007-03-10 20:28

oof, did that too fast.. one typo and one wrong param name. "should" be ok now :-)

 
floridave
floridave's picture

Joined: 2003-12-22
Posts: 27300
Posted: Sun, 2007-03-11 17:08

perhaps third time is the charm.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Mon, 2007-03-12 20:43

Let's hope so. The code after my 2nd fix does work, but gets it wrong on just the 51st post (exact post that starts the 2nd page), which that one above just happened to be... now fixed.