"Updated/New" for parent album when changes in subalbums?

I'm pretty sure I've seen code for this, but couldn't find it either.. just others asking the same:

http://gallery.menalto.com/node/41940
http://gallery.menalto.com/node/38008

I know this is an old post, but I didn't find any more recent related articles. I've started to make a hack at modifying newitems:module.inc, but I'm pretty much a class newbie. This is pretty clunky code, so I'll take all suggestions on streamlining, but first I'd like to get it working.

Here's what I have so far:

	$summaries = array();
	foreach ($items as $item) {
	    if ($param['days.new'] > 0 && $item->getCreationTimestamp() > $newTime) {
		$summaries[$item->getId()] = '<span class="giNew">'
		    . $newString . '</span>';
	    } else if ($param['days.updated'] > 0
			&& $item->getModificationTimestamp() > $updatedTime) {
		$summaries[$item->getId()] = '<span class="giUpdated">'
		    . $updatedString . '</span>';
	    } else {/* Recurse lower albums, only need albums, because the above got us that far */
			list ($ret, $childIds) = GalleryCoreApi::fetchDescendentAlbumItemIds($item);
			if ($ret) {
				return array($ret, null);
			}
			$sub_index=0;
			$max_index=count($childIds);
			/* Load the children */
		    list ($ret, $childAlbums) = GalleryCoreApi::loadEntitiesById($childIds);
		    if ($ret) {
			return array($ret, null);
		    }
			while ($sub_index < $max_index && $param['days.update'] > 0) {
				if ($childAlbums[$sub_index]->getModificationTimestamp() > $updatedTime) {
					$summaries[$item->getId()] = '<span class="giUpdated">'
					. $updatedString . '</span>';
					$sub_index=$max_index+1;
				}
				$sub_index++;
			}			
		
	    }
		
	}
	return array(null, $summaries);

Unfortunately, I'm getting a BAD PARAMETER error in GalleryCoreApi::loadEntitiesById. Any ideas?

Vital stats:

Gallery version = 2.2.1 core 1.2.0.1
PHP version = 4.4.4 cgi
Webserver = Apache/1.3.33 (Unix)
Database = mysqlt 4.0.27-standard-log, lock.system=flock
Toolkits = Exif, LinkItemToolkit, SquareThumb, NetPBM
Acceleration = partial/21600, none
Operating system = Linux infong 2.4 #1 SMP Thu Jan 13 08:59:31 CET 2005 i686 unknown
Default theme = matrix
gettext = enabled
Locale = en_US
Browser = Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Rows in GalleryAccessMap table = 27
Rows in GalleryAccessSubscriberMap table = 882
Rows in GalleryUser table = 13
Rows in GalleryItem table = 881
Rows in GalleryAlbumItem table = 54
Rows in GalleryCacheMap table = 155 

Thanks mindless. That was the cause of the error, for some reason I though that empty in would return empty out, but that is clearly not the case.

After some additional experimenting, here is the final code. This will add the "Updated" tag to any album which contains an item which is "Updated". It doesn't check for "New" items at the lower level, since the modification dates (what "Update" looks at) for parents are automatically changed when new items are created. I had originally planned to add a function for recursion into sub-sub-items, but the fetchDescendents seems to do this already. Note: this might be slow on very big/nested Galleries, but it didn't add any noticeable delay on my (relatively) small gallery.

I haven't investigated appropriate baselining and versioning in the Gallery codebase, so I just added a sub-version. This module will identify itself as version 1.0.5.1, since I updated the 1.0.5 version (included in Gallery 2.2.1 full). To reproduce for yourself, simply copy the below code into a new module.inc and overwrite the one in version 1.0.5 of "newitems".

Complete code of /newitems/module.inc with my changes in blue:

<?php
/*
 * Gallery - a web based photo album viewer and editor
 * Copyright (C) 2000-2007 Bharat Mediratta
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or (at
 * your option) any later version.
 *
 * This program is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA  02110-1301, USA.
 */

/**
 * Add new/updated image in summary info for new/updated items.
 * New sort option to put new items in front, follwed by another sort.
 * Thanks to Felix Rabinovich (virshu) for the idea.
 *
 * @package NewItems
 * @author Alan Harder <alan.harder@sun.com>
 * @version $Revision: 16034 $
 */
class NewItemsModule extends GalleryModule {

    function NewItemsModule() {
	global $gallery;

	$this->setId('newitems');
	$this->setName($gallery->i18n('New Items'));
	$this->setDescription($gallery->i18n('Highlight new/updated Gallery items'));
	$this->setVersion('1.0.5.1');
	$this->setGroup('display', $gallery->i18n('Display'));
	$this->setCallbacks('getSiteAdminViews|getItemSummaries');
	$this->setRequiredCoreApi(array(7, 10));
	$this->setRequiredModuleApi(array(3, 0));
    }

    /**
     * @see GalleryModule::upgrade
     */
    function upgrade($currentVersion) {
	if (!isset($currentVersion)) {
	    foreach (array('days.new' => '7',
			   'days.updated' => '7' )
		     as $key => $value) {
		$ret = $this->setParameter($key, $value);
		if ($ret) {
		    return $ret;
		}
	    }
	}

	return null;
    }

    /**
     * @see GalleryModule::performFactoryRegistrations
     */
    function performFactoryRegistrations() {
	$ret = GalleryCoreApi::registerFactoryImplementation(
	    'GallerySortInterface_1_2', 'NewItemsSortOrder', 'NewItems',
	    'modules/newitems/classes/NewItemsSortOrder.class', 'newitems', null);
	if ($ret) {
	    return $ret;
	}

	return null;
    }

    /**
     * @see GalleryModule::getSiteAdminViews
     */
    function getSiteAdminViews() {
	return array(null,
		     array(array('name' => $this->translate('New Items'),
				 'view' => 'newitems.NewItemsSiteAdmin')));
    }

    /**
     * @see GalleryModule::getItemSummaries
     */
    function getItemSummaries($items, $permissions, &$template) {
	list ($ret, $param) = GalleryCoreApi::fetchAllPluginParameters('module', 'newitems');
	if ($ret) {
	    return array($ret, null);
	}
	$time = time();
	$newTime = $time - $param['days.new'] * 86400;
	$updatedTime = $time - $param['days.updated'] * 86400;

	$newString = $this->translate('New');
	$updatedString = $this->translate('Updated');

	$summaries = array();
	foreach ($items as $item) {
	    if ($param['days.new'] > 0 && $item->getCreationTimestamp() > $newTime) {
		$summaries[$item->getId()] = '<span class="giNew">'
		    . $newString . '</span>';
	    } else if ($param['days.updated'] > 0
			&& $item->getModificationTimestamp() > $updatedTime) {
		$summaries[$item->getId()] = '<span class="giUpdated">'
		    . $updatedString . '</span>';
	    } else if ($param['days.updated'] > 0) {
			/* C. Schierer 24 April 2007: Look at child (lower) items for update status */
			list ($ret, $childIds) = GalleryCoreApi::fetchDescendentItemIds($item);
			if ($ret) {
				return array($ret, null);
			}
			$sub_index=0;
			$max_index=count($childIds);
			/* If there are any children, Load them */
			if ($max_index>0) {
				list ($ret, $childAlbums) = GalleryCoreApi::loadEntitiesById($childIds);
				if ($ret) {
				return array($ret, null);
				}
				/* Check each child's modification date */
				while ($sub_index<$max_index) {
					if ($childAlbums[$sub_index]->getModificationTimestamp() > $updatedTime) {
						$summaries[$item->getId()] = '<span class="giUpdated">'
							. $updatedString . '</span>';
						$sub_index=$max_index+1;
					} 
					$sub_index++;
				} /* while */
			} /* End C. Schierer mods */
		}			
	} 
		 
	return array(null, $summaries);
    }

	
    /**
     * @see GalleryModule::uninstall
     */
    function uninstall() {
	$ret = GalleryCoreApi::deleteSortOrder('NewItems');
	if ($ret) {
	    return $ret;
	}

	return parent::uninstall();
    }
	
}
?>

Thanks Lentil.
This works like a charm for me. (don't know much about coding. Just copied and pasted into my module.inc file)
Now my only remaining question :D :
Now that the "updated" part is replicated all the way to all parents, how can I make the "sort by last updated" recognize that this album was updated.

See my attachment. The a sub-album in the fourth album was updated, and it now shows the "updated" tag correctly till the parent, but the "sort by last updated" did not realize this. The third album should be demoted by the sort method, and the fourth promoted.

Any ideas how to make this possible?
Thanks in advance!
Jacauc
http://www.dieinter.net

Ah well, thought it might be worth asking.
Thanks anyways!

(I'm not a programmer, so I do not want to go and fool around there myself)

Thanks for this. Funny it's 2 years later and this still hasn't made it into the code base. I've changed classic theme to also show you in the subalbums tree if a subalbum has been updated (with an asterisk).

/gallery2/themes/classic
$ diff -u theme.inc.bak theme.inc 
--- theme.inc.bak       2008-12-29 16:24:40.038564000 -0800
+++ theme.inc   2008-12-29 16:36:09.253695000 -0800
 -247,6 +247,13 @@
        if ($ret) {
            return $ret;
        }
+       list ($ret, $param) = GalleryCoreApi::fetchAllPluginParameters('module', 'newitems');
+        if ($ret) {
+            return array($ret, null);
+        }
+        $time = time();
+        $updatedTime = $time - $param['days.updated'] * 86400;
+
        if (!empty($subAlbumIds)) {
            list ($ret, $subAlbums) =
                GalleryCoreApi::loadEntitiesById($subAlbumIds, 'GalleryAlbumItem');
 -257,6 +264,9 @@
                $id = $subAlbum->getId();
                $treeList[$branchId][] = array('id' => $id, 'depth' => $depth - 1);
                $treeItems[$id] = (array)$subAlbum;
+               if ($subAlbum->getModificationTimestamp() > $updatedTime) {
+                       $treeItems[$id]['updated'] = "1";
+               }
                if (!isset($maxDepth) || $depth < $maxDepth) {
                    $ret = $this->_doBuildTree($subAlbum, $branchId, $treeList, $treeItems,
                                               $maxDepth, $userId, $depth + 1);

/gallery2/themes/classic/templates/local
$ diff -u ../album.tpl album.tpl
--- ../album.tpl        2008-10-18 00:15:37.000000000 -0700
+++ album.tpl   2008-12-29 16:21:14.080153000 -0800
 -160,9 +160,15 @@
                      {/if}
                      {assign var="depth" value=$node.depth}
                      <li>
-                       <a href="{g->url arg1="view=core.ShowItem" arg2="itemId=`$node.id`"}">
-                       {$theme.treeItems[$node.id].title|default:$theme.treeItems[$node.id].pathComponent|markup}
-                       </a>
+                         {if !empty($theme.treeItems[$node.id].updated)}
+                                  <a href="{g->url arg1="view=core.ShowItem" arg2="itemId=`$node.id`"}">
+                                {$theme.treeItems[$node.id].title|default:$theme.treeItems[$node.id].pathComponent|markup}
+                                  </a><font color=#E66C2C>*</font>
+                         {else}
+                                  <a href="{g->url arg1="view=core.ShowItem" arg2="itemId=`$node.id`"}">
+                                {$theme.treeItems[$node.id].title|default:$theme.treeItems[$node.id].pathComponent|markup}
+                                  </a>
+                         {/if}
                      </li>
                    {/foreach}
                    {$empty|indent:$depth:"</ul></li>"}

The patch was written by a contributor more than two years ago for an old version of gallery which almost nobody is using any more so it's unlikely that anyone will be able to assist.

I wasn't aiming for tact. I do however know that it's disheartening to post a query and receive no reply whatsoever - not even an "I'm sorry but nobody can help with that." This applies especially for people new to Gallery (this was the first post by that person) who may not be aware that there isn't an army of developers waiting to leap on every problem nor know that the code he or she is trying to use has never been officially supported.

Hmm...I never realized I was using an old version of Gallery2. Should have come as no surprise, though, since I installed it over 2 years ago and never bothered to upgrade it.
I'll try upgrading first, and see if that makes any difference.

BTW: I believe the idea behind your mod is great - I've been searching for a recursive way to show which albums have been updated for quite some time.

alargule: What's strange is that $childIds is used as the argument to a function a few lines up. An empty $childIds causing issues is exactly why the $max_index check is there. I wonder what the $max_index value is. I suppose you could hack the code to return the $max_index number as the text for the album (instead of the "Updated" text) to do some troubleshooting.

Yeah, you're pretty much getting beyond me too. I suppose there's two ways to attack this:
A) Remove the derivatives from the $childIDs before the loadEntitiesbyID call
B) Handle the error gracefully and keep going.

I found this post where somebody else was dealing with the same error, although their circumstance might not be appropriate for us: http://gallery.menalto.com/node/77181

Searching for "does not extend the required entity type" results in quite a few hits in the forums, with resolutions that span from database errors to coding problems. I'm not clear on why you would have a "GalleryDerivativeImage" just sitting as a child of an album... isn't this the class for thumbnails?

Looking at the API for loadEntityByID I see that it takes an optional (soon to be mandatory) second argument. 'GalleryEntity' is the option to accept everything... perhaps this will help? I would test it, but then I can't make your problem happen. I suppose if I knew how to create a "GalleryDerivativeImage" in one of my albums...

Regardless, I made the following modifications to incorporate the second argument:
38 becomes: $this->setVersion('1.0.8.100');
121 becomes: list ($ret, $childAlbums) = GalleryCoreApi::loadEntitiesById($childIds,'GalleryEntity');

This produced the same behavior as before (for me). I also thought to replace GalleryCoreApi::fetchDescendentItemIds($item) with GalleryCoreApi::fetchDescendentAlbumItemIds($item) to avoid loading any objects but albums (since that will be sufficient recursion to get the update info). This might 'evade' the Derivatives.

38 becomes: $this->setVersion('1.0.8.101');
Line 113 becomes: list ($ret, $childIds) = GalleryCoreApi::fetchDescendentAlbumItemIds($item);

I'm now running both changes (1.0.8.101) and it behaves the same as before for me. Maybe you'll have some improvement?

Okay, it's been a while since I've posted here.
The above modification has been working great so far.
However, I've found out that it will display all updates that have been made to photo items or album items. E.g. when I change the the name of a map, or even the template, the map and all its parents will be tagged as 'updated'.
I would like the 'update' tag to only show when new album or photo items have been added to a parent album. Is there any way that I could do that? I've tried:

...but that doesn't really seem to do the trick.

Edit: never mind, problem solved!