Installation Bug, incorrect Album directory

unclecrispy

Joined: 2004-08-03
Posts: 12
Posted: Tue, 2006-02-28 23:57

during installation, on the 'Locations and URLs' tab
the 'Album directory' field is improperly pre-populated with what a path based on the getenv("DOCUMENT_ROOT") command

because this function does not guarantee a true full path, beginner users on systems with symbolic links and/or hidden directories can become frustrated with an installation that doesn't work.

note that the 'Thumbnail image' field, slightly further down on the same tab, is correctly populated using the GALLERY_BASE constant instead of getenv("DOCUMENT_ROOT") to determine the path

so my proposed bug fix: on line 320 of /setup/config_data.inc, replace getenv("DOCUMENT_ROOT") with GALLERY_BASE that will also make the installation use a more standardized procedure ;) (note that this is the one and only place where DOCUMENT_ROOT is used)

thanks!

The following information is required to get an answer:
Get this information from the PHP diagnostic (in the configuration wizard).
Gallery URL (optional but very useful):
Gallery version: 1.5.2-pl2 (but since 1.X)
Apache version: 1.3.33
PHP version: 4.3.10
Graphics Toolkit: (not applicable)
Operating system: Debian
Web browser/version: (not applicable)

 
ckdake
ckdake's picture

Joined: 2004-02-18
Posts: 2258
Posted: Fri, 2006-03-03 01:20

Sounds like a bug! Please file this on sf.net/projects/gallery and someone (probably Jens..) will eventually get to fixint it. Also feel free to submit a patch against Gallery CVS to the bug and I can probably check it in if it looks reasonable. Thanks!

--
http://ckdake.com/

If you found my help useful, please consider donating to Gallery.