[Map Module] Troube if Empty Albums linked to map

Continental

Joined: 2004-06-14
Posts: 243
Posted: Wed, 2006-02-22 08:30

Happy news, that 0.4.10 reseased, but before upgrade I'd like to ask smth'ing:

On my 0.4.9c I noticed yesterday a strage error. When I create a new albums, attach it to map, and if this ambum still has NO photos inside I see error:

Fatal error: Call to a member function on a non-object in /home/.oly/kostik/travelcamera.ru/content/modules/map/ShowMap.inc on line 536

That's affect all Google Map and when I try to load it, I see this message.

A question: is this fixed in 0.4.10?


Gallery version (not just "2"): 2.0.01
Module / Theme name & version: 0.4.9c
 
Termitenshort
Termitenshort's picture

Joined: 2005-10-09
Posts: 1894
Posted: Wed, 2006-02-22 13:37

No it isn't :-)

This is due to the fact that the module verify if there is children and i't sprobably linked to the Automatic regroup of album. I'll look at it. please post a bug :-)

Thanks
-------------------------
The Termite :-)
 
Termitenshort
Termitenshort's picture

Joined: 2005-10-09
Posts: 1894
Posted: Wed, 2006-02-22 20:58

Actually this problem is very simple .... when you have a marker on the map, there is a thumbnail. if the album is empty it most like does not have a thumnail :-) -> hence the failing error code. I'll had some code to prevent that

If you specify a thumbnail (manually or from another pic), it'll work fine.

Thanks for the report ;)
-------------------------
The Termite :-)
 
Continental

Joined: 2004-06-14
Posts: 243
Posted: Thu, 2006-02-23 09:52

bug report here

please, post a patch as it's ready (for 0.4.10). I can't live without it. =(
 
Termitenshort
Termitenshort's picture

Joined: 2005-10-09
Posts: 1894
Posted: Thu, 2006-02-23 14:51

Just one question. When the album has no thumbnail, would you like to have a default picture showing or just nothing ?

I can do that fairly quickly tonight for you ;)
-------------------------
The Termite :-)
 
Continental

Joined: 2004-06-14
Posts: 243
Posted: Thu, 2006-02-23 15:51

The better solution will be show marker with default picture. because currently user:
1. add album
2. add emply album on the map
3. check where it is (very often it is somewhere not in place)
4. add pictures.

so, it should be possibility to check this emply albums and to distinguish at least its NAME.

Have a good the end of the week, weekend and don't rush. btw, today is holiday in Russia. Nobody working. -) So, not so many visitors on my site. I can wait until Monday or smth.. At least I will not hide map because of this fault function. If you could combine this bug patch with new albums link it wold be better... thx you very much.