Ratings Module Question
|
lvthunder
Joined: 2003-09-12
Posts: 808 |
Posted: Wed, 2006-02-15 00:28
|
|
Why is there css for the ratings module in the rating.css file and the matrix theme.css file? Why can't all the css for this go in the ratings module so all the theme authors don't have to add the css in their theme.css files for the module to center the bar under the stars? Other than that I think this module is a great addition to G2. |
|
Posts: 32509
because G2 is modular. just think the all in one idea through for users that don't have all modules active, users that add 3rd party modules, different versions of different modules etc.
Posts: 808
Valiant I think your making my point. Why is there stuff in the matrix theme.css file while we already have a rating.css file. I had to add code into my theme.css file just to get the bar to center under the stars.
I think having to add css for countless modules is going to become a nightmare for theme developers. I can see people saying how come module X doesn't work with theme Y.
Posts: 32509
ah, i forgot the fact that we added some overriding capabilities to theme.css for the rating module.
i'm +1 for not having any rating css in theme.css. they should be kept separate. but there must have been a good reason to add it in theme.css, which i forgot. i'll ask rizzo, the rating module author.