Gallery CVS (20030219) test

kvdb

Joined: 2002-10-10
Posts: 29
Posted: Wed, 2003-02-19 22:09

Hi,

I can't discover any bugs using the test harness. That's good news!

But there are some things I noticed while using the most recent Gallery:

The user management module says:
There is 3 user in the system.
instead of
There are 3 users in the system.

Same thing applies to the group module.

---

While browsing to the gallery I see:

This album contains 22 item

this should be

This album contains 22 items

---

While adding users to a group. I have to type the name of the user myself.
It would be nice to see a list of all available users so I can pick one.

---

in item permissions, change the 'Go' button to 'Remove Permission'.

---

Gallery won't let me add [core] all access to a group when the same group already has other [core] xxx permissions.
Gallery should just let me add that or be so smart to know that [core] all access implies [core] xxx and remove [core] xxx after adding [core] all access

---

item permissions: it would be nice to be able to select user names and groups from a listbox instead of typing them. Or is this something that is up to the theme to decide?

---

There's not much left to say except... G2 rocks! :cool:

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7994
Posted: Sat, 2003-02-22 06:59
Quote:
I can't discover any bugs using the test harness. That's good news!

Quote:

Hooray! I finally did a big checkin without breaking something :smile:

Quote:
The user management module says:
There is 3 user in the system.
instead of
There are 3 users in the system.

Is your PHP configured to use gettext? Check your phpinfo() and let
me know. If you don't have gettext, then pluralization will be broken
and you won't have any translations.

Quote:
While adding users to a group. I have to type the name of the user myself.
It would be nice to see a list of all available users so I can pick one.

I've been avoiding listing all the users because that won't scale to
environments where you have many thousands of users (like this website
which has > 10K users registered). We do need to have something
better than an open-ended text box, though.

Quote:
in item permissions, change the 'Go' button to 'Remove Permission'.

Fixed.

Quote:
Gallery won't let me add [core] all access to a group when the same group already has other [core] xxx permissions.
Gallery should just let me add that or be so smart to know that [core] all access implies [core] xxx and remove [core] xxx after adding [core] all access

This has been fixed with my latest checkin (just minutes ago).

Thanks for the sanity check, kvdb!
 
baschny
baschny's picture

Joined: 2003-01-04
Posts: 328
Posted: Sun, 2003-02-23 21:42
Quote:
The user management module says:
There is 3 user in the system.
instead of
There are 3 users in the system.

Quote:
This album contains 22 item
this should be
This album contains 22 items

If you are using a PHP version smaller than 4.2.0, which is when the pluralization of gettext was added. No fix possible for that other than upgrading PHP. :sad: