SWF handling module
|
mebigrock
Joined: 2005-11-30
Posts: 3 |
Posted: Wed, 2005-11-30 19:51
|
|||
|
After much searching of the forums and fiddling about with any options I can find, I've given up on waiting for someone else to do the work and I've written a little (very little) module that discovers the size (height and width) of an swf when you upload it. That is all it does at the moment, though in the future I'm planning on adding some advanced features for handling SWFs. This means that you no longer have to go into the edit animation screen and manually enter (sometimes guess) the size of the animation. I thought I would share it with you as I've noticed a couple of other people on the forum struggling with the same problem. This is my first attempt at writing a module for gallery, so please give me plenty of feedback on it and if anyone has some ideas for where to go with this in the future I would be happy to listen. --
|
||||
Posts: 32509
thanks, great!
- your .zip file contains a lot of dev files. but the toolkit looks good.
- so you're using the GD function getimagesize.
IMO, we should extend the GD module to also discover the swf dimensions in the GD module, all GD operations should be part of the GD module.
for now, let's use your module for swf, but sooner or later, we'll merge this functionality into the GD module. should be a small change.
Posts: 32509
i've added your module on http://codex.gallery2.org/index.php/Gallery2:User_Contributions#Modules
you can edit the page (you just need to register on codex.gallery2.org).
if you haven't already done so, please clean up the zip (don't include your dev environment) .
also please add a check if GD is present. see modules/gd/module.inc on how to check for the presence of GD and not allow activating /configuring the module if GD is not available.
Posts: 3
Thanks for your comments, much appreciated!
According to the php manual (http://uk2.php.net/manual/en/function.getimagesize.php), the getimagesize function doesn't need and isn't part of the GD library which is why I didn't put a check in for it. I believe that the function only requires any version of PHP 4 or above.
I think the dev files you are talking about are just the junk that OS X puts into its zip files, here's a version created using the command line that shouldn't have the same problem.
Posts: 32509
oh, i didn't realize that. perfect then. keeping it in a separate swf toolkit makes sense.
i guess it makes sense to have a highly specialized toolkit just for swf/animation items.
thanks for contributing!
Posts: 18
Works great !
Anybody knows how I can add a miniature image to an swf file ?
(doesn't have to be autogenerated).
Posts: 32509
you mean a thumbnail?
see:
http://codex.gallery2.org/index.php/Gallery2:Modules:thumbnail
Posts: 3
I've been looking for a way to autogenerate some sort of thumbnail from swfs but it doesn't seem to be possible, so I've been manually creating and uploading jpeg thumbnails for each one...
If anyone has any ideas on how to do this it would be very helpful. One thing that I thought of would be just to use the swf itself as a thumbnail - would that be possible, or do thumbnails have to be jpegs?
Posts: 1
Suddenly, on implementing this module, my guests have access to 'create link' for the animations. Any ideas on how I can turn this off?.
Thanks.
Posts: 132
Anyone planning on having this updated to 2.1?
Posts: 3
I have updated to 2.1.
More detail about the php function getimagesize() you can found at:
http://www.php.net/function.getimagesize
Posts: 132
Appear to work so far. Thank you!
Posts: 8601
all of our image toolkits try getimagesize before using their own functions, so i'll just add the application/x-shockwave-flash mime type to all three.
Posts: 2
This module is wonderful, however it would not resize to fit the maximum dimensions settings.
I have modified (a simple conditional line) /classes/SwfToolkit.class to limit the size. I currently have it set to limit the width to 400, but you can change the desired maximum width by changing the numbers on lines 65 and 67. Not the cleanest coding but it works.
I did not make a conditional statement for height as it is not necessary.
The reason I did this was because I am using Gallery2 bridged into Joomla! and my template would get screwed up if the image was too wide.
Nice work though!
EDIT: I didn't zip it so you'll have to get rid of the .txt when you upload to your server.
EDIT2:
I made a big error... it doesn't keep it relative. Replace the conditional with this:
Posts: 8601
FYI, there's a utility function in GalleryUtilities to resize dimensions.
Posts: 77
Would it be at all possible ot put in some sorta playback bar? Maybe even watermark the actual video?
Kinda like a youtube-esque setup?
Posts: 8339
Swf handling broken in latest build.
I just installed the latest 2.2svn on my friend's site.
When I upload a swf, it is treated like a file(edit file/delete file...) and produces a "Download file" link.
His version:
@g2 <class-name>GalleryAnimationItem</class-name>
@package GalleryCore
* @subpackage Classes
* @author Bharat Mediratta <bharat@menalto.com>
* @version $Revision: 14480 $ $Date: 2006-09-08 18:26:55 -0700 (Fri, 08 Sep 2006)
My version:
@version $Revision: 13634 $ $Date: 2006-05-10 15:44:00 -0500 (Wed, 10 May 2006) $
Everything works fine, it detects the size, displays the swf and treats it like an animation(edit animation/delete animation...).
Did we break something?
Can we fix it?
-s
Posts: 8601
there are only phpdoc changes in that file between those revisions.
G2 will switch to "file" if the dimensions detection fails on initial upload.. I guess something on that site makes that not work?
Posts: 8339
But shouldn't it stay an animation if thats what it is? And we enter the dimesions manually it getproperty fails.
His server is a freebsd machine. We had another site on it with a very early 2.2svn in which swfs displayed properly(I think with the help of the now defunct swf module which I tried last night - no help).
Any suggestion as to bypassing the switch to file on getproperty failure?
-s
Posts: 8601
i think the code is written on the assumption that the dimensions-detector works, so if it fails maybe it wasn't really a swf file; so stores it as "file".
you can modify rescan() in GalleryAnimationItem if you want to change this behavior (ignore toolkit error instead of adding ERROR_BAD_DATA_TYPE).