"see full poll results" link is not shown up

giorgos
giorgos's picture

Joined: 2002-08-19
Posts: 115
Posted: Thu, 2005-05-26 09:52

After successfully upgraded to 1.5 (almost 20000 images!!) I miss the link "see full poll results". The poll settings are YES to everybody but only admin and owner of the album can see this link.
Am I doing something wrong or missing something.

Thanks in advance
Giorgos
----
The following information is required to get an answer:
Get this information from the PHP diagnostic (in the configuration wizard).
Gallery URL http://www.dailyalbum.com/modules.php?op=modload&name=Gallery&file=index
Gallery version: 1.5
Apache version: 1.3.29
PHP version 4.3.4
Graphics Toolkit: NetPBM
Operating system: run as postnuke module
Web browser/version (if applicable):
 
giorgos
giorgos's picture

Joined: 2002-08-19
Posts: 115
Posted: Mon, 2005-06-06 13:28

It seems that according to a previous thread this was a bug that is already fixed in RC2-cvs-b26

Quote:
Only display poll results link to admin/owner, since other users get an error
fixed in RC2-cvs-b26

I dont think this is the case or is something wrong with my configuration.

On my gallery only admin/owner can see the link "see full poll results"

Is this actually fixed?

Thanks
Giorgos
 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Wed, 2005-06-08 21:47

Hello giorgos,

its exactly fixed like the Changelog says.

So its correct (in our view) that only owners and/or admin can see this link.

Regards,

Jens
 
giorgos
giorgos's picture

Joined: 2002-08-19
Posts: 115
Posted: Thu, 2005-06-09 04:47

Tim_j

Thanks for your response.
I do believe that if you specifically set up that all users or registered users can view votes (vote properties) then they can see also the full poll results page.
It looks like is not obeying the poll properties configuration.

Is there a reason of having this set it up that way?
Can I use a hack so that I can make this meet my needs?

Thanks,
Giorgos
 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Tue, 2005-07-12 12:14

Hello,

In our opinion a summarize of all votes is a statistical thing.
So this is mostly for admins.

As we have currenty no option for this, we have to respekt that not everybody want this. The result is that we curently only allow admins to see this summary.

But your idea is okay. Gallery 1.5.1 has much better GUI for album options. Unfortunately we are already in a Feature Freeze for 1.5.1.

I would like you to make a Feature Request for 1.5.2 on Sourceforge.
Once this is done it can be easily backported to 1.5 or 1.5.1

Regards,

Jens
 
giorgos
giorgos's picture

Joined: 2002-08-19
Posts: 115
Posted: Tue, 2005-07-12 20:52

Feature Request submitted.
http://sourceforge.net/tracker/index.php?func=detail&atid=357130&aid=1236970&group_id=7130

Regards
Giorgos
 
prog.zc

Joined: 2005-10-06
Posts: 1
Posted: Thu, 2005-10-06 04:00

Instead of waiting for it as a new feature. Desided to hack the code by myself and it was easy to get it work to allow "everybody" to "See full poll results". Below is how I get this done:

1) edit "poll_results.php" to comment out or delete the following lines to disable Admin or Owner checking
if (!testRequirement('isAdminOrAlbumOwner')) {
echo _("You are not allowed to perform this action!");
echo '<p><a href="'. makeAlbumUrl() .'">'. _("Back to Gallery") .'</a></p>';
exit;
}

2) edit "view_album.php" change "if ($results && testRequirement('isAdminOrAlbumOwner')) {" in the following lines of code to "if ($results) {" to show "See full poll results" link for everybody:

if ($gallery->album->getPollShowResults()) {
echo '<div align="left" class="vapoll">';
list($buf, $results)=showResultsGraph( $gallery->album->getPollNumResults());
print $buf;
if ($results && testRequirement('isAdminOrAlbumOwner')) {