more html blocks for GalleryEmbed

Alex Zubovsky wrote a few mails in the devel-mailinglist. We will continue the discussion here.

most parts of this post are just snippets from his mails.

Additional html blocks for GalleryEmbed: pathbarHtml and navigationbarHtml

addition to documentation: usage of GalleryEmbed::getSystemContent:

.........
 GalleryCapabilities::set("showSidebar", false);
 GalleryCapabilities::set("showSidebarGreeting",false);
 GalleryCapabilities::set("showPathbar", false);
 
    $g2data = GalleryEmbed::handleRequest();
    if ($g2data["isDone"]) {
      exit; // G2 has already sent output (redirect or binary data)
    }
 
 if($g2data["sidebarHtml"] != ""){
 	list($ret, $gallerySearchBox) = GalleryEmbed::getSystemContent("search",  
 "searchBox");
// handle $ret->isError() here
 	$galleryBox = $g2data["sidebarHtml"];
 }else{
 	$galleryBox = $g2data["navigationbarHtml"];
 }
 $galleryPath = $g2data["pathbarHtml"];

corresponding main.php changes:

 main.php modifications:
 
 .........
 	    if (isset($layout["show"]["sidebar"]) && $layout["show"]["sidebar"]  
 === false) {
 		/*
 		 * Render sidebar and return as separate block of content if
 		 * embedding app requested no sidebar in G2 content..
 		 */
 		$layout["show"]["sidebar"] = true;
 		list ($ret, $data["sidebarHtml"]) =
 		    $template->fetch("gallery:templates/sidebar.tpl");
 		if ($ret->isError()) {
 		    return array($ret->wrap(__FILE__, __LINE__), null);
 		}
 	    }
 	}else{
 		$layout["show"]["navigationbar"] = true;
 		list ($ret, $data["navigationbarHtml"]) =
 		     
 $template->fetch("gallery:modules/core/templates/NavigationSidebar.tpl");
 		if ($ret->isError()) {
 		    return array($ret->wrap(__FILE__, __LINE__), null);
 		}
 	}
 
 	$layout["show"]["pathbar"] = true;
 	list ($ret, $data["pathbarHtml"]) =
 	    $template->fetch("gallery:templates/pathbar.tpl");
 	if ($ret->isError()) {
 	    return array($ret->wrap(__FILE__, __LINE__), null);
 	}
 
 	return array(GalleryStatus::success(), $data);
      }
 
 
      return array(GalleryStatus::success(), array("isDone" => true));
 
 }

Have you a demo url where we can see the results? Seems to be a good addition.

mindless, could you fix his G2 coding style/mistakes and add the pathbarHtml and navigationbarHtml to main.php? Or can't we get the pathbarHtml and navigationbarHtml by something like a GalleryEmbed::getSystemContent call?

It's very unlikely that we will change it as you suggest. There are numerous reasons why it is as it is. There will be some changes to the layout system though, which will simplify a few things.

templates

Again, the current architecture is powerful. If you want to come up with an alternative / fundamental change, it doesn't suffice to describe it very vaguely. Think it through, show how everything still works with your proposed change.
We decided that G2 should handle the complete templating for G2 pages. You can change the layout, template, theme, and css to match your emApp. That should be sufficient.
What layout variables do you need exactly?

what does that mean?

different? how? demo link?

side bar embedding

no, parsing it wouldn't be reliable and a pain. parseHead is a dirty hack IMO. Perhaps one should identify the blocks of sideBar that you wish to get.
Why don't you edit the sidebar.tpl template?

ok.