[SOLVED] Cookie problems

Am I really the only one with this problem? I updated again with the latest CVS but the problem still exists.

bharat added some domain info encoded in the cookie a while back.. but i thought if your session was rejected due to that info it should generate a new cookie for you (i never tested that though).

i guess we can neglect the browser. tried it with IE, it works for me on my server.
sddroog, why do you use IE anyway?? firefox, opera, .... is the way to go.

but the problem persits for sddroog. anyone?

I just created a new website. Downloaded latest version from CVS. Created new database, everything from scratch.

I could login as admin only once. After logging out and trying to login again, it logged me in as guest.

There must be something different with my setup. I can't believe I am the only one having this problem.

here's one thing to try, not sure if it's the cause..
edit your modules/core/classes/GallerySession.class file, line 359.. comment out:
$this->_loadedSessionData = $localLoadedSessionData;
and try again.

I'm having the same problem with one of my G2 installations, but apparently a solution is already in the works. Please post a message when the bug is exterminated, and many thanks to the exterminator.

here's the situation I repro'd:
1) be logged in
2) logout
3) the very next page that is generated has sessionids in the urls
4) click login in the top navbar; returnUrl in this link has the sessionid
5) login.. you get a cookie with a new sessionid
6) you get redirected to the returnUrl, so the cookie changes back to
the old value and you aren't logged in anymore.

How 'bout this:

Index: GallerySession.class
===================================================================
RCS file: /cvsroot/gallery/gallery2/modules/core/classes/GallerySession.class,v
retrieving revision 1.61
diff -u -r1.61 GallerySession.class
--- GallerySession.class        19 Feb 2005 06:49:02 -0000      1.61
+++ GallerySession.class        23 Feb 2005 22:43:19 -0000
@@ -350,6 +350,7 @@
        /* Store the current session data */
         $localSessionData = $this->_sessionData;
         $localLoadedSessionData = $this->_loadedSessionData;
+        $oldId = $this->getSessionId();

        /* Reset the session data to create a new session id */
        $this->reset();
@@ -358,6 +359,16 @@
        $this->_sessionData = $localSessionData;
        $this->_loadedSessionData = $localLoadedSessionData;

+       /* If we have a return url we need to change session id */
+       if (GalleryUtilities::hasRequestVariable('return')) {
+           GalleryUtilities::putRequestVariable('return',
+                   str_replace(GalleryUtilities::prefixFormVariable($this->getKey()) . '=' .
+                                       $oldId,
+                               GalleryUtilities::prefixFormVariable($this->getKey()) . '=' .
+                                       $this->getSessionId(),
+                               GalleryUtilities::getRequestVariables('return')));
+       }
+
        return GalleryStatus::success();
     }

Edit: fixed linelength

Allright, I forgot about the session cache. This oughta do it:

Index: GallerySession.class
===================================================================
RCS file: /cvsroot/gallery/gallery2/modules/core/classes/GallerySession.class,v
retrieving revision 1.61
diff -u -r1.61 GallerySession.class
--- GallerySession.class        19 Feb 2005 06:49:02 -0000      1.61
+++ GallerySession.class        24 Feb 2005 01:50:36 -0000
@@ -350,6 +350,7 @@
        /* Store the current session data */
         $localSessionData = $this->_sessionData;
         $localLoadedSessionData = $this->_loadedSessionData;
+        $oldId = $this->getSessionId();

        /* Reset the session data to create a new session id */
        $this->reset();
@@ -358,10 +359,43 @@
        $this->_sessionData = $localSessionData;
        $this->_loadedSessionData = $localLoadedSessionData;

+       /* If we have a return url we need to change session id */
+       if (GalleryUtilities::hasRequestVariable('return')) {
+           GalleryUtilities::putRequestVariable('return',
+                   $this->_regenerateUrlSessionId(
+                           GalleryUtilities::putRequestVariables('return')));
+       }
+
+       /* Check for return urls in the session cache */
+       if ($this->exists('core.navigation')) {
+           $navigation = $this->get('core.navigation');
+
+           foreach ($navigation as $navId => $info) {
+               if (isset($navigation[$navId]['data']['returnUrl'])) {
+                   $navigation[$navId]['data']['returnUrl'] =
+                           $this->_regenerateUrlSessionId($info['data']['returnUrl']);
+               }
+           }
+
+           $this->put('core.navigation', $navigation);
+       }
+
        return GalleryStatus::success();
     }

     /**
+     * Replace the session id a URL
+     *
+     * @return string url with valid session id
+     * @access private
+     */
+    function _regenerateUrlSessionId($url) {
+       $replace = GalleryUtilities::prefixFormVariable($this->getKey()) . '=' . $this->getId();
+       $regex = preg_quote(GalleryUtilities::prefixFormVariable($this->getKey()));
+       return preg_replace('/' . $regex . '\=([a-zA-Z0-9]+)/i', $replace, $url);
+    }
+
+    /**
      * Get rid of any sessions that have not been accessed within our
      * inactivity timeout or have exceeded the max lifetime.
      *

should be fixed now, please verify.
i confirmed i committed the code just in time to make the 2-24 nightly build on jmullan's site. i don't think it was in time for the build on chetan sarva's site.

Confirmed, I just upgraded from cvs (core 0.8.17) and everything works fine now for both my G2 installations.

mindless & pelle, thanks a lot!