MultiLanguage captions module

Awesome, it totally rocks! The UI needs some improvement, but its a first nice step in a good direction here!
Thanks, mindless

and baschny pointed out that if you edit the regular title/summary/description while your session language is one of your additional-languages then it will show you the multilanguage data instead of the real title/summary/description data. so be careful of this if you try out this module... edit the primary title/summary/description fields with your session using your primary language.

no further work has been done. if anyone is interested in working on this, let us know.

i just updated the attachment above to work with recent core api changes.

mindless, if you don't mind I'll be happy to take over it (especially that I really need it as well)

I also updated the "onLoad" block in the first post above to resolve the problem where multilang data is shown in Edit Item / General... it won't put the multilang data in place for core:ItemAdmin view so you'll see the primary language data while editing items.

Is there any online example of this setup ?

thanks

Gr Ovis

ouch, and if you make all the changes that are required you won't be able to get into SiteAdmin menu...

  Error (ERROR_STORAGE_FAILURE ERROR_UNKNOWN):

    * in file E:\web\gallery2\modules\core\classes\GalleryStorage\DatabaseStorage.class at line 735 (MySqlDatabaseStorage::error)
    * in file E:\web\gallery2\modules\core\classes\GalleryStorage.class at line 220 (MySqlDatabaseStorage::search)
    * in file E:\web\gallery2\modules\core\classes\Gallery.class at line 184 (GalleryStorage::search)
    * in file E:\web\gallery2\modules\multilang\classes\MultiLangHelper.class at line 51 (Gallery::search)
    * in file E:\web\gallery2\modules\multilang\classes\MultiLangHelper.class at line 128 (GalleryAlbumItem::getItemData)
    * in file E:\web\gallery2\modules\core\classes\GalleryItem.class at line 465 (GalleryAlbumItem::onLoad)
    * in file E:\web\gallery2\modules\core\classes\helpers\GalleryEntityHelper_simple.class at line 72 (GalleryAlbumItem::onLoad)

Apparently, GalleryItem is trying to execute the module before it is even activated. So, for now you need to install and activate the module first, and make changes in GalleryItem only after that...

how can setActiveUser not get called? it's in init.php, GalleryInitSecondPass. maybe you can debug further why you see the wrong language..

mindless, you were right - my guess about setActiveUser was off-base... Here is what's happening - if you go to User preferences, and change the language - this change doesn't propagate to current session. Once I have the following change in UserPreferences

if (isset($form['language'])) {
    $user->setLanguage($form['language']);
    /* update the effective language in the current session */
    $session =& $gallery->getSession();
    $session->put('core.language', $form['language']);
}

it works fine.

If you don't have any objections - I'll check it in.
Cheers

attached is the module that doesn't require 'hacking' the core code; however it does require changing core code (the difference between hacking and changing will be a topic of another discussion :P )

You need to take out the changes that were described in GalleryItem.class and replace the onLoad function with the following:

function onLoad() {
    $ret = parent::onLoad();
    if ($ret->isError()) { return $ret->wrap(__FILE__, __LINE__); }
    $event = GalleryCoreApi::newEvent('GalleryEntity::load');
    $event->setEntity($this);
    list ($ret) = GalleryCoreApi::postEvent($event);
    if ($ret->isError()) {
        return $ret->wrap(__FILE__, __LINE__);
    }
    return GalleryStatus::success();
}

I think merging this into the base is coming soon now...

eeehhh - it does work... http://www.galan.rabinovich.org/gallery2/ I wouldn't post this code here if it didn't, now wouldn't I?

What I think is happening - PHP5 is copying obects by reference without any additional effort on my part. When I uploaded to PHP4 site - it is indeed making changes on the update only, and you are right - it doesn't work!

So, for all of you on the edge with PHP5 - take it away... The others should upgrade :evil:

Remaining problems:
1) if you have a non-default language selected the first time an item is loaded then the captions for that language are placed in the disk cache.. if you then switch to the default language you still see those captions (since it gets the item from the cache). i have a core update locally that fixes this.. basically always put the pre-onload item into the disk cache. this makes more sense anyway since we already run onload after we load an item from the disk cache (so currently those items get on-loaded twice).
2) sooner or later you're gonna get your default-language captions overwritten by another language.. since we replace the default language captions with the active language at the time the item is loaded, if at some time later in the request that item gets saved it will save with those values in place. the 0.3.0 code skips the multilanguage check for core:ItemAdmin view so you see the right thing in the edit-item General tab. i found if i save a change on edit-album Album tab I can get the active-language captions copied into the main captions. i can avoid this by checking for ItemEdit controller, but who knows where else an item may get saved? perhaps the right thing is to skip multilanguage check for any controller? hmm..

um, Jester2000, maybe you thought you were posting in the G2 Demo Sites topic..

this module is now in cvs, yay!
for problem #2, i went with skipping the multilang check for any controller.. so it's possible some delegated view may show default language instead of active language, but much less likely your captions will get overwritten accidentally.