Another EXIF related patch... now against imageblock module

damato

Joined: 2004-10-30
Posts: 29

Posted: Wed, 2004-11-24 22:43

Hi G2 developers,

several weeks ago I provided a patch for enabling G2 to display the EXIF embedded capture date instead of only the creation date of a image in the album view. And suprisingly you guys applied that patch quite fast and finally G2 is able to display the more logical EXIF date.

However even after that patch, the imageblock module of G2 did still not use the EXIF capture date for its image blocks. Even worse it did not display the dates in the correct locale format.

Today I took some minutes on these issues and patched my G2 installation to perfectly display all dates in the imageblock module as the EXIF capturedate and even using the correct locale format.

Please find my patch already posted here:
http://sourceforge.net/tracker/index.php?func=detail&aid=1072833&group_id=7130&atid=307130

Would be nice to see this patch also applied as fast as my last provided patch was applied...

cheers,
jens

baschny

Joined: 2003-01-04
Posts: 328

Posted: Wed, 2004-11-24 22:52

damato, after my rushed in patch, bharat noticed that this patch has a real performance problem that we should get rid of.

We usually cache all data for any album rendering so that browsing through albums should be fast and scalable. Now we are calling an external app for each photo on a page, which obviously is not very wise.

I haven't had much time to work out a better way of doing this, but certainly caching this information somewhere is the way to go (and which then can also be used in other situations as imageblocks, etc).

damato

Joined: 2004-10-30
Posts: 29

Posted: Wed, 2004-11-24 22:59

I agree baschny that caching this information would be a very good approach and of course better than my simple and rough patches apporoach I am providing here. But unfortunately my time is very limited and I do have other main projects on my shoulders that need my attention.

So if you can come up with something better than the current solution I would really appreciate this.

BTW: Why is G2 not using the PHP's own EXIF capabilities? Sorry, my PHP knowledge is very limited, so I dunno why jhead is used instead of PHP's own EXIF interface.

mindless

Joined: 2004-01-04
Posts: 8601

Posted: Thu, 2004-11-25 02:23

We discussed this today and came up with this task.

damato Joined: 2004-10-30 Posts: 29	Posted: Wed, 2004-11-24 22:43
	Hi G2 developers, several weeks ago I provided a patch for enabling G2 to display the EXIF embedded capture date instead of only the creation date of a image in the album view. And suprisingly you guys applied that patch quite fast and finally G2 is able to display the more logical EXIF date. However even after that patch, the imageblock module of G2 did still not use the EXIF capture date for its image blocks. Even worse it did not display the dates in the correct locale format. Today I took some minutes on these issues and patched my G2 installation to perfectly display all dates in the imageblock module as the EXIF capturedate and even using the correct locale format. Please find my patch already posted here: http://sourceforge.net/tracker/index.php?func=detail&aid=1072833&group_id=7130&atid=307130 Would be nice to see this patch also applied as fast as my last provided patch was applied... cheers, jens
	XUser login Username: * Password: * Create new account Request new password
baschny Joined: 2003-01-04 Posts: 328	Posted: Wed, 2004-11-24 22:52
	damato, after my rushed in patch, bharat noticed that this patch has a real performance problem that we should get rid of. We usually cache all data for any album rendering so that browsing through albums should be fast and scalable. Now we are calling an external app for each photo on a page, which obviously is not very wise. I haven't had much time to work out a better way of doing this, but certainly caching this information somewhere is the way to go (and which then can also be used in other situations as imageblocks, etc).

damato Joined: 2004-10-30 Posts: 29	Posted: Wed, 2004-11-24 22:59
	I agree baschny that caching this information would be a very good approach and of course better than my simple and rough patches apporoach I am providing here. But unfortunately my time is very limited and I do have other main projects on my shoulders that need my attention. So if you can come up with something better than the current solution I would really appreciate this. BTW: Why is G2 not using the PHP's own EXIF capabilities? Sorry, my PHP knowledge is very limited, so I dunno why jhead is used instead of PHP's own EXIF interface.

mindless Joined: 2004-01-04 Posts: 8601	Posted: Thu, 2004-11-25 02:23
	We discussed this today and came up with this task.

Another EXIF related patch... now against imageblock module

XUser login