2 reproducable errors

zombor

Joined: 2003-08-06
Posts: 57
Posted: Tue, 2004-10-19 18:47

Hi all I have 2 errors that i have come across in just daily usage, and thought it might be nice to report them:

Using the new Gallery2 Farva release:

If I change a photo's properties, hit apply, then hit the back button and try and edit the photo again, G2 gives me the following error:

=======================================================
Error (ERROR_OBSOLETE_DATA) : UPDATE g2_Entity SET g_modificationTimestamp=?,g_serialNumber=? WHERE g_id=? AND g_serialNumber=? (1098210834|3|489|2)

* in modules/core/classes/GalleryStorage/DatabaseStorage.class at line 543 (gallerystatus::error)
* in modules/core/classes/GalleryStorage.class at line 133 (mysqldatabasestorage::saveentity)
* in modules/core/classes/GalleryEntity.class at line 270 (gallerystorage::saveentity)
* in modules/core/classes/GalleryItem.class at line 460 (galleryfilesystementity::save)
* in modules/core/ItemEditItem.inc at line 116 (galleryphotoitem::save)
* in modules/core/ItemEdit.inc at line 82 (itemedititem::handlerequest)
* in main.php at line 161 (itemeditcontroller::handlerequest)
* in main.php at line 47
* in main.php at line 40
=========================================================

Also, when I link a photo, then delete the original, the linked photo goes crazy when I try and delete it(since there is no source picture anymore):

=========================================================
Error (ERROR_MISSING_OBJECT) : Missing object for 3970

* in modules/core/classes/GalleryStorage/DatabaseStorage.class at line 1371 (gallerystatus::error)
* in modules/core/classes/GalleryStorage/DatabaseStorage.class at line 260 (mysqldatabasestorage::_identifyentities)
* in modules/core/classes/GalleryStorage.class at line 113 (mysqldatabasestorage::loadentities)
* in modules/core/classes/helpers/GalleryEntityHelper_simple.class at line 89 (gallerystorage::loadentities)
* in modules/core/classes/GalleryCoreApi.class at line 1934 (galleryentityhelper_simple::loadentitiesbyid)
* in modules/core/classes/helpers/GalleryDerivativeHelper_advanced.class at line 649 (gallerycoreapi::loadentitiesbyid)
* in modules/core/classes/GalleryCoreApi.class at line 693 (galleryderivativehelper_advanced::rebuildcache)
* in modules/core/classes/helpers/GalleryDerivativeHelper_simple.class at line 63 (gallerycoreapi::rebuildderivativecache)
* in modules/core/classes/GalleryCoreApi.class at line 680 (galleryderivativehelper_simple::rebuildcacheifnotcurrent)
* in modules/core/ItemDelete.inc at line 225 (gallerycoreapi::rebuildderivativecacheifnotcurrent)
* in modules/core/ItemAdmin.inc at line 139 (itemdeleteview::loadtemplate)
* in modules/core/classes/GalleryView.class at line 245 (itemadminview::loadtemplate)
* in main.php at line 281 (itemadminview::doloadtemplate)
* in main.php at line 47
* in main.php at line 40
==========================================================

perhaps it would be wise to delete all links when an original is deleted?

i also get some errors "randomly" when a IE5 Mac user logs into G2. I can not reliably reproduce this error yet.

 
valiant

Joined: 2003-01-04
Posts: 32509
Posted: Tue, 2004-10-19 21:15
Quote:
If I change a photo's properties, hit apply, then hit the back button and try and edit the photo again, G2 gives me the following error

AFAIk that's intentional. you think the error message should be more userfriendly? as the error says, ERROR_OBSOLETE_DATA, you're working with onsolete data, a result of hitting the back button in that situation.

Quote:
when I link a photo, then delete the original, the linked photo goes crazy when I try and delete it(since there is no source picture anymore [...]perhaps it would be wise to delete all links when an original is deleted?

Actually, when deleting a source image, G2 takes one of the linked images and makes it the new master/source images for the other linked images.
if this doesn't work, it's a bug.

 
zombor

Joined: 2003-08-06
Posts: 57
Posted: Wed, 2004-10-20 13:35
valiant wrote:
AFAIk that's intentional. you think the error message should be more userfriendly? as the error says, ERROR_OBSOLETE_DATA, you're working with onsolete data, a result of hitting the back button in that situation.

I agree there should be an error if you are working with obsolete data, but I guess I just excpected G2 to output a more user friendly error message if there is an intentional exception occuring.

Quote:
Actually, when deleting a source image, G2 takes one of the linked images and makes it the new master/source images for the other linked images.
if this doesn't work, it's a bug.

I guess its a bug on mine then :D

i can give developers access to the gallery to verify if needed.

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7994
Posted: Wed, 2004-10-20 18:06
zombor wrote:
valiant wrote:
AFAIk that's intentional. you think the error message should be more userfriendly? as the error says, ERROR_OBSOLETE_DATA, you're working with onsolete data, a result of hitting the back button in that situation.

I agree there should be an error if you are working with obsolete data, but I guess I just excpected G2 to output a more user friendly error message if there is an intentional exception occuring.

We have a development task to create user friendly landing pages for errors. It'll happen by the final release.

zombor wrote:
Quote:
Actually, when deleting a source image, G2 takes one of the linked images and makes it the new master/source images for the other linked images.
if this doesn't work, it's a bug.

I guess its a bug on mine then :D

Can you reproduce this problem with a fresh install? If so, can you file a bug with the appropriate steps to reproduce it? Thanks!