my initial suggestions for G2

dwoods99
dwoods99's picture

Joined: 2002-09-18
Posts: 13
Posted: Wed, 2002-11-20 18:31

Today I downloaded the latest G2 cvs files, and ran the setup script...
Here are some suggestions on what I have noticed so far...

- First off, the root directories for g2 and g2/setup should have an index.php file as the
default. Web servers like Apache use index.html, index.htm, index.jsp, index.php
as the default welcome page within a directory. Many users will not have the rights
to change this. This is a problem such that visitors going to
<!-- BBCode Start --><TABLE BORDER=0 ALIGN=CENTER WIDTH=85%><TR><TD><font class="pn-sub">Code:</font><HR></TD></TR><TR><TD><FONT class="pn-sub"><PRE>http://.../gallery/ will be given an error like
Forbidden
You don't have permission to access /gallery2/ on this server.</TD></TR></TABLE><!-- BBCode End -->
Or even worse, because of lack of security, they get an index listing of the directory.

- do NOT use the *.class extension in this project
<!-- BBCode Start --><TABLE BORDER=0 ALIGN=CENTER WIDTH=85%><TR><TD><font class="pn-sub">Code:</font><HR></TD></TR><TR><TD><FONT class="pn-sub"><PRE>modules/core/classes/GalleryStorage/DatabaseStorage.class</TD></TR></TABLE><!-- BBCode End -->
because your class files are ASCII, while Java's .class files are compiled binaries.
This can be very confusing to an FTP client when trying to transfer from a Windows
machine to/from a *nix server/desktop. Please, PLEASE change this. As an another
example, Sys Admins (like myself) have scripts that ignore certain extensions when
doing text searching.

- In the config.php file, it asks for the album directory location, however we still need
to create it first, and set the proper rw permisions. The setup process does look for
this, however adding comments in this file so we can prepare the proper setup, would be nice.

- In the setup process, there are many pages that output words like "we’ve",
so it appears the apostrophe is not being translated well.

Since G2 fails for me at main.php (which should be index.php), that's all I've seen for now. :grin:

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7994
Posted: Thu, 2002-11-21 01:51

Thanks for the feedback. Keep it coming.

Quote:
- First off, the root directories for g2 and g2/setup should have an index.php file as the
default.

Yes, they both will, eventually. The access points for both of these will be cleaned up considerably, eventually. Right now that's pretty low on my priority list.

Quote:
- do NOT use the *.class extension in this project
<!-- BBCode Start --><TABLE BORDER=0 ALIGN=CENTER WIDTH=85%><TR><TD><font class="pn-sub">Code:</font><HR></TD></TR><TR><TD><FONT class="pn-sub"><PRE>modules/core/classes/GalleryStorage/DatabaseStorage.class</TD></TR></TABLE><!-- BBCode End -->
because your class files are ASCII, while Java's .class files are compiled binaries.
This can be very confusing to an FTP client when trying to transfer from a Windows
machine to/from a *nix server/desktop. Please, PLEASE change this. As an another
example, Sys Admins (like myself) have scripts that ignore certain extensions when
doing text searching.

Are you saying that there are FTP clients that will send these files as binary because
it reads the extension? Which FTP clients do that? At the moment, I'm unconvinced
that this will be a big enough issue to warrant the amount of work required to change
it. Plus, I'm happy with the .class name.

Quote:
- In the config.php file, it asks for the album directory location, however we still need
to create it first, and set the proper rw permisions. The setup process does look for
this, however adding comments in this file so we can prepare the proper setup, would be nice.

The text there does explain all that. Perhaps it's a little confusing, though. Either way we'll get around to improving that, eventually. Again, that's pretty far down on my priority list.

Quote:
- In the setup process, there are many pages that output words like "we’ve",
so it appears the apostrophe is not being translated well.

The current setup code just needs to get us to alpha. I expect that it will get completely rewritten sometime after that.

Quote:
Since G2 fails for me at main.php (which should be index.php), that's all I've seen for now. :grin:

Actually, main.php will not have the same semantics as index.php, which is why I've
called it something different. main.php is the entry point for a standalone G2. We
may have several such entry points when G2 supports being embedded in various
CMS platforms. index.php will most likely eventually contain some smart code that will
redirect the user to the right entry point.