Customized Gallery: Square Thumbnails

Hello all,

This Gallery community has been great to learn from, so I'd like to give back some of what I've learned.

As I'm new to PHP, I thought I'd use Gallery as a vehicle for teaching myself some PHP. My goal was to integrate Gallery pages into my already-existing personal website (written in xhtml strict/javascript/css2).

With very little ramp-up, I've managed to do just that: create some webpages that are functionally equivalent and just about indistinguishable from my previous work.

Here's an example of a webpage created with a customized Gallery:

http://businesslearninginc.com/familyphotos/gallery/view_album.php?set_albumName=northwest_festivals

Some highlights:

--Square thumbnails that use alpha-channel blending
--Extraction of IPTC header data for image captions and reference
--Added IPTC sort order (based on REFNUMBER, but can be any IPTC header value)
--Personalized look and feel (removed login, custom headers, footers, navbars, etc.)

Overall, I'm very satisfied with the results (everything is still a work in progress). The only real downside that I've come across is that Gallery is table-based, while I prefer working in divs, which allow for dynamically-resizing web content. A minor downside that--with some additional persistence--could be overcome.

If anyone's interested in how some of this work was accomplished, reply here and I'll offer some direction.

thanks again,

rich

how do you make it do the square thumbnails without editing each one? ive been wanting that forever, my old arles gallery maker did that.

- Seth

Thumbnails get created whenever you add a photo to Gallery (this should be pretty obvious). Thumbnail size is governed by the "Thumbnail size" value in the album properties dialog. The default behavior of Gallery is to resize the image using this value while maintaining the aspect ratio of the original image.

However, what I was looking for was slightly different. I wanted to resize the image as well, but then crop it into a square shape. Additionally, the width (or height, which are now identical) of the cropped shape should be equal to the value of the "Thumbnail size" value in the properties dialog.

This last paragraph is interesting in that it takes into account one initial short-coming that I originally ran into, which was what can happen if an image--with both a width and height greater than "Thumbnail size"--gets resized such that the aspect ratio of the original image forces either values below the desired thumbnail size value. I hope that makes sense. Play around with resizing tall/thin and short/fat images in your favorite image editor, and you'll get the idea.

Time to look at some code. I'm running Gallery 1.4.2, so your code may look different (though the logic is obviously still good).

Managing image resizing is handled in util.php, function resize_image(), which does some sizing logic (the stuff I'm interested in), and then turns around and calls function compress_image(), which is a wrapper for external calls to NetPBM or ImageMagick. I could've recreated a separate resizing function so as to guarantee no side effects, but since I only care about image resizing for thumbnails, I went ahead and altered this primary resize routine.

In util.php, function resize_image(), where the following logic exists:

$target=min($target, max($regs[0],$regs[1]));

I've replaced with:

$aspect_ratio = (min($regs[0],$regs[1])) / (max($regs[0],$regs[1]));
  $target = round($target / $aspect_ratio);

This handles the minimum thumbnail size issue. Basically, I look for smallest value aspect ratio and use that as my target size value. Since an aspect ratio is just a dimension multiplier, it's a very useful way to make sure that I meet the "Thumbnail size" requirement.

So at this point, I'm guaranteed that any dimension of an image (height or width) will not fall below the "Thumbnail size" value.

As for the logic that calls resize_image() and subsequently crops the image (handled by cut_image()), this exists in class AlbumItem, held in AlbumItem.php, function makethumbnail().

Note the code marked with ####. These indicate logic changes:

function makeThumbnail($dir, $thumb_size, $pathToThumb="")
    {
    global $gallery;
    $name = $this->image->name;
    $tag = $this->image->type;
    
    // ####
    $this->image->setThumbRectangle(0, 0, $gallery->album->fields["thumb_size"], $gallery->album->fields["thumb_size"]);    

    if (isMovie($tag))
      {
      /* Use a preset thumbnail */
      fs_copy($gallery->app->movieThumbnail, "$dir/$name.thumb.jpg");
      $this->thumbnail = new Image;
      $this->thumbnail->setFile($dir, "$name.thumb", "jpg");
    
      list($w, $h) = getDimensions("$dir/$name.thumb.jpg");
      $this->thumbnail->setDimensions($w, $h);
      }
    else
      {
      /* Make thumbnail (first crop it spec) */
      if ($pathToThumb)
        {
        $ret = copy ($pathToThumb,"$dir/$name.thumb.$tag");
        }
      else if ($this->image->thumb_width > 0)
        {
        // ####
        $ret = resize_image("$dir/$name.$tag", "$dir/$name.thumb2.$tag", $thumb_size);
        
        $ret = cut_image("$dir/$name.thumb2.$tag", 
                 "$dir/$name.thumb.$tag", 
                 $this->image->thumb_x, 
                 $this->image->thumb_y,
                 $this->image->thumb_width, 
                 $this->image->thumb_height);
                 
        // ####
        if (fs_file_exists("$dir/$name.thumb2.$tag"))
          {
          fs_unlink("$dir/$name.thumb2.$tag");
          }                                 
                 
        if ($ret)
          {
          $ret = resize_image("$dir/$name.thumb.$tag", "$dir/$name.thumb.$tag", $thumb_size);
          }
        }
      else
        {
        $ret = resize_image("$dir/$name.$tag", "$dir/$name.thumb.$tag", $thumb_size);
        }

      if ($ret)
        { 
        $this->thumbnail = new Image;
        $this->thumbnail->setFile($dir, "$name.thumb", $tag);
  
        list($w, $h) = getDimensions("$dir/$name.thumb.$tag");
        $this->thumbnail->setDimensions($w, $h);

        /* if this is the highlight, remake it */
        if ($this->highlight)
          {
          $this->setHighlight($dir, 1);
          }
        }
      else
        {
        return _("Unable to make thumbnail") ." ($ret)";
        }
      }

    return 0;
    }

The first edit,

// ####
  $this->image->setThumbRectangle(0, 0, $gallery->album->fields["thumb_size"], $gallery->album->fields["thumb_size"]);

correctly sets the dimension fields for the thumbnail. I'm not sure why this function is not called at all, since the subsequent logic appears to query the values in these fields.

The second edit,

// ####
  $ret = resize_image("$dir/$name.$tag", "$dir/$name.thumb2.$tag", $thumb_size);

makes a call into resize_image() and creates a temporary file that is the thumbnail, correctly resized, but not yet cropped. Note that a temporary file is required, as either resize_image() or cut_image() (which one escapes me now) will not permit identical source and destination file handles passed into it.

After the call to cut_image() to crop the thumbnail, clean-up is required to remove the temporary thumbnail file:

// ####
  if (fs_file_exists("$dir/$name.thumb2.$tag"))
    {
    fs_unlink("$dir/$name.thumb2.$tag");
    }

The rest of the function logic is left untouched.

Hope this helps.

rich

hmm this hack dont work with the cvs version from today

another problem is that if orginal image is really large, the thumbs looks bad because this hack only grab a small square from the middle

perhaps someone can update and enhance this hack?

now i will try if it is work with the current release :D

edit:

ahh cool i see shadow have the same problems
with a older version...

Luxus,

The hack was only created for version 1.4.2, as noted in my original post. While the logic will still apply to subsequent releases of Gallery, you (or I) would need to rewrite the code against the new sources accordingly.

As I migrate my sites to the current Gallery release, I'll also be updating the sources. Until then, read through and understand the logic, and you'll be in good shape.

To ammend your other comment, the square thumbnail uses the upper-left (0, 0) corner of an image, and not the middle as you indicate.

rich

ok i will play around with the source...
the util.php can be the same if i understand it right...
so only the AlbumItem.php need a facelift..

Since the problem I had was that it created Rectangles could it be because of this line:
$this->image->setThumbRectangle(0, 0, $gallery->album->fields["thumb_size"], $gallery->album->fields["thumb_size"]);

Is there a setThumbSquare or some function/command like that instead of a setThumbRectanble?

If I understand what he said earlier, it pulls it from the upper left hand corner because the x/y coordinates for it is 0,0:

If you change the 0,0 to something else like 100, 100 or something else. Have to mess with it a bit that will change where it crops the image from, probably want cordinates from near the center.

---

Anyone have any luck getting this to work with 1.4.3?

Hello all,

As I'm back from my respite with some good news, as I can confirm that the hack as described in this thread does work for Gallery v1.4.3-pl2, as evidenced here:

http://beta.businesslearninginc.com/gallery/northwest_festivals

As several folks have had some issues with the square thumbs, I'll help each in order as posted.

One quick observation (without looking at anyone's code) is that I run this hack on a box that uses NetPBM and not ImageMagick, so it's possible (again, an untested theory at this moment) that the problems some folks are having is related to the platform graphics toolset. When I get back into my sources, I should be able to better judge this observation.

thanks,

rich

Hi Shadow Wolf,

I can confirm that the hack will work in Gallery v1.4.3-pl2, as evidenced here:

http://beta.businesslearninginc.com/gallery/northwest_festivals

Since I'm still trying to understand why you might be having problems, can you please answer the following questions for me:

A) Can you display square thumbs (regardless of what part of the image it grabs, just whether you have it working at all)?
B) If not working, are you using NetPBM or ImageMagick?

Functionally, the code should handle any image size passed to it, as it ultimately resizes it based on thumb_size.

thanks much,

rich

FerN: If you look in your config.php for $gallery->app->graphics =, you'll see either ImageMagick or NetPBM.

richbl: When I had the hack installed I was only able to get rectangle thumbnails, it would not create square thumbnails at all. I tried deleting all thumbnails and recreating them, still same thing. The only way I could get square thumbnails was to manually resize thumbnail.

I am using ImageMagick not NetPBM. I have also placed util.php and AlbumItem.php into a zip file so you can take a look and make sure I followed your instructions correctly. I've attached it here.

I redid the changes again following the instructions just to make sure I didn't make any mistakes. I'm still getting the same thing. However I am having another issue. I didn't want to mess with any of my artists galleries so I made a test gallery and when I try to upload I get the following error:

Processing status... 

- Adding arsea.gif 
   Resizing/compressing original image 
   No resizing required 
   No resizing required 
Error: Unable to make thumbnail (0)! 
Need help? Look in the Gallery FAQ 

Removing the AlbumItem.php and replacing it with my backup that had no changes, I was able to upload fine. So whatever changes are made in AlbumItem.php seem to be what effects my ability to upload images. I know its not the changes in util.php because I still have the one with the changes uploaded and its not giving me any issues.

I've got it to make new uploads have square thumbnails - but the result is that the album highlight on the parent page is a low-res of the top corner of the highlight photo.

Is there a way for the highlight photo to be different from the album thumbnail?

--Coops

examples at:

http://testing.coopersphotos.co.uk/gallery/ [and
http://beta.businesslearninginc.com/gallery/]

Hello all,

For completeness, I've reposted the sources for square thumbnails below. These are for the current release version of Gallery, v1.4.3-pl2 (as of this writing, v1.4.4 is still a release candidate).

An example of square thumbnails in use can be seen here (Gallery v1.4.2):

http://businesslearninginc.com/familyphotos/gallery/view_album.php?set_albumName=northwest_festivals

And here (Gallery v1.4.3-pl2):

http://beta.businesslearninginc.com/gallery/northwest_festivals

There are two files that require changes: util.php and AlbumItem.php.

In util.php, function resize_image() is changed to provide the logic for resizing an image based on the "Thumbnail size" parameter available through the properties dialog. Note also that in the transition from Gallery v.1.4.2 to the current release (v1.4.3-pl2), resize_image() return values are altered. This point will be important when revisiting changes in AlbumItem.php (below).

Note the code marked with ####. These indicate logic changes:

function resize_image($src, $dest, $target=0, $target_fs=0, $keepProfiles=0) {
	/*
	 *  Valid return codes:
	 *  0:  File was not resized, no processing to be done
	 *  1:  File resized, process normally
	 *  2:  Existing resized file should be removed
	 */
	global $gallery;				
  
	if (!strcmp($src,$dest)) {
		$useTemp = true;
		$out = "$dest.tmp";
	}
	else {
		$out = $dest;
		$useTemp = false;
	}

	$regs = getimagesize($src);
	if ($regs[2] !== 2 && $regs[2] !== 3) {
		$target_fs = 0; // can't compress other images
	}
	if ($target === 'off') {
	    $target = 0;
	}
		
	/* Check for images smaller then target size, don't blow them up. */
	$regs = getDimensions($src, $regs);
	if ((empty($target) || ($regs[0] <= $target && $regs[1] <= $target))
			&& (empty($target_fs) || ((int) fs_filesize($src) >> 10) <= $target_fs)) {
		processingMsg("&amp;&amp;&amp;". _("No resizing required"));
		if ($useTemp == false && !strstr($dest, ".sized.")) {
			fs_copy($src, $dest);
			return 1;
		}
		elseif (fs_file_exists($dest) && strstr($dest, ".sized.")) {
			return 2;
		}
		return 0;
	}
  
// #### 
// $target=min($target, max($regs[0],$regs[1]));

  $aspect_ratio = (min($regs[0],$regs[1])) / (max($regs[0],$regs[1]));
  $target = round($target / $aspect_ratio);

	if ($target_fs == 0) {
		compress_image($src, $out, $target, $gallery->app->jpegImageQuality, $keepProfiles);
	} else {
		$filesize = (int) fs_filesize($src) >> 10;
		$max_quality=$gallery->app->jpegImageQuality;
		$min_quality=5;
		$max_filesize=$filesize;
		$min_filesize=0;
		if (!isset($quality)) {
			$quality=$gallery->album->fields['last_quality'];
		}
		processingMsg("&amp;&amp;&amp;". sprintf(_("target file size %d kbytes"), 
					$target_fs)."<br>");

		do {
			compress_image($src, $out, $target, $quality, $keepProfiles);
			$prev_quality=$quality;
			printf(_("-> file size %d kbytes"), round($filesize));
			processingMsg("&amp;&amp;&amp;" . sprintf(_("trying quality %d%%"), 
						$quality));
			clearstatcache();
			$filesize= (int) fs_filesize($out) >> 10;
			if ($filesize < $target_fs) {
				$min_quality=$quality;
				$min_filesize=$filesize;
			} else if ($filesize > $target_fs){
				$max_quality=$quality;
				$max_filesize=$filesize;
			} else if ($filesize == $target_fs){
				$min_quality=$quality;
				$max_quality=$quality;
				$min_filesize=$filesize;
				$max_filesize=$filesize;
			}
			$quality=($max_quality + $min_quality)/2;
			$quality=round($quality);
			if ($quality==$prev_quality) {
				if ($filesize==$max_filesize) {
					$quality--;
				} else {
					$quality++;
				}
			}
		} while ($max_quality-$min_quality > 2 && 
				abs(($filesize-$target_fs)/$target_fs) > .02 );

		$gallery->album->fields['last_quality']=$prev_quality;
		printf(_("-> file size %d kbytes"), round($filesize));
		processingMsg(_("Done."));
	}
	if (fs_file_exists("$out") && fs_filesize("$out") > 0) {
		if ($useTemp) {
			fs_copy($out, $dest);
			fs_unlink($out);
		}
		return 1;
	} else {
		return 0;
	}
}

In class AlbumItem.php, function makeThumbnail() is also changed. When an image is passed into makeThumbnail(), the final desired thumbnail dimensions are first set, the image is resized, and then cropped into a square.

Note the code marked with ####. These indicate logic changes:

function makeThumbnail($dir, $thumb_size, &$album, $pathToThumb="")
	  {
		global $gallery;
		$name = $this->image->name;
		$tag = $this->image->type;

    // ####
    $this->image->setThumbRectangle(0, 0, $gallery->album->fields["thumb_size"],$gallery->album->fields["thumb_size"]);    
    
		if (isMovie($tag))
      {
			/* Use a preset thumbnail */
			fs_copy($gallery->app->movieThumbnail, "$dir/$name.thumb.jpg");
			$this->thumbnail = new Image;
			$this->thumbnail->setFile($dir, "$name.thumb", "jpg");

			list($w, $h) = getDimensions("$dir/$name.thumb.jpg");
			$this->thumbnail->setDimensions($w, $h);
		  }
    else
      {
			/* Make thumbnail (first crop it spec) */
			if ($pathToThumb)
        {
				$ret = copy ($pathToThumb,"$dir/$name.thumb.$tag");
			  }
      else if ($this->image->thumb_width > 0)
			  {        
        // ####
        $ret = resize_image("$dir/$name.$tag", "$dir/$name.thumb2.$tag", $thumb_size);

        $ret = cut_image("$dir/$name.thumb2.$tag",
                 "$dir/$name.thumb.$tag",
                 $this->image->thumb_x,
                 $this->image->thumb_y,
                 $this->image->thumb_width,
                 $this->image->thumb_height);
                 
        // ####
        if (fs_file_exists("$dir/$name.thumb2.$tag"))
          {
          fs_unlink("$dir/$name.thumb2.$tag");
          }     
                                      
// ####        
//				if ($ret)
//          {
//					$ret = resize_image("$dir/$name.thumb.$tag","$dir/$name.thumb.$tag", $thumb_size);
//				  }
			  }
      else
        {
				$ret = resize_image("$dir/$name.$tag", "$dir/$name.thumb.$tag", $thumb_size);
			  }

			if ($ret)
        { 
				$this->thumbnail = new Image;
				$this->thumbnail->setFile($dir, "$name.thumb", $tag);
	
				list($w, $h) = getDimensions("$dir/$name.thumb.$tag");
				$this->thumbnail->setDimensions($w, $h);

				/* if this is the highlight, remake it */
				if ($this->highlight)
          {
					$this->setHighlight($dir, 1, $album);
				  }
			  }
      else
        {
				return _("Unable to make thumbnail") ." ($ret)";
			  }
		  }
		return 0;
	  }

As mentioned earlier, with this current release of Gallery, function resize_image() was changed so it now returns different values (i.e., 0, 1, 2). As a result, makeThumbnail() would incorrectly fail though the thumbnail was correctly resized and cropped. To alleviate the problem with this new functionality, the second call in makeThumbnail() to resize_image() was removed (it was superfluous).

One side-affect of which I'm aware (and has since been mentioned in this thread) is that the images used in Gallery index pages are affected by this hack. This is correct, and though unintentional, is not of particular concern to me, as I don't explicitly use Gallery index pages. The solution to resolving this would be to create some logic that toggled the functionality of square thumbnails such that Gallery functions calling into makeThumbnail() can either choose square thumbnails, or the original uncropped thumbnails instead. While not a significant undertaking, it does add to the complexity of the code that would need to be written.

As always, if you have questions, please ask and I will do my best to help clarify.

thanks,

rich

That didn't work but I did forget one thing. I didn't comment these out.

// ####        
//            if ($ret) 
//          { 
//               $ret = resize_image("$dir/$name.thumb.$tag","$dir/$name.thumb.$tag", $thumb_size); 
//              }

That completely fixed it which does bring up the issue of the main gallery page also being squares and something else. Almost all my artists love the square images, there are a couple though that prefer the old method. Would there be a way to create it so the user can choose what method they want? By doing so could it be worked in to solve the issue with the main gallery page as well?

I've made one addition to the square thumbnail hack which alleviates the side-effect previously discussed on this thread. Specifically, on Gallery album index pages, the code changes to generate square thumbnails would alter the highlighted image on the index page.

Since I don't make explicit use of these index pages, I originally had little interest in the side-effect produced. However, for those who use album index pages (and I'd guess most do), I've made the appropriate code changes.

I'm currently using Gallery v1.4.3-pl2, but the logic changes suggested here should work for prior versions, as well as the upcoming v.1.4.4 release.

The code change involves function setHighlight(), found in AlbumItem.php. Note the code marked with ####. These indicate logic changes:

  function setHighlight($dir, $bool, &$album, $name = null, $tag = null, $srcdir = null, $srcitem = null)
    {
    global $gallery;

    $this->highlight = $bool;

    /*
     * if it is now the highlight make sure it has a highlight
     * thumb otherwise get rid of it's thumb (ouch!).
     */

    if ($this->highlight)
      {
      if (!isset($name))
        {
        $name = $this->image->name;
        $tag = $this->image->type;
        $srcdir = $dir;
        $srcitem = $this;
        if ($this->isAlbumName)
          {
          $name = $this->isAlbumName;
          $nestedAlbum = new Album();
          $nestedAlbum->load($name);
          list($srcalbum, $srcitem) = $nestedAlbum->getHighlightedItem();
          if ($srcalbum !== null && $srcitem !== null)
            {
            $srcdir = $srcalbum->getAlbumDir();
            $tag = $srcitem->image->type;
            }
          else
            {
            if (is_object($this->highlightImage))
              {
              $this->highlightImage->simpleDelete($dir);
              $this->highlightImage = null;
              }
            return ;
            }
          }
        }
      $size = $album->getHighlightSize();

      if ($srcitem->image->thumb_width > 0)
        {
// ####        
        $ret = resize_image("$srcdir/".$srcitem->image->name.".$tag",
          "$dir/$name.tmp.$tag", $size);

        if ($ret)
          {
          $ret = cut_image("$dir/$name.tmp.$tag",
            "$dir/$name.highlight.$tag", $srcitem->image->thumb_x, $srcitem->image
            ->thumb_y, $size, $size);
          }
          
        fs_unlink("$dir/$name.tmp.$tag");
                  
// ####          
/*        
        // Crop it first
        $ret = cut_image("$srcdir/".$srcitem->image->name.".$tag",
          "$dir/$name.tmp.$tag", $srcitem->image->thumb_x, $srcitem->image
          ->thumb_y, $srcitem->image->thumb_width, $srcitem->image
          ->thumb_height);
          
        // Then resize it down
        if ($ret)
          {
          $ret = resize_image("$dir/$name.tmp.$tag",
            "$dir/$name.highlight.$tag", $size);
          }
          
        fs_unlink("$dir/$name.tmp.$tag");
*/
          
        }
      elseif ($this->isMovie())
        {
        $tag = substr(strrchr($gallery->app->movieThumbnail, '.'), 1);
        $ret = resize_image($gallery->app->movieThumbnail,
          "$dir/$name.highlight.$tag", $size);
        }
      else
        {
        $ret = resize_image("$srcdir/".$srcitem->image->name.".$tag",
          "$dir/$name.highlight.$tag", $size);
        }

      if ($ret)
        {
        list($w, $h) = getDimensions("$dir/$name.highlight.$tag");

        $high = new Image;
        $high->setFile($dir, "$name.highlight", "$tag");
        $high->setDimensions($w, $h);
        $this->highlightImage = $high;

        /* Check if we need to cascade highlight up to parent album */
        $parentAlbum = &$album->getParentAlbum();        
        if (isset($parentAlbum) && !strcmp($parentAlbum->version, $gallery
          ->album_version))
          {
          $highlightIndex = $parentAlbum->getHighlight();
          if ($highlightIndex == $parentAlbum->getAlbumIndex($album
            ->fields['name']))
            {
            $item = &$parentAlbum->getPhoto($highlightIndex);
            $item->setHighlight($parentAlbum->getAlbumDir(), 1, $parentAlbum,
              $album->fields['name'], $tag, $srcdir, $srcitem);
            $parentAlbum->save(array(), 0);
            }
          }          
        }
      }
    else
      {
      if (is_object($this->highlightImage))
        {
        $this->highlightImage->simpleDelete($dir);
        $this->highlightImage = null;
        }
      }
    }

This change mirrors the program logic found in my customized function makeThumbnail() (also found in AlbumItem.php): the image in question is first resized, then cropped to produce the resulting square thumbnail image.

A slight variation which might be of interest to some would be to resize the highlight image, but not crop it square. The solution entails removing the cut_image() function (responsible for image cropping), and making a change to the output arguement in the preceeding resize_image() routine. Note the code fragment below:

...
      if ($srcitem->image->thumb_width > 0)
        {
// ####        
        $ret = resize_image("$srcdir/".$srcitem->image->name.".$tag",
          "$dir/$name.highlight.$tag", $size);

// ####          
/*        
        // Crop it first
        $ret = cut_image("$srcdir/".$srcitem->image->name.".$tag",
          "$dir/$name.tmp.$tag", $srcitem->image->thumb_x, $srcitem->image
          ->thumb_y, $srcitem->image->thumb_width, $srcitem->image
          ->thumb_height);
          
        // Then resize it down
        if ($ret)
          {
          $ret = resize_image("$dir/$name.tmp.$tag",
            "$dir/$name.highlight.$tag", $size);
          }

        fs_unlink("$dir/$name.tmp.$tag");          
*/
        }
...

Enjoy.

rich

Hey all, Well I tried the latest update hear to try and get the square hack to work in my gallery. I get an error:
Parse error: parse error, unexpected '\"' in /home/dibsdetr/public_html/tiseo/gallery/classes/AlbumItem.php on line 584

The version is 1.4.4-RC2 does anyone know how to get this to work with this version? Below is my code.

util.php:

function resize_image($src, $dest, $target=0, $target_fs=0, $keepProfiles=0) {
	/*
	 *  Valid return codes:
	 *  0:  File was not resized, no processing to be done
	 *  1:  File resized, process normally
	 *  2:  Existing resized file should be removed
	 */
	global $gallery;				

	if (!strcmp($src,$dest)) {
		$useTemp = true;
		$out = "$dest.tmp";
	}
	else {
		$out = $dest;
		$useTemp = false;
	}

	$regs = getimagesize($src);
	if ($regs[2] !== 2 && $regs[2] !== 3) {
		$target_fs = 0; // can't compress other images
	}
	if ($target === 'off') {
	    $target = 0;
	}
		
	/* Check for images smaller then target size, don't blow them up. */
	$regs = getDimensions($src, $regs);
	if ((empty($target) || ($regs[0] <= $target && $regs[1] <= $target))
			&& (empty($target_fs) || ((int) fs_filesize($src) >> 10) <= $target_fs)) {
		processingMsg("&amp;&amp;&amp;". _("No resizing required"));

		/* If the file is already smaller than the target filesize, don't
		 * create a new sized image.  return 2 indicates that the current .sized.
		 * needs to be removed */
		if ($useTemp == false && !strstr($dest, ".sized.")) {
			fs_copy($src, $dest);
			return 1;
		}
		elseif (fs_file_exists($dest) && strstr($dest, ".sized.")) {
			return 2;
		}
		return 0;
	}

// ####
//$target=min($target, max($regs[0],$regs[1]));

  $aspect_ratio = (min($regs[0],$regs[1])) / (max($regs[0],$regs[1])); 
  $target = round($target / $aspect_ratio);

	if ($target_fs == 0) {
		compress_image($src, $out, $target, $gallery->app->jpegImageQuality, $keepProfiles);
	} else {
		$filesize = (int) fs_filesize($src) >> 10;
		$max_quality=$gallery->app->jpegImageQuality;
		$min_quality=5;
		$max_filesize=$filesize;
		$min_filesize=0;
		if (!isset($quality)) {
			$quality=$gallery->album->fields['last_quality'];
		}
		processingMsg("&amp;&amp;&amp;". sprintf(_("target file size %d kbytes"), 
					$target_fs)."\n");

		do {
			compress_image($src, $out, $target, $quality, $keepProfiles);
			$prev_quality=$quality;
			printf(_("-> file size %d kbytes"), round($filesize));
			processingMsg("&amp;&amp;&amp;" . sprintf(_("trying quality %d%%"), 
						$quality));
			clearstatcache();
			$filesize= (int) fs_filesize($out) >> 10;
			if ($filesize < $target_fs) {
				$min_quality=$quality;
				$min_filesize=$filesize;
			} else if ($filesize > $target_fs){
				$max_quality=$quality;
				$max_filesize=$filesize;
			} else if ($filesize == $target_fs){
				$min_quality=$quality;
				$max_quality=$quality;
				$min_filesize=$filesize;
				$max_filesize=$filesize;
			}
			$quality=($max_quality + $min_quality)/2;
			$quality=round($quality);
			if ($quality==$prev_quality) {
				if ($filesize==$max_filesize) {
					$quality--;
				} else {
					$quality++;
				}
			}
		} while ($max_quality-$min_quality > 2 && 
				abs(($filesize-$target_fs)/$target_fs) > .02 );

		$gallery->album->fields['last_quality']=$prev_quality;
		printf(_("-> file size %d kbytes"), round($filesize));
		processingMsg(_("Done."));
	}
	if (fs_file_exists("$out") && fs_filesize("$out") > 0) {
		if ($useTemp) {
			fs_copy($out, $dest);
			fs_unlink($out);
		}
		return 1;
	} else {
		return 0;
	}
}

The code of AlbumItem.php

function makeThumbnail($dir, $thumb_size, &$album, $pathToThumb="")
	{
	global $gallery;
	$name = $this->image->name;
	$tag = $this->image->type;

// ####
$this->image->setThumbRectangle(0, 0, $gallery->album->fields
["thumb_size"],$gallery->album->fields["thumb_size"]);

	if (isMovie($tag))
	 {
	/* Use a preset thumbnail */
	fs_copy($gallery->app->movieThumbnail, "$dir/$name.thumb.jpg");
	$this->thumbnail = new Image;
	$this->thumbnail->setFile($dir, "$name.thumb", "jpg");

	list($w, $h) = getDimensions("$dir/$name.thumb.jpg");
	$this->thumbnail->setDimensions($w, $h);
	} 
	else
	{
	/* Make thumbnail (first crop it spec) */
	if ($pathToThumb) {
	$ret = copy($pathToThumb,"$dir/$name.thumb.$tag");
	} 
	else if ($this->image->thumb_width > 0)
	 {
	// ####
	$ret = resize_image("$dir/$name.$tag", "$dir/$name.thumb2.$tag",
	$thumb_size);
					
	$ret = cut_image("$dir/$name.thumb2.$tag", 
			 "$dir/$name.thumb.$tag", 
			 $this->image->thumb_x, 
			 $this->image->thumb_y,
			 $this->image->thumb_width, 
			 $this->image->thumb_height);
				
			// ####
			if (fs_file_exists("$dir/$name.thumb2.$tag")) 
          			{ 
          			fs_unlink("$dir/$name.thumb2.$tag"); 
          			}  
// ####								
//			if ($ret) {
//			$ret = resize_image("$dir/$name.thumb.$tag", "$dir/
$name.thumb.$tag", $thumb_size);
//			}
			} else {
			$ret = resize_image("$dir/$name.$tag", "$dir/$name.thumb.$tag",
			$thumb_size);
			}

		if ($ret) { 
			$this->thumbnail = new Image;
			$this->thumbnail->setFile($dir, "$name.thumb", $tag);
	
			list($w, $h) = getDimensions("$dir/$name.thumb.$tag");
			$this->thumbnail->setDimensions($w, $h);

			/* if this is the highlight, remake it */
			if ($this->highlight) {
			$this->setHighlight($dir, 1, $album);
				}
			} else {
				return _("Unable to make thumbnail") ." ($ret)";
			}
		}

		return 0;
	}

So I hope someone can help me get this working! Thank you for any effort!

Ok your allsome that did get it to work!
One problem and one question though.

Now what happens to my images is they expand beyond my max res.

Thumbnail for album gets created as a square and is at 0,0 and the thumbnail inside of that is ok but now my picutres are to big and is falling outside of my layout.

Does this hack control the image creation/scale size?

If it created the images to the size that it does when I leave those 2 files alone things would be perfect.

Thanks again

Shadow_Wolf,

In response to your questions:

1) I haven't been able to track this down, but I suspect that somewhere, Gallery is resizing the thumbnail (actually the highlight image) twice. And, if you have your jpg compression set, successive resizes will degrade image quality regardless of whether the image size actually changed (the degrade happens at time of file save). As a quick solution, you might want to try setting jpg compression to minimal/no compression and observe the results.

2) I don't understand the intent of this question. Please rephrase.

3) This origin for the resize will always be 0,0, regardless of size. The reason for this is that the original image always gets resized to the dimensions you specify (image_size) first. THEN, the crop occurs, making the resulting image square. This is by design.

I think what you're asking is whether it's possible to select an artibitrary origin (e.g. 200, 500) within the original image, then crop a square of image_size. This is possible, but a very different solution with very different visual results. Offhand, here's what you'd want to do:

1. Pass user origin into function (e.g. 200, 500).
2. Check again maximum dimensions of image (error case).
3. Crop image. Save thumbnail.

Note that in this case, the call into resize_image() would not be required.

Best of luck.

rich[/]

I was also very curious how you apply that alpha effect to your css and where to put it on which file.

Yes, read the fourth post on this thread. It describes how the effect was achieved.

rich

Strikker,

It's unclear as to what images you're referring to in your post. Are you referring to the thumbnail size, intermediate image size, or the actual image size?

In all cases, thumbnail and image sizes are dictated by entries in the Album Properties property sheet. "Thumbnail size" is used in my code to determine the maximum size of an image thumbnail. As for image sizes, I don't make direct use of this information.

You may want to check your entries in the fields for "Maximum dimensions of intermediate sized images" and "Maximum dimensions of full sized images." These will govern the maximum size of your images.

Best of luck.

rich

Rich,

I've been trying to put together an online portfolio for my photos, what I want to accomplish is too simplify the gallery interface, so users simply sees thumbnails and photos only. To my surprise you've done quite well in your website that renders the results that one is expecting.

For the easier part, I've implemented your hacks--works like a charm, but when I tried to "copy" your wonderful thumbnail listing, I was back to where I was again--confused.

Would you mind shed me--or us some light on how you achive such a hack? Identical to the result your site has? I'd appreciate it if you could write some bits of tips on it. TiA.

Hello all,

I've made a revision to my square thumbnail feature in Gallery v.1.4.4. The primary reason for doing this was to clean up the code logic while also providing some added flexibility in the use of the feature.

Perhaps the most significant improvement is the added capability of toggling square thumbnails via the Properties page.

As the complexity of this feature has increased, so too have the number of files affected. The list below is all files that must be altered in order to provide for the square thumbnails feature:

\gallery\config.php
\gallery\edit_appearance.php
\gallery\util.php

\gallery\classes\AlbumItem.php
\gallery\classes\Album.php

As in previous posts, code commented with #### indicates changes in logic. While the feature has been tested using sources from Gallery v1.4.4, there should be no reason for the logic to propagate backwards (or forwards) through past or future Gallery releases.

In config.php:

...
/* Defaults */
$gallery->app->default["bordercolor"] = "black";
$gallery->app->default["border"] = "1";
$gallery->app->default["font"] = "arial";
$gallery->app->default["cols"] = "7";
$gallery->app->default["rows"] = "10";
$gallery->app->default["thumb_size"] = "108";

// ####
$gallery->app->default["thumb_shape"] = "no";

$gallery->app->default["resize_size"] = "off";
$gallery->app->default["resize_file_size"] = "0";
$gallery->app->default["max_size"] = "640";
$gallery->app->default["max_file_size"] = "0";
...

In edit_appearance.php:

...
if (isset($save)) {
  if (get_magic_quotes_gpc()) {
    $gallery->album->fields["summary"] = stripslashes($summary);
    $gallery->album->fields["title"] = stripslashes($title);
  } else {
    $gallery->album->fields["summary"] = $summary;
    $gallery->album->fields["title"] = $title;
  }
  $gallery->album->fields["bgcolor"] = $bgcolor;
  $gallery->album->fields["textcolor"] = $textcolor;
  $gallery->album->fields["linkcolor"] = $linkcolor;
  $gallery->album->fields["font"] = $font;
  $gallery->album->fields["bordercolor"] = $bordercolor;
  $gallery->album->fields["border"] = $border;
  $gallery->album->fields["background"] = $background;  
  $gallery->album->fields["thumb_size"] = $thumb_size;

// ####  
  $gallery->album->fields["thumb_shape"] = $thumb_shape;
  
  $gallery->album->fields["resize_size"] = $resize_size;
  $gallery->album->fields["resize_file_size"] = $resize_file_size;
  $gallery->album->fields['max_size'] = $max_size;
...

and

...
<tr>
  <td class="popup"><?php echo _("Thumbnail size") ?></td>
  <td><input type="text" name="thumb_size" value="<?php echo $gallery->album->fields["thumb_size"] ?>"></td>
</tr>
<!-- ####> -->  
<tr>
  <td class="popup"><?php echo _("Display square thumbnails") ?></td>
  <td>
  <select name="thumb_shape"><?php echo selectOptions($gallery->album, "thumb_shape", array("yes" => _("yes"), "no" => _("no"))) ?>
  </select>
  </td>
<tr>
<!-- <#### --> 
...

In util.php, function resize_image():

...
// ####
function resize_image($src, $dest, $target=0, $target_fs=0, $keepProfiles=0, $squareThumb="no")
...

and

...
    if ($useTemp == false && !strstr($dest, ".sized."))
      {
      fs_copy($src, $dest);
      return 1;
      }
    elseif (fs_file_exists($dest) && strstr($dest, ".sized."))
      {
      return 2;
      }
      
    return 0;
    }
        
// ####> 
  if ($squareThumb == "yes")
    {
    $aspect_ratio = (min($regs[0],$regs[1])) / (max($regs[0],$regs[1]));
    $target = round($target / $aspect_ratio);
    }
  else
    {
    $target=min($target, max($regs[0],$regs[1]));
    }
// <####

  if ($target_fs == 0)
    {
    compress_image($src, $out, $target, $gallery->app->jpegImageQuality, $keepProfiles);
    }
...    

In util.php, function createNewAlbum():

...
    $gallery->album->fields['background']      = $parentAlbum->fields['background'];
    $gallery->album->fields["font"]            = $parentAlbum->fields["font"];
    $gallery->album->fields["border"]          = $parentAlbum->fields["border"];
    $gallery->album->fields["bordercolor"]     = $parentAlbum->fields["bordercolor"];
    $gallery->album->fields["thumb_size"]      = $parentAlbum->fields["thumb_size"];
    
// ####                
    $gallery->album->fields["thumb_shape"]      = $parentAlbum->fields["thumb_shape"];
               
    $gallery->album->fields["resize_size"]     = $parentAlbum->fields["resize_size"];
    $gallery->album->fields["resize_file_size"]     = $parentAlbum->fields["resize_file_size"];
    $gallery->album->fields['max_size']        = $parentAlbum->fields['max_size'];
    $gallery->album->fields['max_file_size']   = $parentAlbum->fields['max_file_size'];
    $gallery->album->fields['returnto']        = $parentAlbum->fields['returnto'];
...

In Album.php, function Album():

...
    $this->fields["border"] = $gallery->app->default["border"];
    $this->fields["bordercolor"] = $gallery->app->default["bordercolor"];
    $this->fields["returnto"] = $gallery->app->default["returnto"];
    $this->fields["thumb_size"] = $gallery->app->default["thumb_size"];

// ####    
    $this->fields["thumb_shape"] = $gallery->app->default["thumb_shape"];
    
    $this->fields["resize_size"] = $gallery->app->default["resize_size"];
    $this->fields["resize_file_size"] = $gallery->app->default["resize_file_size"];
    $this->fields['max_size'] = $gallery->app->default['max_size'];
    $this->fields['max_file_size'] = $gallery->app->default['max_file_size'];
    $this->fields["rows"] = $gallery->app->default["rows"];
...

In AlbumItem.php, function setHighlight():

...
      $size = $album->getHighlightSize();
            
      if ($srcitem->image->thumb_width > 0  && !$this->isMovie())
        {
      
// ####>
        $squareThumb = $gallery->album->fields["thumb_shape"];
        
        if ($squareThumb == "yes")
          {          

          $ret = resize_image("$srcdir/".$srcitem->image->name.".$tag", "$dir/$name.tmp.$tag", $size, 0, 0, "yes");
  
          if ($ret)
            {
            $ret = cut_image("$dir/$name.tmp.$tag",
              "$dir/$name.highlight.$tag", $srcitem->image->thumb_x, $srcitem->image->thumb_y, $size, $size);
            }
            
          fs_unlink("$dir/$name.tmp.$tag");
          }
        else
          {
          // Crop it first
          $ret = cut_image("$srcdir/".$srcitem->image->name.".$tag",
            "$dir/$name.tmp.$tag",
            $srcitem->image->thumb_x,
            $srcitem->image->thumb_y,
            $srcitem->image->thumb_width,
            $srcitem->image->thumb_height);
  
          // Then resize it down
          if ($ret)
            {
            $ret = resize_image("$dir/$name.tmp.$tag", 
              "$dir/$name.highlight.$tag",
              $size);
            }
            
          fs_unlink("$dir/$name.tmp.$tag");
          } 
// <####

        }      
      elseif ($this->isMovie())
        {
        
        if (fs_file_exists($gallery->app->movieThumbnail))
...

And in AlbumItem.php, function makeThumbnail():

...
    $name = $this->image->name;
    $tag = $this->image->type;
    
    // ####>
    $squareThumb = $gallery->album->fields["thumb_shape"];
        
    if ($squareThumb == "yes")
      {
      $this->image->setThumbRectangle(0, 0, $gallery->album->fields["thumb_size"],
        $gallery->album->fields["thumb_size"]);
      }
    // <####     

     if ($this->isMovie())
...     

and

...
      else if ($this->image->thumb_width > 0) 
        {

// ####>
        if ($squareThumb == "no")
          {
          $ret = cut_image("$dir/$name.$tag", 
            "$dir/$name.thumb.$tag", 
            $this->image->thumb_x, 
            $this->image->thumb_y,
            $this->image->thumb_width, 
            $this->image->thumb_height);
          if ($ret)
            {
            $ret = resize_image("$dir/$name.thumb.$tag", 
              "$dir/$name.thumb.$tag", $thumb_size);
            }
          }
        else
          {  
          $ret = resize_image("$dir/$name.$tag", "$dir/$name.thumb2.$tag", $thumb_size, 0, 0, $squareThumb);
          $ret = cut_image("$dir/$name.thumb2.$tag",
            "$dir/$name.thumb.$tag",
            $this->image->thumb_x,
            $this->image->thumb_y,
            $this->image->thumb_width,
            $this->image->thumb_height);
                 
          if (fs_file_exists("$dir/$name.thumb2.$tag"))
            {
            fs_unlink("$dir/$name.thumb2.$tag");
            }
          }                                           
// <####
      
        } 
      else
        {
        $ret = resize_image("$dir/$name.$tag", "$dir/$name.thumb.$tag", $thumb_size);
        }
...

enjoy,

rich[/]

Any suggestions richbl?

Ok thanks bud, I will see if I can figure it out!

Rich your directions are beyond frustrating. Why not just provide the edited php files for the latest gallery. That or "on line 249 add XXXX"