downloadalbum - displaying for guests and giving error page

andy duggan

Joined: 2006-05-21
Posts: 90
Posted: Thu, 2013-05-23 13:55

Showing for guests but giving an error page (Dang..something went wrong). Users will click this and think it doesnt work... then start complaining to me!

I cant see anyway to set this to display to any permissions, yet the mod page says it works to user permissions.

"DownloadAlbum is a module for Gallery 3 which will allow you to add a download link to the album pages. This module will only be displayed when the visitor has sufficient privileges to access the full sized version of the photos of the current album. "
 
floridave
floridave's picture

Joined: 2003-12-22
Posts: 27300
Posted: Thu, 2013-05-23 19:45

Looking at the code, but not trying it...it seems the docs are wrong. I don't see how it checks to see if the user has view rights to the full sized images in the album before showing the download icon.
I guess it could be enhanced to do so. How is your coding skills?

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team
 
andy duggan

Joined: 2006-05-21
Posts: 90
Posted: Sat, 2013-05-25 12:28
Quote:
How is your coding skills?

Well, 1988 pascal, C, z80 assembler, a little lisp, and some fortran a few years before that. Nothing since then... I might start learning the basics of php and sql in a year or two but you could say Im pretty useless for fixing this.
 
floridave
floridave's picture

Joined: 2003-12-22
Posts: 27300
Posted: Sun, 2013-05-26 17:56

Edit helpers/downloadalbum/helpers/downloadalbum_event.php

class downloadalbum_event_Core {
  static function album_menu($menu, $theme) {
    if ($theme->item && access::can("view_full", $theme->item)) {
    $downloadLink = url::site("downloadalbum/zip/album/{$theme->item->id}");
    $menu
      ->append(Menu::factory("link")
          ->id("downloadalbum")
          ->label(t("Download Album"))
          ->url($downloadLink)
          ->css_id("g-download-album-link"));
	}
  }

I will have to dig a lot more for fixing the tag menu viewablity.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team
 
andy duggan

Joined: 2006-05-21
Posts: 90
Posted: Mon, 2013-05-27 19:23

Grateful for that but dont worry too much about it - not as something that needs to be done. I will do the edits tomorrow and see what happens. As I said I can inform people they will get error pages if not logged in.

I was just a bit worried that 3rd party contributors are not keeping stuff updated. And you dont have a lot of time to check or fix things.
Though it doesnt reflect well on the project when people install them and get trouble. I had trouble with this and the user info mod which crashed the theme display. After deleting it no problem.
Would be useful to have a rating/comment on mods to report/reflect problems.
 
andy duggan

Joined: 2006-05-21
Posts: 90
Posted: Wed, 2013-05-29 15:48

That edit worked perfectly ... so far.
Thanks!