3.0.7 - Strange form behavior - edit photo - json reply

jnash

Joined: 2004-08-02
Posts: 814

Posted: Tue, 2013-05-07 03:07

Can someone else check/verify this?

ver: 3.0.7
theme: any? (default wind and clean canvas)

condition:
When viewing a photo (not thumb in album, but the photo itself)
logged in as admin (or owner) ('can edit')
from top menu under Photo Options
then Edit photo

form doesn't seem to load right, and has two cancel buttons
hitting either cancel button, or modify results in blank page returning with json success location line

Side note:

Works fine from the thumbnail option menu (when viewing photos on album view)for Edit this photo

shadlaws

Joined: 2012-03-14
Posts: 183

Posted: Tue, 2013-05-07 13:20

@jnash - curious - is this happening with 3.0.7, or the newest from the master branch?

If 3.0.7, then no - I can't reproduce the symptoms on my end. If master, then yes - it's a remaining nagging issue I need to resolve from the big jQuery update. It seems to be related specifically to item views and not album views, as doing the same thing with an album doesn't cause issue. I'm currently working on getting all of our forms converted to Kohana 3, and afterward am going to try and work this out...

Take care,
Shad

jnash

Joined: 2004-08-02
Posts: 814

Posted: Tue, 2013-05-07 13:42

Ooops, sorry, yes, build 406... I just did a fresh git install on a test gallery.

Also, you're correct, in 3.0.7 release, the issue is not there. In build 406 it is.

jnash

Joined: 2004-08-02
Posts: 814

Posted: Tue, 2013-05-07 13:44

Also see the similar behavior for the exif details dialog - except that when you close the window(hit the 'x'), the dialog disappears, but then shows below the page...

I'll see if I can get a screen shot of it.

It does this weird 'put the data down below on the page' for the edit photo dialog too once you 'x' out.

shadlaws

Joined: 2012-03-14
Posts: 183

Posted: Tue, 2013-05-07 14:04

@jnash - yep, that's exactly the issue I see. The issue is in gallery.dialog.js, which is double-ajaxifying some things. Taking a look at the code, I'm a bit surprised that jQuery 1.3 didn't have issues, but 1.9 certainly does. I'll do a better rewrite of it in a bit. For a quicker fix, you may consider switching over to the 3.0.x branch...

Take care,
Shad

jnash

Joined: 2004-08-02
Posts: 814

Posted: Tue, 2013-05-07 14:06

Thanks shadlaws. I'm just 'prepping' for the new version with a test gallery (and the modules I use) to ensure I'm set for the upgrade when ready.

Not a big deal, just wanted to see if it was me, my code, or the base code.

shadlaws

Joined: 2012-03-14
Posts: 183

Posted: Tue, 2013-05-07 16:55

So, this bug was really bothering me... if you pull down the newest git master branch, you should see that it's disappeared

Take care,
Shad

jnash

Joined: 2004-08-02
Posts: 814

Posted: Tue, 2013-05-07 17:00

nice, working perfectly again - you rock!

shadlaws

Joined: 2012-03-14
Posts: 183

Posted: Wed, 2013-05-08 05:26

No prob!

jnash Joined: 2004-08-02 Posts: 814	Posted: Tue, 2013-05-07 03:07
	Can someone else check/verify this? ver: 3.0.7 theme: any? (default wind and clean canvas) condition: When viewing a photo (not thumb in album, but the photo itself) logged in as admin (or owner) ('can edit') from top menu under Photo Options then Edit photo form doesn't seem to load right, and has two cancel buttons hitting either cancel button, or modify results in blank page returning with json success location line Side note: Works fine from the thumbnail option menu (when viewing photos on album view)for Edit this photo
	XUser login Username: * Password: * Create new account Request new password
shadlaws Joined: 2012-03-14 Posts: 183	Posted: Tue, 2013-05-07 13:20
	@jnash - curious - is this happening with 3.0.7, or the newest from the master branch? If 3.0.7, then no - I can't reproduce the symptoms on my end. If master, then yes - it's a remaining nagging issue I need to resolve from the big jQuery update. It seems to be related specifically to item views and not album views, as doing the same thing with an album doesn't cause issue. I'm currently working on getting all of our forms converted to Kohana 3, and afterward am going to try and work this out... Take care, Shad

jnash Joined: 2004-08-02 Posts: 814	Posted: Tue, 2013-05-07 13:42
	Ooops, sorry, yes, build 406... I just did a fresh git install on a test gallery. Also, you're correct, in 3.0.7 release, the issue is not there. In build 406 it is.

jnash Joined: 2004-08-02 Posts: 814	Posted: Tue, 2013-05-07 13:44
	Also see the similar behavior for the exif details dialog - except that when you close the window(hit the 'x'), the dialog disappears, but then shows below the page... I'll see if I can get a screen shot of it. It does this weird 'put the data down below on the page' for the edit photo dialog too once you 'x' out.

shadlaws Joined: 2012-03-14 Posts: 183	Posted: Tue, 2013-05-07 14:04
	@jnash - yep, that's exactly the issue I see. The issue is in gallery.dialog.js, which is double-ajaxifying some things. Taking a look at the code, I'm a bit surprised that jQuery 1.3 didn't have issues, but 1.9 certainly does. I'll do a better rewrite of it in a bit. For a quicker fix, you may consider switching over to the 3.0.x branch... Take care, Shad

jnash Joined: 2004-08-02 Posts: 814	Posted: Tue, 2013-05-07 14:06
	Thanks shadlaws. I'm just 'prepping' for the new version with a test gallery (and the modules I use) to ensure I'm set for the upgrade when ready. Not a big deal, just wanted to see if it was me, my code, or the base code.

shadlaws Joined: 2012-03-14 Posts: 183	Posted: Tue, 2013-05-07 16:55
	So, this bug was really bothering me... if you pull down the newest git master branch, you should see that it's disappeared Take care, Shad

jnash Joined: 2004-08-02 Posts: 814	Posted: Tue, 2013-05-07 17:00
	nice, working perfectly again - you rock!

shadlaws Joined: 2012-03-14 Posts: 183	Posted: Wed, 2013-05-08 05:26
	No prob!

3.0.7 - Strange form behavior - edit photo - json reply

XUser login