editcreated and editcaptured

mikeage

Joined: 2005-01-23
Posts: 138

Posted: Thu, 2013-01-03 12:52

I noticed that both the editcreated and editcaptured modules (from the -contrib repository) are missing styling information edit opening the context menu from a search or dynamic page. It appears that the tests in edit*/helpers/edit*_theme.php are failing since $theme->item() isn't defined for these pages.

It seems that most of the other modules add their CSS regardless of whether edit permission is available; I think the same should be done here (and it works in my local copy).

Should I submit a pull request? How is the "ownership" of the unofficial modules handled?

floridave

Joined: 2003-12-22
Posts: 27300

Posted: Thu, 2013-01-03 22:54

Post in the forum(s) for the module for the original author to verify and update. If there is no responce in a couple of days then make changes and make a pull request on the -contrib repository.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

mikeage

Joined: 2005-01-23
Posts: 138

Posted: Fri, 2013-01-04 05:57

Editcreated doesn't have; editcaption has http://gallery.menalto.com/node/98508, but for some reason, I can't comment there.

Hopefully someone will see this one.

tempg

Joined: 2005-12-17
Posts: 1857

Posted: Fri, 2013-01-04 14:34

mikeage wrote:

Editcreated doesn't have

I'm not sure if you mean editcreation; I don't see one called editcreated.
http://gallery.menalto.com/node/90667
http://codex.gallery2.org/Gallery3:Modules:editcreation

mikeage wrote:

for some reason, I can't comment there

It's because the thread has been inactive for so long; it would have to be reopened.

floridave

Joined: 2003-12-22
Posts: 27300

Posted: Fri, 2013-01-04 15:06

Quote:

for some reason, I can't comment there

I unlocked http://gallery.menalto.com/node/98508
barring that send a PM to the author as a curtsy.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

mikeage

Joined: 2005-01-23
Posts: 138

Posted: Sat, 2013-01-05 17:03

I did mean editcreation. Sorry.

Done and done.

xmod

Joined: 2010-10-08
Posts: 21

Posted: Sun, 2013-01-06 21:33

Hi to all ... let's say "back again" ? ...

Sorry, I was kind of "inactive" for a couple of month for personal reasons and I am really sorry for that! I will try to become more active again the next days and weeks, I promise.
First of all I will have to find back into the topic and programming stuff details of menalto modules. What I can give you as information in advance is that for the editcaptured module I just copied the structure of the editcreation module and modified it a little bit at the right lines. But if someone has some better suggestions or improvements - feel free to copy and/or modify the module!

Best regards,
xmod

mikeage

Joined: 2005-01-23
Posts: 138

Posted: Mon, 2013-01-07 04:23

Ok, thanks. I found the same problem in editcreation

I'm sending a pull request now.

mikeage Joined: 2005-01-23 Posts: 138	Posted: Thu, 2013-01-03 12:52
	I noticed that both the editcreated and editcaptured modules (from the -contrib repository) are missing styling information edit opening the context menu from a search or dynamic page. It appears that the tests in edit/helpers/edit_theme.php are failing since $theme->item() isn't defined for these pages. It seems that most of the other modules add their CSS regardless of whether edit permission is available; I think the same should be done here (and it works in my local copy). Should I submit a pull request? How is the "ownership" of the unofficial modules handled?
	XUser login Username: * Password: * Create new account Request new password
floridave Joined: 2003-12-22 Posts: 27300	Posted: Thu, 2013-01-03 22:54
	Post in the forum(s) for the module for the original author to verify and update. If there is no responce in a couple of days then make changes and make a pull request on the -contrib repository. Dave _____________________________________________ Blog & G2 \|\| floridave - Gallery Team

mikeage Joined: 2005-01-23 Posts: 138	Posted: Fri, 2013-01-04 05:57
	Editcreated doesn't have; editcaption has http://gallery.menalto.com/node/98508, but for some reason, I can't comment there. Hopefully someone will see this one.

tempg Joined: 2005-12-17 Posts: 1857	Posted: Fri, 2013-01-04 14:34
	mikeage wrote: Editcreated doesn't have I'm not sure if you mean editcreation; I don't see one called editcreated. http://gallery.menalto.com/node/90667 http://codex.gallery2.org/Gallery3:Modules:editcreation mikeage wrote: for some reason, I can't comment there It's because the thread has been inactive for so long; it would have to be reopened.

floridave Joined: 2003-12-22 Posts: 27300	Posted: Fri, 2013-01-04 15:06
	Quote: for some reason, I can't comment there I unlocked http://gallery.menalto.com/node/98508 barring that send a PM to the author as a curtsy. Dave _____________________________________________ Blog & G2 \|\| floridave - Gallery Team

mikeage Joined: 2005-01-23 Posts: 138	Posted: Sat, 2013-01-05 17:03
	I did mean editcreation. Sorry. Done and done.

xmod Joined: 2010-10-08 Posts: 21	Posted: Sun, 2013-01-06 21:33
	Hi to all ... let's say "back again" ? ... Sorry, I was kind of "inactive" for a couple of month for personal reasons and I am really sorry for that! I will try to become more active again the next days and weeks, I promise. First of all I will have to find back into the topic and programming stuff details of menalto modules. What I can give you as information in advance is that for the editcaptured module I just copied the structure of the editcreation module and modified it a little bit at the right lines. But if someone has some better suggestions or improvements - feel free to copy and/or modify the module! Best regards, xmod

mikeage Joined: 2005-01-23 Posts: 138	Posted: Mon, 2013-01-07 04:23
	Ok, thanks. I found the same problem in editcreation I'm sending a pull request now.

editcreated and editcaptured

XUser login