My theme bombed by update

RalphTheWonderLlama

Joined: 2005-07-16
Posts: 68
Posted: Sat, 2012-07-07 16:44

I got things fixed but I wanted to post here in case anyone else had a similar problem. I updated my gallery from 3.0.2 to 3.0.4 and followed the directions here http://codex.gallery2.org/Gallery3:User_guide:Gallery3:Installing_and_upgrading#Upgrading

So I copied my own theme and here is what my Gallery looked like after finishing the update process:
[img]http://img15.imageshack.us/img15/7695/capturelyd.png[/img]

So then I started looking at code. I thought I didn't change that much from the default Wind so I did a diff on my CSS files with those from Wind. There were lots of changes in the screen.css but that was it. I didn't want to go through all the changes and nothing stood out to me. Then I tried copying the Wind theme from the new 3.0.4 and putting in my screen.css and my theme.info and thank goodness that worked.

There must have been some differences elsewhere in the files. I didn't see anything about this in the forum. For future reference, where do I need to check to see if there is a change that will affect my theme? Will updates affect the theme often?

 
floridave
floridave's picture

Joined: 2003-12-22
Posts: 27300
Posted: Sun, 2012-07-08 06:26

With each release there is a news story as well as a thread. Your issue was with 3.0.3:
http://gallery.menalto.com/gallery_3.0.3_feedback
In that thread there was some fixes suggested for various themes.
There was also a few other threads about stacked thumbs as well.

Quote:
Will updates affect the theme often?

We try to minimize these changes but in some cases we can't.
So 3.0.3 to 3.0.4 was not a theme change but up to 3.0.3 there was.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

 
RalphTheWonderLlama

Joined: 2005-07-16
Posts: 68
Posted: Mon, 2012-07-16 04:27

Ok, could there be maybe some note in the news story if the update affects themes? The feedback thread was after the fact, though good to see there were many replies. Thanks for the message.

 
floridave
floridave's picture

Joined: 2003-12-22
Posts: 27300
Posted: Mon, 2012-07-16 13:01

So we are to test each 3rd party theme and delay the release if we can't find all themes that are affected. We did the best we can I believe.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

 
jimmycraig
jimmycraig's picture

Joined: 2012-07-16
Posts: 1
Posted: Mon, 2012-07-16 14:20
Quote:
So we are to test each 3rd party theme and delay the release if we can't find all themes that are affected.

Dave, I think you missed the point and took it personally as well. What Ralph is looking for is just some advance warning that his theme (amongst the many thousands out there) might be affected by the changes. You indicated yourself that the change to 3.0.3 WAS a theme change, and 3.0.3 to 3.0.4 WAS NOT. That tells me that you at least have an idea when themes may be affected. All Ralph is asking for is a little advance warning. Imagine what would have happened to someone who does not have the skills/talent that Ralph has, and consequently had no idea what to do when that happened. I suspect many would have just chucked the whole thing and that is bad publicity for Gallery.

Thanks for your activities and input, we need people like you to keep things going!

 
floridave
floridave's picture

Joined: 2003-12-22
Posts: 27300
Posted: Tue, 2012-07-17 03:57
Quote:
That tells me that you at least have an idea when themes may be affected.

I did not know until I installed the other themes and even upgraded some of them.
Got time to volunteer to keep this tracked for the next and subsequent releases? Then I can possibly do more.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

 
RalphTheWonderLlama

Joined: 2005-07-16
Posts: 68
Posted: Thu, 2012-07-19 00:09

Thanks Jimmy. Yeah I didn't mean to imply you should test 3rd party themes. Maybe I was a little too brazen with the thread subject. Dave, I know you have to be defensive on here with all the crap that I see sometimes. I'm ok if you just let me know where things stand. I enjoy G3 and will take what I can get. If I had some regular free time I might try contributing.

As a programmer myself, I would have a bell or something going off if I knew a change I made would affect user themes. In fact, the default Wind theme from the previous version was screwed up the same way when I tested it so the theme had to have been updated in response to whatever code change.

Anyway I know where you guys stand now so that's good. For future updates I will either be prepared to do a little theme work with it (and not update late at night!) or just not do the update. I knew making my own theme was going down the road just a little of taking on this work, I just didn't expect it in the first update I did.