Beta: I am looking for people who are willing to participate in early beta of GreyDragon Theme 4.0
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Thu, 2012-08-16 15:38
Actually there is a second problem with tag navigation that I'm having with GD4 - the paginator is giving numbers and URLs that relate to the physical album of the current resize, rather than the tag that is currently being browsed. You can see this in my test site. The modified views\paginator.html.php thatrWatcher gave me fixed this for GD3.2.2, and it looks to me like his changes could be ported across to GD4 fairly simply.
U-G
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Fri, 2012-08-17 08:09
It has been pointed out to me that the up button is a third problem.
latest GD4, uses latest G3 logic for breadcrumbs so custom code does not apply anymore. this is taking care of My_Theme_View.php
As for other changes, while I do not usually implement custom module logic, I highly regard rWatcher's work, so I have incorporated some of his changes.
I am uploading latest version of GD4
Thanks for doing this. But just to be clear, with G3.0.4 and GD4, I'm not looking to use rWatcher's Tag Albums for basic tag navigation (I only use rWatcher's Tag Albums module for certain virtual albums.) In module order I have the Tag Albums module below the Tags module, so when I am navigating tags, my test site (see my PM) is using the core G3.0.4 code, not rWatchers. And had the problems outlined above. I would still have them if I completely removed Tag Albums. So I don't think the issue is custom code - I think it's a question of whether GD4 picks up the new tags navigation code in all situations. It seems to me that in the beta I'm running on my test site, it doesn't. I could remove Tag Albums completely to illustrate the point, if that would help.
Is this your understanding?
U-G
windracer
Joined: 2007-03-05
Posts: 113
Posted: Thu, 2012-08-23 02:36
I did some tinkering and was able to fix my problems with the book framepack and movie overlay module. I'm not a CSS guy so this was all done by trial and error, but it seems to be working for me. Here's what I did:
First, to fix the completely missing frame for movie thumbs, I had to add the following lines to the frame.css file for the book framepack:
.g-movie.g-thumbtype-sqr { background: url('../images/thumb-sqr.png') no-repeat top left; }
.g-movie.g-thumbtype-flm { background: url('../images/thumb-flm.png') no-repeat top left; }
.g-movie.g-thumbtype-dgt { background: url('../images/thumb-dgt.png') no-repeat top left; }
.g-movie.g-thumbtype-wd { background: url('../images/thumb-wd.png') no-repeat top left; }
Then, to fix the missing right-hand side of the frame (for photo and movie thumbs), in frame.css for the book framepack again, I increased the right-hand padding from 0px to 10px.
The minimum, without cutting off the right-hand portion of the frame, seems to be 7px. I went with 10 so that there's more separation between albums (which have the spiral notebook graphic on the left-hand side).
To fix the misaligned context menu and icon (for movie thumbs), in movie_overlay_theme.php I changed the margin-top and margin-left values until I got it in the correct location. The resulting menu is also properly aligned this way.
Hope this helps someone else! Perhaps the changes to the framepack's frame.css should be made in GD4. I'm not sure about the changes to the movie_overlay module.
floridave
Joined: 2003-12-22
Posts: 27300
Posted: Thu, 2012-08-23 02:36
Quote:
I'm not sure about the changes to the movie_overlay module.
I have recently made changes to the moudule to work better with the GD theme, try it. It does not fix the frame issue though.
Dave ... I was already using the most recent version of your module (v3 from 8/10/12) and still had to make my above changes in order for the context-menu icon to be in the proper location. The missing frames are due to a problem in the framepack that's part of GD4, not your module.
Serge D
Joined: 2009-06-11
Posts: 2466
Posted: Thu, 2012-08-23 22:17
windracer wrote:
I did some tinkering and was able to fix my problems with the book framepack and movie overlay module. I'm not a CSS guy so this was all done by trial and error, but it seems to be working for me....
Added your changes in today's refresh
take a look
there is still work need to be done to make it available for all others thumb aspect ratios and extended size.
if you willing to spend little time and extend your rules there it would be great.
there is still work need to be done to make it available for all others thumb aspect ratios and extended size.
if you willing to spend little time and extend your rules there it would be great.
I guess I'm not sure what those changes would be? Just more entries for .g-movie (copying the .g-photo stuff for .g-extended and .g-expanded) in frame.css? I don't know what that stuff is for ...
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Fri, 2012-08-24 06:44
There were three problems with GD4 and tags navigation. I've uploaded the latest GD4 beta to my test site and this fixes one problem, but two problems remain. Note that this is not related to the Tag Albums module. To demonstrate this, I have disabled Tags Albums on my test site and the two problems remain, so these are pure GD4 issues.
1. If I am browsing the resize images for a tag, and click on a resize image to start Shadowbox, then Shadowbox traverses the album that the image I clicked on is contained in, rather than the images with the tag.
2. If I am browsing the resize images for a tag, the paginator numbers 1 2 3 .... refer to the album rather than the tag.
This seems to happen because GD4 still does not completely use the modified tag navigation code in G3.0.3 & 3.0.4.
I will PM you details.
U-G
pdoes
Joined: 2008-01-09
Posts: 9
Posted: Fri, 2012-08-31 01:13
I'll participate in the beta testing.
I had to setup my gallery from scratch so figured using 4.0 would be helpful.
I do have programming experience, writing WordPress plugins and themes, so is there a way I can send patches for bugs I encounter?
Serge D
Joined: 2009-06-11
Posts: 2466
Posted: Tue, 2012-09-04 17:45
@pdoes: send me PM with your findings and I will incorporate fixes and suggestions
I would appreciate extra help in areas related to G3 JS functionality as there are some small problems there still
Another area is to validate all the frame packs with all aspects and as much resolutions possible
Everything seems to work smoothly (gallery upgrade process seemed buggy and "failed" but this is the Grey Dragon thread!).
My gallery visually looks the exact same as it did with GreyDragon 3.0.7. Settings all saved and transferred over which made me very happy.
Bugs before and after upgrade:
* Large resize and padding never works. Always breaks. A larger resize than the user's screen will always cut off the edges of a landscape photo in gredragon. Using the "image fit" module actually did nothing. Using "fit to screen" worked much better, but the interaction between the resized image and greydragon padding was still very, very wonky and beyond my abilities coder (my very, very novice ability). Even if I got the image scaled correctly with a screen size of 1920, the greydragon padding was based on the size of the original rescale- so it didn't play nice at any other screen width and would constantly be cutting off the left side of the image. I'm left with the choice of having an image resize that's too small for large monitors, or too large for small monitors.
So I installed the shadowbox module and disabled the photo page. Shadowbox is correctly rescaling images based on screen size, and it's pretty wonderful.
* Album sorting by capture time doesn't seem to work correctly. I wish we could still edit the album creation time like in gallery2. Is this a generic gallery bug?
Bugs after? upgrade:
* With Shadowbox installed, viewing photos on an iOS device is impossible, as clicks on the photos in the album do nothing. It'd be nice if greydragon detected mobile browsers and (if photo page disabled) launched directly to the resized jpeg, skipping shadowbox.
Suggestions:
* There's very little documentation on the theme options page about disabling photo page and what happens when you enable shadowbox
* Album sorting by capture time doesn't seem to work correctly. I wish we could still edit the album creation time like in gallery2. Is this a generic gallery bug?
This is a Gallery thing, not GreyDragon. Check out the editcreation module for this feature.
shidarin
Joined: 2005-09-27
Posts: 14
Posted: Sun, 2012-09-09 19:45
windracer wrote:
shidarin wrote:
* Album sorting by capture time doesn't seem to work correctly. I wish we could still edit the album creation time like in gallery2. Is this a generic gallery bug?
This is a Gallery thing, not GreyDragon. Check out the editcreation module for this feature.
Doh, how did I miss that module. I just spent an hour manually organizing them by hand too.
Thank you!
pdoes
Joined: 2008-01-09
Posts: 9
Posted: Mon, 2012-09-17 14:03
Serge D wrote:
@pdoes: send me PM with your findings and I will incorporate fixes and suggestions
I would appreciate extra help in areas related to G3 JS functionality as there are some small problems there still
Another area is to validate all the frame packs with all aspects and as much resolutions possible
I had to abandon the Gallery software, so won't be able to help out with the beta testing anymore. The reason for abandoning Gallery is the fact my provider and the provider of a client have moved to PHP 5.3 with ZendGuard 3 and Gallery is incompatible with ZendGuard 3, actually it's Kohana 2.x that is incompatible.
Serge D
Joined: 2009-06-11
Posts: 2466
Posted: Tue, 2012-09-25 16:38
@pdoes: Sorry to hear
Kohana 2 is dead, unfortunately migration to Kohana 3 is not possible as it is complete redesign.
K3 is HTML 5, HMVC (vs MVC), new framework without migration path...
there are quite a few changes - outlined in changelog
most important:
work in progress to replace old and outdate jquery from G3
it is now HTML 5 enabled
ah, so all "under the hood" changes then. I just meant it looks identical to 3.22 and has all the same options.
Good work keeping it current.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Thu, 2012-09-27 00:08
Serge: I take it that V4 is still experimental? Did you ever get any response to your questions about inconsistencies in tag navigation?
Serge D
Joined: 2009-06-11
Posts: 2466
Posted: Thu, 2012-09-27 00:17
undagiga wrote:
Serge: I take it that V4 is still experimental? Did you ever get any response to your questions about inconsistencies in tag navigation?
yes, still experimental, i.e. it is not finished
I just do not have time to decide if I want to dump all upload, dialog, etc. functionality of image manipulations and rely on new Organize module or try to fight core code...
nevertheless, without admin functions it is functional
No, I did not get any response about tags.
I would say - rely on rWather's tag module instead
Serge, I'm using GreyDragon 4.0 happily and without any issues on my personal website for months now, but when I just checked in the wiki, I couldn't find it there at all. Shouldn't it be out of bèta phase by now?
Posts: 693
Actually there is a second problem with tag navigation that I'm having with GD4 - the paginator is giving numbers and URLs that relate to the physical album of the current resize, rather than the tag that is currently being browsed. You can see this in my test site. The modified views\paginator.html.php thatrWatcher gave me fixed this for GD3.2.2, and it looks to me like his changes could be ported across to GD4 fairly simply.
U-G
Posts: 693
It has been pointed out to me that the up button is a third problem.
U-G
Posts: 2466
see below
Serge
_____________________________________________
Photo Gallery | GreyDragon Theme | Follow on Twitter
Posts: 2466
@undagiga:
latest GD4, uses latest G3 logic for breadcrumbs so custom code does not apply anymore. this is taking care of My_Theme_View.php
As for other changes, while I do not usually implement custom module logic, I highly regard rWatcher's work, so I have incorporated some of his changes.
I am uploading latest version of GD4
Serge
_____________________________________________
Photo Gallery | GreyDragon Theme | Follow on Twitter
Posts: 693
Serge
Thanks for doing this. But just to be clear, with G3.0.4 and GD4, I'm not looking to use rWatcher's Tag Albums for basic tag navigation (I only use rWatcher's Tag Albums module for certain virtual albums.) In module order I have the Tag Albums module below the Tags module, so when I am navigating tags, my test site (see my PM) is using the core G3.0.4 code, not rWatchers. And had the problems outlined above. I would still have them if I completely removed Tag Albums. So I don't think the issue is custom code - I think it's a question of whether GD4 picks up the new tags navigation code in all situations. It seems to me that in the beta I'm running on my test site, it doesn't. I could remove Tag Albums completely to illustrate the point, if that would help.
Is this your understanding?
U-G
Posts: 113
I did some tinkering and was able to fix my problems with the book framepack and movie overlay module. I'm not a CSS guy so this was all done by trial and error, but it seems to be working for me. Here's what I did:
First, to fix the completely missing frame for movie thumbs, I had to add the following lines to the frame.css file for the book framepack:
.g-movie.g-thumbtype-sqr { background: url('../images/thumb-sqr.png') no-repeat top left; }
.g-movie.g-thumbtype-flm { background: url('../images/thumb-flm.png') no-repeat top left; }
.g-movie.g-thumbtype-dgt { background: url('../images/thumb-dgt.png') no-repeat top left; }
.g-movie.g-thumbtype-wd { background: url('../images/thumb-wd.png') no-repeat top left; }
Then, to fix the missing right-hand side of the frame (for photo and movie thumbs), in frame.css for the book framepack again, I increased the right-hand padding from 0px to 10px.
before: #g-album-grid>li { padding: 10px 0px 10px 14px; }
after : #g-album-grid>li { padding: 10px 10px 10px 14px; }
The minimum, without cutting off the right-hand portion of the frame, seems to be 7px. I went with 10 so that there's more separation between albums (which have the spiral notebook graphic on the left-hand side).
To fix the misaligned context menu and icon (for movie thumbs), in movie_overlay_theme.php I changed the margin-top and margin-left values until I got it in the correct location. The resulting menu is also properly aligned this way.
before:
.g-movie-thumb .g-context-menu {
margin-top: -6px!important;
margin-left: -5px!important;
}
after:
.g-movie-thumb .g-context-menu {
margin-top: -16px!important;
margin-left: -20px!important;
}
The results.
before:
[img]http://www.windracer.net/outgoing/misc/gd4-movie-overlay-issue2.png[/img]
after:
[img]http://www.windracer.net/outgoing/misc/g4-book-frame-fixed.png[/img]
Hope this helps someone else! Perhaps the changes to the framepack's frame.css should be made in GD4. I'm not sure about the changes to the movie_overlay module.
Posts: 27300
I have recently made changes to the moudule to work better with the GD theme, try it. It does not fix the frame issue though.
Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team
Posts: 113
Dave ... I was already using the most recent version of your module (v3 from 8/10/12) and still had to make my above changes in order for the context-menu icon to be in the proper location. The missing frames are due to a problem in the framepack that's part of GD4, not your module.
Posts: 2466
Added your changes in today's refresh
take a look
there is still work need to be done to make it available for all others thumb aspect ratios and extended size.
if you willing to spend little time and extend your rules there it would be great.
Serge
_____________________________________________
Photo Gallery | GreyDragon Theme | Follow on Twitter
Posts: 113
I guess I'm not sure what those changes would be? Just more entries for .g-movie (copying the .g-photo stuff for .g-extended and .g-expanded) in frame.css? I don't know what that stuff is for ...
Posts: 693
There were three problems with GD4 and tags navigation. I've uploaded the latest GD4 beta to my test site and this fixes one problem, but two problems remain. Note that this is not related to the Tag Albums module. To demonstrate this, I have disabled Tags Albums on my test site and the two problems remain, so these are pure GD4 issues.
1. If I am browsing the resize images for a tag, and click on a resize image to start Shadowbox, then Shadowbox traverses the album that the image I clicked on is contained in, rather than the images with the tag.
2. If I am browsing the resize images for a tag, the paginator numbers 1 2 3 .... refer to the album rather than the tag.
This seems to happen because GD4 still does not completely use the modified tag navigation code in G3.0.3 & 3.0.4.
I will PM you details.
U-G
Posts: 9
I'll participate in the beta testing.
I had to setup my gallery from scratch so figured using 4.0 would be helpful.
I do have programming experience, writing WordPress plugins and themes, so is there a way I can send patches for bugs I encounter?
Posts: 2466
@pdoes: send me PM with your findings and I will incorporate fixes and suggestions
I would appreciate extra help in areas related to G3 JS functionality as there are some small problems there still
Another area is to validate all the frame packs with all aspects and as much resolutions possible
Serge
_____________________________________________
Photo Gallery | GreyDragon Theme | Follow on Twitter
Posts: 14
Upgraded gallery to 3.0.4 (from 3.0.2) yesterday. Installed GreyDragon 4.0 beta.
Everything seems to work smoothly (gallery upgrade process seemed buggy and "failed" but this is the Grey Dragon thread!).
My gallery visually looks the exact same as it did with GreyDragon 3.0.7. Settings all saved and transferred over which made me very happy.
Bugs before and after upgrade:
* Large resize and padding never works. Always breaks. A larger resize than the user's screen will always cut off the edges of a landscape photo in gredragon. Using the "image fit" module actually did nothing. Using "fit to screen" worked much better, but the interaction between the resized image and greydragon padding was still very, very wonky and beyond my abilities coder (my very, very novice ability). Even if I got the image scaled correctly with a screen size of 1920, the greydragon padding was based on the size of the original rescale- so it didn't play nice at any other screen width and would constantly be cutting off the left side of the image. I'm left with the choice of having an image resize that's too small for large monitors, or too large for small monitors.
So I installed the shadowbox module and disabled the photo page. Shadowbox is correctly rescaling images based on screen size, and it's pretty wonderful.
* Album sorting by capture time doesn't seem to work correctly. I wish we could still edit the album creation time like in gallery2. Is this a generic gallery bug?
Bugs after? upgrade:
* With Shadowbox installed, viewing photos on an iOS device is impossible, as clicks on the photos in the album do nothing. It'd be nice if greydragon detected mobile browsers and (if photo page disabled) launched directly to the resized jpeg, skipping shadowbox.
Suggestions:
* There's very little documentation on the theme options page about disabling photo page and what happens when you enable shadowbox
http://www.alphamatte.com/gallery/
Thank you for your hard work on Greydragon!
Posts: 113
This is a Gallery thing, not GreyDragon. Check out the editcreation module for this feature.
Posts: 14
Doh, how did I miss that module. I just spent an hour manually organizing them by hand too.
Thank you!
Posts: 9
I had to abandon the Gallery software, so won't be able to help out with the beta testing anymore. The reason for abandoning Gallery is the fact my provider and the provider of a client have moved to PHP 5.3 with ZendGuard 3 and Gallery is incompatible with ZendGuard 3, actually it's Kohana 2.x that is incompatible.
Posts: 2466
@pdoes: Sorry to hear
Kohana 2 is dead, unfortunately migration to Kohana 3 is not possible as it is complete redesign.
K3 is HTML 5, HMVC (vs MVC), new framework without migration path...
Serge
_____________________________________________
Photo Gallery | GreyDragon Theme | Follow on Twitter
Posts: 34
Hi Serge, I would be happy to do some testing with this if you like.
Posts: 34
I can't see any real detectable differences except the version now says 4.00, it has however fixed my search issues from 3.22 so I'm stoked thanks.
http://www.bikesnstuff.net/gallery3/
Posts: 2466
there are quite a few changes - outlined in changelog
most important:
work in progress to replace old and outdate jquery from G3
it is now HTML 5 enabled
Serge
_____________________________________________
Photo Gallery | GreyDragon Theme | Follow on Twitter
Posts: 34
ah, so all "under the hood" changes then. I just meant it looks identical to 3.22 and has all the same options.
Good work keeping it current.
Posts: 693
Serge: I take it that V4 is still experimental? Did you ever get any response to your questions about inconsistencies in tag navigation?
Posts: 2466
yes, still experimental, i.e. it is not finished
I just do not have time to decide if I want to dump all upload, dialog, etc. functionality of image manipulations and rely on new Organize module or try to fight core code...
nevertheless, without admin functions it is functional
No, I did not get any response about tags.
I would say - rely on rWather's tag module instead
Serge
_____________________________________________
Photo Gallery | GreyDragon Theme | Follow on Twitter
Posts: 314
Serge, I'm using GreyDragon 4.0 happily and without any issues on my personal website for months now, but when I just checked in the wiki, I couldn't find it there at all. Shouldn't it be out of bèta phase by now?