(1.4-pl2 update) now cannot search with the letter b

robert070612

Joined: 2003-08-05
Posts: 565

Posted: Mon, 2003-10-20 15:20

Sirs

Just updated my village's website from <gallery-1.3.4-pl1> to <gallery-1.4-pl2>.

The football enthusiasts are now unable to use the search phrase <football match> because the gallery software has seemingly, and very suddenly, developed an issue searching with the letter . The search use of <foot> and <match> is OK but <footb> is not. Somewhat accidently <ball> succeeds as the letters <all> are then appropriately validated!

Similarly searches including the village's name fail as the latter's name starts with the letter ... it's a real ugger;~/ None of this was problematic before the update.

To update I merely overloaded the new version's files into the appropriate directories after having run the config/secure switches and then ran through the configure exercise as a check. All the albums have been manually post-updated. I have not yet tried adding any photos yet.

Have I done something incorrect during the update or are you already working on it?

I am reticent at posting the site's URL here in the clear, if a moderator would like to confirm this issue directly on my site then please supply an email address and/or reference that I may otherwise use.

best wishes, Robert

joan

Joined: 2002-10-21
Posts: 3473

Posted: Mon, 2003-10-20 15:34

Thanks

Looks like the same as this bug: http://sourceforge.net/tracker/index.php?func=detail&aid=814926&group_id=7130&atid=107130

Better do some testing and get it fixed

robert070612

Joined: 2003-08-05
Posts: 565

Posted: Mon, 2003-10-20 15:53

I am sorry, confused, did you want me to test and/or fix it?

Feel it's probably something to do with bolding (not carriage returns or brians or brains or the start of words). The file search.php has some likely suspects...

best wishes, Robert

joan

Joined: 2002-10-21
Posts: 3473

Posted: Mon, 2003-10-20 16:37

I better do some testing and get it fixed

Sorry for the confusion!

robert070612

Joined: 2003-08-05
Posts: 565

Posted: Mon, 2003-10-20 23:28

Joan

Have sent you the URL of the problem site (by another route).

I use Mozilla 1.5rc2 and have disallowed popups. During the update I think there was a popup attempt...(?) I thought it somewhat odd that I was obliged to manually traverse all my albums - to get them suitably updated. Have been wandering and saw that you handle the update.php file so perhaps this was of interest.

The search problem seems to be connected with a built-in blindness to searching for . It really doesn't like the letter "b". I get different results to seaches run for "bb" than I do for "BB". From the embolded results it appears that the search interpreted/run ostensibly for "BB" ended up *finding* all the extra characters I have been putting into the title descriptions! The emboldened result omits the leading chevron and the letter b, showing r> and all after etc.

best wishes, Robert

bharat

Joined: 2002-05-21
Posts: 7994

Posted: Tue, 2003-10-21 00:48

Robert, here's something you can do to help us narrow this down.
Edit search.php and look for this code:

$searchstring = escapeEregChars ($searchstring); 
$searchstring = str_replace ("\\*", ".*", $searchstring);

Right after that, add this line:
print "Search criteria: " . htmlentities($searchstring) . " ";

Then, when you do your search, it should say at the top what its using as the search criteria. For me, it says:

Search criteria: football

which looks pretty normal and should act normally. What does it say for you?

print "Search criteria: " . htmlentities($searchstring) . " ";

robert070612

Joined: 2003-08-05
Posts: 565

Posted: Tue, 2003-10-21 07:08

Bharat

Done, it says...
Search criteria: \f\o\o\t\b\a\l\l
...and the search apparently fails.

(have supplied my URL by another route if you need to check further)

best wishes, Robert

joan

Joined: 2002-10-21
Posts: 3473

Posted: Tue, 2003-10-21 08:51

OK, we solved this offline. It was already fixed in the 1.4.1, which is out RSN, and you can download the latest pre-release version from http://jpmullan.com/galleryupdates/

The fix for 1.4 is to replace escapeEregChars in util.php with this:

function escapeEregChars($string) {
        return ereg_replace('(\.|\\\\|\+|\*|\?|\[|\]|\^|\$|\(|\)|\{|\}|\=|\!|<|>|\||\', '\\\\1', $string);
}

robert070612

Joined: 2003-08-05
Posts: 565

Posted: Tue, 2003-10-21 09:00

My thanks to you all. Our football fraternity can now find their way around using the searchbox once again I think they need all the help they can get after fielding a less than full team (away) last week and losing 11-1...

best wishes, Robert

robert070612 Joined: 2003-08-05 Posts: 565	Posted: Mon, 2003-10-20 15:20
	Sirs Just updated my village's website from <gallery-1.3.4-pl1> to <gallery-1.4-pl2>. The football enthusiasts are now unable to use the search phrase <football match> because the gallery software has seemingly, and very suddenly, developed an issue searching with the letter <b>. The search use of <foot> and <match> is OK but <footb> is not. Somewhat accidently <ball> succeeds as the letters <all> are then appropriately validated! Similarly searches including the village's name fail as the latter's name starts with the letter <B>... it's a real ugger;~/ None of this was problematic before the update. To update I merely overloaded the new version's files into the appropriate directories after having run the config/secure switches and then ran through the configure exercise as a check. All the albums have been manually post-updated. I have not yet tried adding any photos yet. Have I done something incorrect during the update or are you already working on it? I am reticent at posting the site's URL here in the clear, if a moderator would like to confirm this issue directly on my site then please supply an email address and/or reference that I may otherwise use. best wishes, Robert
	XUser login Username: * Password: * Create new account Request new password
joan Joined: 2002-10-21 Posts: 3473	Posted: Mon, 2003-10-20 15:34
	Thanks Looks like the same as this bug: http://sourceforge.net/tracker/index.php?func=detail&aid=814926&group_id=7130&atid=107130 Better do some testing and get it fixed

robert070612 Joined: 2003-08-05 Posts: 565	Posted: Mon, 2003-10-20 15:53
	I am sorry, confused, did you want me to test and/or fix it? Feel it's probably something to do with bolding (not carriage returns or brians or brains or the start of words). The file search.php has some likely suspects... best wishes, Robert

joan Joined: 2002-10-21 Posts: 3473	Posted: Mon, 2003-10-20 16:37
	I better do some testing and get it fixed Sorry for the confusion!

robert070612 Joined: 2003-08-05 Posts: 565	Posted: Mon, 2003-10-20 23:28
	Joan Have sent you the URL of the problem site (by another route). I use Mozilla 1.5rc2 and have disallowed popups. During the update I think there was a popup attempt...(?) I thought it somewhat odd that I was obliged to manually traverse all my albums - to get them suitably updated. Have been wandering and saw that you handle the update.php file so perhaps this was of interest. The search problem seems to be connected with a built-in blindness to searching for <br>. It really doesn't like the letter "b". I get different results to seaches run for "bb" than I do for "BB". From the embolded results it appears that the search interpreted/run ostensibly for "BB" ended up finding all the extra <br> characters I have been putting into the title descriptions! The emboldened result omits the leading chevron and the letter b, showing r> and all after etc. best wishes, Robert

bharat Joined: 2002-05-21 Posts: 7994	Posted: Tue, 2003-10-21 00:48
	Robert, here's something you can do to help us narrow this down. Edit search.php and look for this code: $searchstring = escapeEregChars ($searchstring); $searchstring = str_replace ("\\", ".", $searchstring); Right after that, add this line: print "Search criteria: " . htmlentities($searchstring) . "<br>"; Then, when you do your search, it should say at the top what its using as the search criteria. For me, it says: Search criteria: football which looks pretty normal and should act normally. What does it say for you? print "Search criteria: " . htmlentities($searchstring) . "<br>";

robert070612 Joined: 2003-08-05 Posts: 565	Posted: Tue, 2003-10-21 07:08
	Bharat Done, it says... Search criteria: \f\o\o\t\b\a\l\l ...and the search apparently fails. (have supplied my URL by another route if you need to check further) best wishes, Robert

joan Joined: 2002-10-21 Posts: 3473	Posted: Tue, 2003-10-21 08:51
	OK, we solved this offline. It was already fixed in the 1.4.1, which is out RSN, and you can download the latest pre-release version from http://jpmullan.com/galleryupdates/ The fix for 1.4 is to replace escapeEregChars in util.php with this: function escapeEregChars($string) { return ereg_replace('(\.\|\\\\\|\+\|\*\|\?\|\[\|\]\|\^\|\$\|\(\|\)\|\{\|\}\|\=\|\!\|<\|>\|\\|\|\', '\\\\1', $string); }

robert070612 Joined: 2003-08-05 Posts: 565	Posted: Tue, 2003-10-21 09:00
	My thanks to you all. Our football fraternity can now find their way around using the searchbox once again I think they need all the help they can get after fielding a less than full team (away) last week and losing 11-1... best wishes, Robert

(1.4-pl2 update) now cannot search with the letter b

XUser login