New module - EXIF Auto-rotate

One of the issues with auto rotate is: We have to flag the image as already rotated some how if we do this. This could be done in the DB or rewrite the EXIF.
I would go for the DB method in a new table or a new column for the items table. We don't want to screw around with the original, or we could have the 'keep original' module as a requirement & go with the EXIF alteration.
We need to do that because if the user wants to run, say a maintenance task, to rotate images, we need to know if they have been rotated already, or the task might rotate an already rotated image.
What do we do with items that are added that have been rotated already and have the wrong orientation? Do we rotate them again and notify the user or do we blindly rotate them without notification?

Just some of the points to consider.

Dave

_____________________________________________
Blog & G2 || floridave - Gallery Team

This is a good topic to explore. Some thoughts:

If the plan is to preserve whatever they had in G2, then we can just replay any rotation operations in the derivativeOperations, right? Doesn't matter if they kept the original or not, once we replay all the rotations we have reproduced whatever they had in G2. The downside to that is that it's a destructive operation for the G3 copy, but then again they have the original from G2 if they need to go back. So that seems doable.

For newly uploaded images, I think we could write an "autorotate" module that intercepts the original at upload time and rotates it. In that case we don't care what's in the EXIF cause we're only doing it once at upload time. I bet that's pretty easy to do as well, and it can be done as a 3rd party module.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

https://sourceforge.net/apps/trac/gallery/ticket/1274 -- I'll take care of that.

I don't think that we have a specific module for this, but you can create a module that listens for the add_photos_form_completed event. At that point if the EXIF module is available, you'll have the exif info and you can call grallery_graphics::rotate on the image if you need to.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

The G2 import rotation issue (ticket https://sourceforge.net/apps/trac/gallery/ticket/1274) is fixed in git.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

EDIT: Ignore this, I think I've got it working.

OK, I'm stumped. I've tried everything I can think of to listen for the add_photos_form_completed event, but can't get it to fire off. I'm basing my initial listener on the notification_event.php file, creating an autorotate_event.php file, with static function add_photos_form_completed($item). However, it doesn't appear to trigger at all...any suggestions would be appreciated.

--
For PHPNuke, phpBB2, and phpBB3 integration help, please visit NukedGallery.net.

Here's more info:

[Tue Aug 17 14:44:37 2010] [error] [client 166.20.224.14] convert: missing an image filename `/home/dmolavi/public_html/www.xxx.com/gallery3/var/tmp/rotateSlunEB' @ error/convert.c/ConvertImageCommand/2923.
[Tue Aug 17 14:44:37 2010] [error] [client 166.20.224.14] convert: no decode delegate for this image format `/home/dmolavi/public_html/www.xxx.com/gallery3/var/tmp/k2img--1e6f8d35d9924ad932a4fc98fd9c8fd4c365d82erotateSlunEB' @ error/constitute.c/ReadImage/533.
[Tue Aug 17 14:44:37 2010] [error] [client 166.20.224.14] convert: Insufficient memory (case 4) `/home/dmolavi/public_html/www.xxx.com/gallery3/var/tmp/k2img--1e6f8d35d9924ad932a4fc98fd9c8fd4c365d82erotateSlunEB' @ error/jpeg.c/EmitMessage/233.

The insufficient memory worries me, though uploads w/ autorotate of the same file to my G2 install work just fine on the same server...

More info here...when I try to rotate one of these photos via the "rotate" option in the photo menu, I get the following in /var/logs:

2010-08-17 13:23:07 -07:00 --- error: ORM_Validation_Exception [ 44 ]: ORM Validation has failed for items model
/home/dmolavi/public_html/www.xxx.com/gallery3/system/libraries/ORM_Validation_Exception.php [ 20 ]
#0 /home/dmolavi/public_html/www.xxx.com/gallery3/system/libraries/ORM.php(755): ORM_Validation_Exception_Core::handle_validation('items', Object(Validation))
#1 /home/dmolavi/public_html/www.xxx.com/gallery3/modules/gallery/models/item.php(787): ORM_Core->validate(NULL)
#2 /home/dmolavi/public_html/www.xxx.com/gallery3/system/libraries/ORM.php(778): Item_Model->validate()
#3 /home/dmolavi/public_html/www.xxx.com/gallery3/modules/gallery/libraries/MY_ORM.php(23): ORM_Core->save()
#4 /home/dmolavi/public_html/www.xxx.com/gallery3/modules/gallery/libraries/ORM_MPTT.php(79): ORM->save()
#5 /home/dmolavi/public_html/www.xxx.com/gallery3/modules/gallery/models/item.php(428): ORM_MPTT_Core->save()
#6 /home/dmolavi/public_html/www.xxx.com/gallery3/modules/gallery/controllers/quick.php(42): Item_Model->save()
#7 [internal function]: Quick_Controller->rotate('4950', 'cw')
#8 /home/dmolavi/public_html/www.xxx.com/gallery3/system/core/Kohana.php(331): ReflectionMethod->invokeArgs(Object(Quick_Controller), Array)
#9 /home/dmolavi/public_html/www.xxx.com/gallery3/system/core/Event.php(208): Kohana_Core::instance(NULL)
#10 /home/dmolavi/public_html/www.xxx.com/gallery3/application/Bootstrap.php(67): Event_Core::run(Array, Array)
#11 /home/dmolavi/public_html/www.xxx.com/gallery3/index.php(94): require('/home/dmolavi/p...')
#12 {main}
2010-08-17 13:23:07 -07:00 --- error: Validation errors: Array
(
    [name] => cant_change_mime_type
)

Additionally, the errors at the top of this reply also appear in my server log.

These errors appear only when trying to autorotate (or rotate via the photo menu) the shots from my DSLR (a Canon EOS Rebel XT). I don't know why it doesn't work w/ G3, but it does work w/ G2...bharat?

--
For PHPNuke, phpBB2, and phpBB3 integration help, please visit NukedGallery.net.

cripes, at work now and won't be able to drop it into git until tonight, but i attached it to this post: http://gallery.menalto.com/node/97270#comment-350904 .

--
For PHPNuke, phpBB2, and phpBB3 integration help, please visit NukedGallery.net.

I checked it into my fork.

--
For PHPNuke, phpBB2, and phpBB3 integration help, please visit NukedGallery.net.

Bharat, for shits and giggles, try it with the photo I emailed to you. If it still works, it must be a hostgator thing, still can't figure out what's different between the G2 and G3 convert call though. I'll update the codex page, as well.

--
For PHPNuke, phpBB2, and phpBB3 integration help, please visit NukedGallery.net.

actually, it looks like the "nice" produces inconsistent results. removing "flatten" in addition to adding "nice" is probably the best option.

--
For PHPNuke, phpBB2, and phpBB3 integration help, please visit NukedGallery.net.

I've found the cause of this problem on shared hosts. It's two-fold:
1. The use of the "flatten" option.
2. The lack of "nice" before the convert command.

To get this working, you will need to modify gallery3/system/libraries/drivers/Image/ImageMagick.php .

Replace:

public function rotate($amt)
    {
        if ($error = exec(escapeshellcmd($this->dir.'convert'.$this->ext).' -background '.$this->background.' -flatten -rotate '.escapeshellarg($amt).' -background transparent '.$this->cmd_image.' '.$this->cmd_image))
        {
            $this->errors[] = $error;
            return FALSE;
        }
        return TRUE;
    }

with this:

	public function rotate($amt)
	{
		if ($error = exec('nice '.escapeshellcmd($this->dir.'convert'.$this->ext).' -background '.$this->background.' -rotate '.escapeshellarg($amt).' -background transparent '.$this->cmd_image.' '.$this->cmd_image))
		{
			$this->errors[] = $error;
			return FALSE;
		}

		return TRUE;
	}

--
For PHPNuke, phpBB2, and phpBB3 integration help, please visit NukedGallery.net.

Not sure if it matters, but the module was written against the latest code in git, not RC2...

--
For PHPNuke, phpBB2, and phpBB3 integration help, please visit NukedGallery.net.

are you referring to the "nice" patch above?

who is your host? this is not a G3 problem as much as it is a Kohana problem (G3 uses their image processing framework to handle this).

--
For PHPNuke, phpBB2, and phpBB3 integration help, please visit NukedGallery.net.

Hi all,

I added autorotate module on my Gallery3, and seems like it's not working.

Checked the log and it showed this:

2010-11-10 23:49:53 +08:00 --- error: @todo autorotate_event::item_created() failed
2010-11-10 23:49:53 +08:00 --- error: The specified image, C:/Program Files/Apache Software Foundation/Apache2.2/htdocs/gallery/var/tmp/rotC3.tmp, is not an allowed image type.

It seems like it's changed to a .tmp file, which autorotate just doesn't recognize it.

Does anyone have idea on this? Thank you very much.....

hmm...the tempnam call just creates a random file name...appending .jpg shouldn't be required, as it's in the file header itself, and the same logic is used in gallery 2 (no .jpg appended to the filename). did you have to make this same change there?
--
For Gallery 3 modules and themes, visit GalleryModules.com.
For PHPNuke, phpBB2, and phpBB3 integration help, visit NukedGallery.net.

are you using imagemagik? what version? i wonder if there's something going on there...

--
For Gallery 3 modules and themes, visit GalleryModules.com.
For PHPNuke, phpBB2, and phpBB3 integration help, visit NukedGallery.net.

Hmm..ok. I don't know why this didn't pop up in G2, but I'll have to mull over the change before committing it.

--
For Gallery 3 modules and themes, visit GalleryModules.com.
For PHPNuke, phpBB2, and phpBB3 integration help, visit NukedGallery.net.

Well, I found the problem. I'm not sure why my particular PHP is complaining about it, but I had issues being reported in the logs about split() being deprecated. I fixed those (replaced with comparable preg_split() calls) and then I found a couple more split() calls in the keeporiginal module that I had to fix. Then I had to install the php5 calendar extension which I lacked. Finally, unixtojd() was complaining about being passed a string, so I had to change line to this:

$this->day_count = unixtojd(strtotime($timestamp));

That seems to have done the trick. Images are now being automatically rotated when adding them to an album!

Hopefully anyone else seeing strange errors will benefit from this. Watching the log files in <g3dir>/var/log and knowing enough PHP (or another similar language) to find and debug the calls was all I needed to fix it, but it'd be nice if the upstream (e.g. git) sources were updated to perhaps handle PHP installs where split() usage causes an error?