Keep Original Module

I've noticed that when rotating images, Gallery 3 will overwrite the original photo with the rotated version. Are there any other situations in which Gallery will modify the original photo?

Update:
The Keep Original Module will make a backup copy of the original uploaded photo before galllery rotates it. The lastest version can be found in this post, or on github.

---
Report Problems/Suggestions Here | Get latest version | Documentation | Coffee Fund | My Library | My GitHub

This thread makes it sound like gallery is designed that way, but I don't know if that's just for the beta of its its final:
http://gallery.menalto.com/node/88837

Yea, I did that by accident and turned a 4 megabyte photo into a 1 megabyte file, so I'm wondering if there are any other buttons that I need to be careful about too.

rWatcher, that was a hint.
Seeing that you have a few under your belt already!

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

I was thinking, rather then duplicate every photo as its uploaded, it'd be nice if full sizes were only duplicated before they were actually modified. Then, if later you decided to undo the modification, you could just click on a "restore" button and have the original put back. Kinda like this:
http://github.com/rWatcher/gallery3-contrib/tree/master/modules/keeporiginal
This should automatically copy a photo over to an "original" directory before it's rotated, and create a menu option for copying it back. As far as I know rotating is the only time the original is edited, but this could easily be extended to cover other areas (like watermarking) if necessary.

I would definitely not recommend trying this on anything other then Beta 2. As modifying the original image doesn't trigger any kind of event, I had to create a modified version of Gallery's graphics library and I don't know how that'll work against anything other then the version it was based off of.

Comments/Thoughts/Suggestions?

Cool, thanks

I don't know if this is because I'm using beta 2 instead of git, but the event lines don't seem to work as an array. If I modify graphics.php like this though:

  static function rotate($input_file, $output_file, $options) {
    if (!self::$init) {
      self::init_toolkit();
    }

    module::event("graphics_rotate", $input_file, $output_file, $options);

    Image::factory($input_file)
      ->quality(module::get_var("gallery", "image_quality"))
      ->rotate($options["degrees"])
      ->save($output_file);

    module::event("graphics_rotate_completed", $input_file, $output_file, $options);
  }

I can then delete the keeporiginals graphics.php file and do everything from within keeporiginal_event.php like this:
http://github.com/rWatcher/gallery3-contrib/tree/master/modules/keeporiginal/helpers/keeporiginal_event.php

@Toshik: http://sourceforge.net/apps/trac/gallery/ticket/607

@rWatcher: I just committed those new events to the main repo, and pulled your new module. Great work!
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git | help! vote!

Very nice work rWatcher!
I am extremely happy to see this module as I always used my galleries as a kind of backup of my pictures (therefore needing to preserve the originals).

Although I haven't been able to see it work yet (probably due to the problem you state above) I am very enthusiastic about your module. Thanks so much!

_________________________
[img]http://indefik.com/pics/forumrandom.jpg[/img] (Random picture from my G2)
[img]http://indefik.com/pics/lyricsrepositorysmall.jpg[/img]

Since you already know of some problems, I don't see any reason to post them.
But if at some point you think you need some tests done, don't hesitate to ask.

I already have the module installed, but it won't work just yet...

Sorry, I had changed the API out from under you. But I didn't like the new API and I've done the necessary magic to change it back. Your event handling code should work properly now.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git | help! vote!

Hmmm. Okay, what I think is happening is that you're not actually uninstalling the module. You're just deactivating it, which means that when you reactivate it Gallery is assuming that its still installed properly thus does not run the install code again (even though that's not the case). It looks like I definitely need to write some error handling code to display a message if something doesn't copy properly, although I'm not sure if the module should worry about re-creating the original directory if it goes missing, as that's not the sort of thing any of the other modules do...

I've never tried to mess around with the quick menu before, so I'm not sure if there's a module API for that or not, but I'll definitely look into it.

Sure, I can do that.

My guess is this hasn't been built yet. Although I've found that if you need to "fake" an uninstall, deleting the corresponding record from the modules table will force Gallery to run the modules install script again (not really the same thing though as some modules have custom uninstall code for things like deleting their tables).

Mostly because it's extra code that'll make the script take a little bit longer to run. Although given that the copy function is already checking for sub-album related directories I guess one extra check isn't going to make much of a difference.

I couldn't find anything that looked like an API for adding to the quick menu, but everything else is done:
- "Restore Original" renamed to "Restore original".
- Added some error messages for when things don't copy right.
- Added code to re-create the "original" directory in the event it goes missing (I'm pretty sure the module now handles missing directories better then Gallery itself )
- Added code to deal with moving photos/sub-albums to a different parent album (it seems I somehow forgot about this one the first time).
- Everything tested and appears to work fine against the current Gallery 3 git.

Sorry about that, the translation code was mostly there it looks like I just missed one spot. It should be good now.