Problem with notification module

rWatcher
rWatcher's picture

Joined: 2005-09-06
Posts: 716
Posted: Wed, 2009-07-22 18:45

I'm not sure if this is an issue with my server being Windows/IIS instead of linux/Apache or if this is a problem with gallery itself, but I seem to be having an issue with the notification module (the version included with Gallery 3, Beta 2). If I turn on notification, and I'm logged in as a regular user, gallery's do not load. No error is displayed, and nothing is generated in var/logs. However I did manage to track down the problem this this line of code in helpers/notification_menu.php:

Quote:
$menu->get("options_menu")
->append(Menu::factory("link")
->id("watch")
->label($label)
->css_id("gNotifyLink")
->url(url::site("notification/watch/$item->id?csrf=" . access::csrf_token())));

It seems that if I'm logged in as a regular (non-admin) user, and in an album where I don't have permissions to edit anything or upload photos, I don't get an options menu, thus causing the script to crash. If I'm logged in as an admin user, or as a regular user who does have permissions to edit the current album, everything works fine. If I change the above code to insert the "Enable notifications" option into the root menu instead of options like so, everything works fine:

Quote:
$menu
->append(Menu::factory("link")
->id("watch")
->label($label)
->css_id("gNotifyLink")
->url(url::site("notification/watch/$item->id?csrf=" . access::csrf_token())));

Is this a bug in the code, or is this just an issue with my unsupported platform?
 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7985
Posted: Thu, 2009-07-30 18:21

This should be fixed now.. can you check again?
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git | help! vote!
 
rWatcher
rWatcher's picture

Joined: 2005-09-06
Posts: 716
Posted: Sun, 2009-08-02 19:20

Yup, works fine now, thanks :)