Links to New Windows

Something that is useful to me is to have embedded links in my Gallery to open new windows.

After looking through the code, I have changed the following code in the file /gallery2/lib/smarty_plugins/modifier.markup.php:

(open bracket with space behind "[ url" to suppress BBCode, in actual code there would not be the space behind the open bracket)

if ($openClose == 'all') {
	    if (preg_match('/^(http|ftp|mailto|https):/', $elementContents)) {
		return sprintf('<a href="%s">%s</a>', $elementContents, $elementContents);
	    } else {
		return sprintf('[ url=%s]', $elementContents, $elementContents);
	    }
	} else if ($openClose == 'open') {
	    if (preg_match('/^(http|ftp|mailto|https):/', $attrs['default'])) {
		$lastOpenSuccess = true;
		return sprintf('<a href="%s">', $attrs['default']);
	    } else {
		$lastOpenSuccess = false;
		return sprintf('[ url=%s]', $attrs['default']);
	    }
	} else if ($openClose == 'close') {
	    if (isset($lastOpenSuccess) && $lastOpenSuccess) {
		return '</a>';
	    } else {
		return '[/url]';
	    }
	} else {
	    return false;
	}

to:

if ($openClose == 'all') {
	    if (preg_match('/^(http|ftp|mailto|https):/', $elementContents)) {
		return sprintf('<a href="%s" target="_blank">%s</a>', $elementContents, $elementContents);
	    } else {
		return sprintf('[ url=%s]', $elementContents, $elementContents);
	    }
	} else if ($openClose == 'open') {
	    if (preg_match('/^(http|ftp|mailto|https):/', $attrs['default'])) {
		$lastOpenSuccess = true;
		return sprintf('<a href="%s" target="_blank">', $attrs['default']);
	    } else {
		$lastOpenSuccess = false;
		return sprintf('[ url=%s]', $attrs['default']);
	    }
	} else if ($openClose == 'close') {
	    if (isset($lastOpenSuccess) && $lastOpenSuccess) {
		return '</a>';
	    } else {
		return '[/url]';
	    }
	} else {
	    return false;
	}

This seems to work in getting new winsows to open with these embedded links. Hope this helps someone else.

Shawn Connelly
hyperSystems, Inc. http://www.hypersystems.us
phone: 720-260-3200, fax: 303-740-0329

Can this modification be made in a way that doesn't get wiped out on each upgrade of gallery or does that mean basically integrating this option into gallery code?

Currently, no. Unless it becomes a feature that is an option which can be turned off and on, if you modify core files that are not "localized" template files they will be overwritten on an upgrade.

sorry to dig on an old thread.

is there a way that instead of opening in a new full size window(browser) this will open in a pop up window instead?

- guilliam

First, you need to edit the same file; /gallery2/lib/smarty_plugins/modifier.markup.php

As of version 2.3, you need to edit lines 173 and 176. For a new window, I've added target="_blank". For a popup, you'd want to add in some javascript or some other method, like what's described here; http://binnyva.blogspot.com/2006/04/best-way-to-open-popup.html

/* Output of HTML. */
/* The code is like [ url ]http://.../[ /url ] */
if (!isset($attributes['default'])) {
    return '<a href="' . $content . '" rel="nofollow" target="_blank">' . $content . '</a>';
} else {
    /* The code is like [ url=http://.../ ]Text[ /url ] */
    return '<a href="' . $attributes['default'] . '" rel="nofollow" target="_blank">'
        . $content . '</a>';
}

____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

Very useful,,,,thanks for the tip & the work!!!

Kevin Logan

As of 2.2.4

First, the file is there, but it looks like the code has changed. Make sure you are looking at /gallery2/lib/smarty_plugins and not /gallery2/lib/smarty/plugins

This is untested!
Now, it looks like you would still edit /gallery2/lib/smarty_plugins/modifier.markup.php

Around line 170 you should find a bit of code that looks like this:

	} else {
	    /* Output of HTML. */
	    /* The code is like http://.../ */
	    if (!isset ($attributes['default'])) {
		return '<a href="' . $content . '">' . $content . '</a>';
	    } else {
		/* The code is like Text */
		return '<a href="' . $attributes['default'] . '">' . $content . '</a>';
	    }
	}

Change two lines in that bit of code to this:

	} else {
	    /* Output of HTML. */
	    /* The code is like http://.../ */
	    if (!isset ($attributes['default'])) {
		return '<a href="' . $content . ' target="_blank" ">' . $content . '</a>';
	    } else {
		/* The code is like Text */
		return '<a href="' . $attributes['default'] . ' target="_blank" ">' . $content . '</a>';
	    }
	}

Again, this is untested.
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

In version 2.3, same file, modifier.markup.php, lines 170-178 just add target="_blank" twice before rel="nofollow":

/* Output of HTML. */
/* The code is like http://.../ */
if (!isset($attributes['default'])) {
return '<a href="' . $content . '" target="_blank" rel="nofollow">' . $content . '</a>';
} else {
/* The code is like Text */
return '<a href="' . $attributes['default'] . '" target="_blank" rel="nofollow">'
. $content . '</a>';
}