Album treeview

Barre

Joined: 2004-07-14
Posts: 48
Posted: Thu, 2005-04-21 06:20

Hi.

I’m trying to learn how to write modules for gallery2 (I’m trying at the same time to learn PHP :) ).

Anyhow, this is my first take on a module and I really must thank Alan Harder for the “Album Select

AttachmentSize
albumtreeview-0.9.1.zip22.04 KB
 
buut
buut's picture

Joined: 2003-06-18
Posts: 196
Posted: Thu, 2005-04-21 12:21

Barre,

It must have been something more than some copy and paste work! Good Job!

Although my long album names makes G2 to shift a whole screen to the right, it looks great to me!

 
Barre

Joined: 2004-07-14
Posts: 48
Posted: Thu, 2005-04-21 15:07

oh.. thanks.
I'm currently working on phpunit coding and I've found a lot of bugs in the attached albumtreeview module.

I will upload a new one soon.
cheers

 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Thu, 2005-04-21 15:33

Barre, very cool.. if you're up for it, you might consider merging your module with Album Select, with a site admin option to pick the standard html <select> or the fancy tree. Post the modified albumselect module (with any new unit tests) here and we'll get it into cvs.. thanks!

 
Barre

Joined: 2004-07-14
Posts: 48
Posted: Thu, 2005-04-21 18:21

Hi mindless.

I've uploaded the updated version in my original post.
It should include the phpunit tests (i'm not really sure on the syntax and what I really should do in the unit tests) but I found some bugs in my first version when trying to create the unit tests.

I'm really not the man to merge the Album Select with the TreeView, I'm kind of out on deep water when developing for G2.... it's fun though :)

Anyhow, I have no problems with anyone else merging the two modules and I don't think it's going to be any problems including the java-scripts either. I have included the original auther within the code and left any credits intact.
this is the text found in the java-script

/*--------------------------------------------------|

| dTree 2.05 | www.destroydrop.com/javascript/tree/ |

|---------------------------------------------------|

| Copyright (c) 2002-2003 Geir Landrö               |

|                                                   |

| This script can be used freely as long as all     |

| copyright messages are intact.                    |

|                                                   |

| Updated: 17.04.2003                               |

|--------------------------------------------------*/

Now, I'm on the localization part of G2... always something new to learn.

Is there a list of events generated by the core?

cheers

 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Thu, 2005-04-21 18:44

Barre, great! I'll take a look when I get a chance..

 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Fri, 2005-04-22 15:44

Ok, integrated and committed to cvs.. thanks for the contribution!
See http://gallery.menalto.com/modules.php?op=modload&name=phpWiki&file=index&pagename=Development%20Team

 
edriss
edriss's picture

Joined: 2004-07-19
Posts: 74
Posted: Fri, 2005-04-22 23:11
mindless wrote:
Ok, integrated and committed to cvs.. thanks for the contribution!
See http://gallery.menalto.com/modules.php?op=modload&name=phpWiki&file=index&pagename=Development%20Team

Quick note/question.
Using IE6, when viewing a subdirectory with a longer name, the left "frame" expands to the right to allow the full name to be shown.
In Mozilla (1.0.2), the frame does not expand, so the end of longer names are cut off.

Which is the correct behaviour? (I suppose each has its own merits)...

My setup:
Windows XP (all updates)
PHP 4.3.11
Running IIS
MySQL 5 beta

IE6 and Firefox 1.0.2 (as noted above)

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7993
Posted: Mon, 2005-04-25 00:00

I'm also seeing something similar. As the depth of the tree grows, the right most part of the tree gets displayed and the left side of the tree (with the icons, lines, +/- boxes, etc) is no longer visible.

 
Barre

Joined: 2004-07-14
Posts: 48
Posted: Mon, 2005-04-25 07:41

Strange.. I can't reproduce this.
I'm using the Matrix Theme and layout.
tested with IE 6.0.2900.2180 and FF 1.0.3

I did notice that IE will strech the left menu so that the whole album name will fit, but FF "crops" the name...

I will check more on this when I get the time..

cheers