Bug: AdminEditGroupUsers, remove yourself from admin group

valiant

Joined: 2003-01-04
Posts: 32509
Posted: Tue, 2004-10-12 10:01

I first created a second user x2, then assigned this user Site Admin status.
Logged in x2, browsed to Site Admin, AdminEditGroupUsers and tried to remove myself, x2, from the Site Admin Group, the UI permits this, the controller doesn't.
I get following error:

   Error (ERROR_PERMISSION_DENIED):

    * in file modules/core/classes/helpers/GalleryUserHelper_medium.class at line 208 (gallerystatus::error)
    * in file modules/core/classes/GalleryCoreApi.class at line 389 (galleryuserhelper_medium::assertsiteadministrator)
    * in file modules/core/AdminEditGroupUsers.inc at line 45 (gallerycoreapi::assertuserissiteadministrator)
    * in file main.php at line 161 (admineditgroupuserscontroller::handlerequest)
    * in file main.php at line 47
    * in file main.php at line 40

I propose following fix: Only for the Site Admin group, don't allow removing yourself. Change The View to not list yourself in the drop down list.
 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7985
Posted: Wed, 2004-10-13 04:15

I fixed this. I left the active user in the dropdown (because otherwise, the view reports the group as being empty -- when we know that it is not). But it now gives a nice error if you try to remove yourself.
 
valiant

Joined: 2003-01-04
Posts: 32509
Posted: Wed, 2004-10-13 08:53

thanks :)