Permissions: Change owner flat

jamgold
jamgold's picture

Joined: 2002-11-01
Posts: 79
Posted: Thu, 2003-12-25 19:55

Hi, merry x-mas

having some time today I updated my local gallery2 from CVS this morning and immediately checked out the gallery 1-2 conversion utility. It works great. I am having two problems though:

1) something's awry with the ffmpeg module since it throws up errors as soon as there's a movie in an album - I'll try to fix that myself ...

2) all imported albums belong to the Album Admin, which is anticipated. However, trying to change ownership turns out to be tedious, since you litteraly have to change every item in an album. There does not seem to be any recursion.

Let me know if thats just a user-error of mine, or if there is an intended limitation on the permission system.

Cheers

Jan
 
jamgold
jamgold's picture

Joined: 2002-11-01
Posts: 79
Posted: Thu, 2003-12-25 20:18

Me again

the ffmpeg module barfs when there is an unsupported codec. Maybe this could be handled more gracefully?

Jan
 
jmullan
jmullan's picture

Joined: 2002-07-28
Posts: 974
Posted: Tue, 2003-12-30 20:08

jamgold, does it barf during the import process, or afterwards?
 
jamgold
jamgold's picture

Joined: 2002-11-01
Posts: 79
Posted: Tue, 2003-12-30 20:44
jmullan wrote:
jamgold, does it barf during the import process, or afterwards?

Import is fine, it barfes afterwards when trying to create the thumbnail for the movies in imported albums. I hacked the FfmpegToolkit.class to not throw an error back at all, which is not the right way to do it. There should be code which checks what ffmpeg's response was and generate a generic thumbnail for unknown video formats, IMO. As soon as I have more time I will try to come up with a code snippet to address this.

Jan
 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7988
Posted: Fri, 2004-01-02 22:09

What version of ffmpeg are you using, what's the unsupported codec and what's the movie that you're trying to upload? If I can reproduce this (preferably with a very small movie) I'll be able to fix it.
 
jamgold
jamgold's picture

Joined: 2002-11-01
Posts: 79
Posted: Sat, 2004-01-03 15:49
bharat wrote:
What version of ffmpeg are you using,

ffmpeg-0.4.6-2mdk

bharat wrote:
what's the unsupported codec

RIFF (little-endian) data, AVI and Microsoft ASF

bharat wrote:
and what's the movie that you're trying to upload? If I can reproduce this (preferably with a very small movie) I'll be able to fix it.

Just go to my test gallery http://gallery2.sony.getwip.com/main.php/view/jhm/flicks/

Cheers

Jan
 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7988
Posted: Mon, 2004-01-05 23:26

I grabbed ed95f56df1801f0a02694a2e771a8768.avi since it looked like that one did not have a thumbnail and ran it through ffmpeg. I have ffmpeg 0.4.8 and it was able to handle the file just fine. Can you tell me what you get when you run:

ffmpeg -vstats -i ed95f56df1801f0a02694a2e771a8768.avi

I get:

Input #0, avi, from 'ed95f56df1801f0a02694a2e771a8768.avi':
  Duration: 00:00:20.6, bitrate: 938 kb/s
  Stream #0.0: Video: cvid, 240x180, 12.00 fps
  Stream #0.1: Audio: pcm_s16le, 22050 Hz, mono, 352 kb/s
Must supply at least one output file

which is what the ffmpeg module is expecting...
 
jamgold
jamgold's picture

Joined: 2002-11-01
Posts: 79
Posted: Tue, 2004-01-06 05:11
bharat wrote:
I grabbed ed95f56df1801f0a02694a2e771a8768.avi since it looked like that one did not have a thumbnail and ran it through ffmpeg. I have ffmpeg 0.4.8 and it was able to handle the file just fine. Can you tell me what you get when you run:

I have ffmpeg 0.4.6 and get 

[jhm@sony flicks]$ ffmpeg -vstats -i ed95f56df1801f0a02694a2e771a8768
Input #0, avi, from 'ed95f56df1801f0a02694a2e771a8768':
  Stream #0.0: Video: cvid, 240x180, 12.00 fps, 800 kb/s
  Stream #0.1: Audio: pcm_s16le, 22050 Hz, mono, 352 kb/s
Must supply at least one output file

But

[jhm@sony flicks]$ ffmpeg -i ed95f56df1801f0a02694a2e771a8768 /tmp/x.%04d.jpg
Input #0, avi, from 'ed95f56df1801f0a02694a2e771a8768':
  Stream #0.0: Video: cvid, 240x180, 12.00 fps, 800 kb/s
  Stream #0.1: Audio: pcm_s16le, 22050 Hz, mono, 352 kb/s
Output #0, jpeg, to '/tmp/x.%04d.jpg':
  Stream #0.0: Video: mjpeg, 240x180, 12.00 fps, q=2-31, 200 kb/s
Stream mapping:
  Stream #0.0 -> #0.0
Unsupported codec (id=0) for input stream #0.0
 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7988
Posted: Wed, 2004-01-07 21:41

Ah, I see. Well, ffmpeg is a young product still. Can you see if you can reproduce this problem with their latest code (0.4.8) ? If this is something that they fixed then I'd rather raise the requirement in G2 to a newer version of ffmpeg, than work around it in the code.
 
jamgold
jamgold's picture

Joined: 2002-11-01
Posts: 79
Posted: Thu, 2004-01-08 21:30
bharat wrote:
Can you see if you can reproduce this problem with their latest code (0.4.8) ? If this is something that they fixed then I'd rather raise the requirement in G2 to a newer version of ffmpeg, than work around it in the code.

I upgraded to 0.4.8 (I am running Mandrake 9.2), but no dice. The movie in questions still produces

Unsupported codec (id=0) for input stream #0.0

I think gallery2/modules/ffmpeg/classes/FfmpegToolkit.class must handle ffmpeg errors more gracefully than just throwing an error condition that halts the entire pipeline. In my example I have only two offending files among many, yet the entire album isn't displayed - heck, I only get an unsightly error ;>)

Jan