Ajax requests

I've recently discovered that Gallery doesn't handle errors in AJAX requests. Example: I had bad characters in the Album name and when I go to delete that album, Ajax request would fail with 500 status code, but spinner and dialog would still be visible on screen like "request is still being processed".

To rectify this, I added an error handler in gallery.dialog.js file (put it right after or before "success" ajax handler in "_ajaxify_dialog" function):

error: function(xhr, ajaxOptions, thrownError) {
$("#g-dialog").html(xhr.responseText);
self._set_title();
var size = $.gallery_get_viewport_size();
$("#g-dialog").dialog('option', 'width', size.width() - 200);
$("#g-dialog").dialog("option", "position", "
},

What it does is it replaces HTML of the dialog with text of the error message that server returned. At least now I not only know immediately that requests failed, I also get a full error message (in my case Kahana exception with stack trace).

They are not bad per se, but they are not being validated. My album name has many periods "." like this "2011.12.31-Happy.New.Year", and Gallery apparently doesn't allow multiple periods in the name. But when you add images using Server Add module, names are not totally validated, and albums are created as they are (with many periods), and (of course) I can't delete them afterwards

I figured it out! Look at this commit from May 17: https://github.com/gallery/gallery3/commit/9e2ea2ffedb22f83137db4e5ba4c06b91f11e09d#modules/gallery/models/item.php

When I used Server Add (several weeks ago), that code wasn't there and I was able to add that album. Several days ago I merged with upstream that added extra validation (line 807 in /module/gallery/models/item.php):

// Do not accept files with double extensions, they can cause problems on some
// versions of Apache.
if (substr_count($this->name, ".") > 1) {
$v->add_error("name", "illegal_data_file_extension");
}

Now that check "breaks" my installation, because every album has multiple periods in the name and hence I can't delete them

Ok, I file a ticket.
Thanks for the leg work!

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

Fixed:
https://github.com/gallery/gallery3/commit/b91d28474759c6183d06f93ab1ff7231d792449f

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team