[Patch] Fixes for IdentityProvider and LDAP

Hi there,

after some hours trying to figure out a way to make Gallery3 and module LDAP work with the given LDAP server, I came up with the two patches attached:

gallery3-0001-IdentityProvider-and-user-Some-fixes.patch.gz
-----------------------------------------------------------
IdentityProvider and user: Some fixes

* check for $new_provider::admin_user() before sending the event
* if uninstalling $new_provider failed, log error but still try to
install $current_provider again
* changed user_installer::install() to activate() so that user can be
enabled again after failing the first time

ldap-0001-ldap-Several-fixes-and-improvements.patch.gz
------------------------------------------------------
ldap: Several fixes and improvements

* changed ldap_installer::install() to activate() so that ldap can be
enabled again after failing the first time
* if some information is not available from ldap server return
"better" values (e.g. no group instead of group = NULL)
* added function Ldap_User::loaded() which is called by user profile
* added configurable admin email address if not given by server
* make ldap work when there is no group management on ldap server
(create local groups for everybody and registered_users) and allow
guest user to be managed by server (configurable guest name)
* require everybody_group and registered_users_group to be in groups

The changes regarding renaming install() to activate() could be superfluous with the other fixes since there should not go anything wrong during install and uninstall. However, they do no harm and are really practical if something does go wrong.

Hope you can make some use of those (I diffed against current git checkouts).

Cheers,
Reklov

A bit delayed, but the ticket is created: https://sourceforge.net/apps/trac/gallery/ticket/1834

Hi,

try this command:

patch -p0 < ldap-0001-ldap-Several-fixes-and-improvements.patch

If this doesn't work, be sure that the patchfile is not zipped (ending on .gz); in this case use gunzip to unpack.

Cheers,
Reklov