(I also noted a bug in modules/gallery/helpers/movie.php in the parse for height and width on h264 ffmpeg encoded mp4's) I'll need to dig up the fix I made and submit that... It was missing a ',' in the regexp under these conditions... adding the comma didn't break any other video adds.
EDIT:
The line: if (preg_match("/Stream.*?Video:.*? (\d+)x(\d+)/", $result, $regs)) {
fixed: if (preg_match("/Stream.*?Video:.*?, (\d+)x(\d+)/", $result, $regs)) {
Without that comma, the video dimensions come out wrong... because there is a hex number there that matches before the comma (see below)
Posts: 607
(I also noted a bug in modules/gallery/helpers/movie.php in the parse for height and width on h264 ffmpeg encoded mp4's) I'll need to dig up the fix I made and submit that... It was missing a ',' in the regexp under these conditions... adding the comma didn't break any other video adds.
EDIT:
The line:
if (preg_match("/Stream.*?Video:.*? (\d+)x(\d+)/", $result, $regs)) {fixed:
if (preg_match("/Stream.*?Video:.*?, (\d+)x(\d+)/", $result, $regs)) {Without that comma, the video dimensions come out wrong... because there is a hex number there that matches before the comma (see below)
H264 MP4 file
Stream #0:0(eng): Video: h264 (High) (avc1 / 0x31637661), yuv420p, 640x360FLV file
Stream #0:0: Video: flv1, yuv420p, 640x360, 2000 kb/s, 30.08 tbr, 1k tbn, 1k tbc